Skip to content

Commit 7203b97

Browse files
committed
Remove SHGetMalloc
1 parent 9c40b00 commit 7203b97

2 files changed

Lines changed: 5 additions & 11 deletions

File tree

sakura_core/util/shell.cpp

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -175,22 +175,19 @@ static LRESULT CALLBACK PropSheetWndProc( HWND hwnd, UINT uMsg, WPARAM wParam, L
175175
// (フォルダ名の末尾に'\\'を付加してもWindows 2000では付加しないのと同じ動作になってしまう)
176176
LPSHELLFOLDER pDesktopFolder;
177177
if( SUCCEEDED(::SHGetDesktopFolder(&pDesktopFolder)) ){
178-
LPMALLOC pMalloc;
179-
if( SUCCEEDED(::SHGetMalloc(&pMalloc)) ){
178+
{
180179
LPITEMIDLIST pIDL;
181180
WCHAR* pszDisplayName = szPath;
182181
if( SUCCEEDED(pDesktopFolder->ParseDisplayName(nullptr, nullptr, pszDisplayName, nullptr, &pIDL, nullptr)) ){
183-
SHELLEXECUTEINFO si;
184-
::ZeroMemory( &si, sizeof(si) );
182+
SHELLEXECUTEINFO si = {};
185183
si.cbSize = sizeof(si);
186184
si.fMask = SEE_MASK_IDLIST;
187185
si.lpVerb = L"open";
188186
si.lpIDList = pIDL;
189187
si.nShow = SW_SHOWNORMAL;
190188
::ShellExecuteEx( &si ); // フォルダを開く
191-
pMalloc->Free( (void*)pIDL );
189+
CoTaskMemFree(pIDL);
192190
}
193-
pMalloc->Release();
194191
}
195192
pDesktopFolder->Release();
196193
}

sakura_core/window/CEditWnd.cpp

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3385,22 +3385,20 @@ LRESULT CEditWnd::OnMouseMove( WPARAM wParam, LPARAM lParam )
33853385
cmemDir = GetDocument()->m_cDocFile.GetFilePathClass().GetDirPath().c_str();
33863386

33873387
IDataObject *DataObject;
3388-
IMalloc *Malloc;
33893388
IShellFolder *Desktop, *Folder;
33903389
LPITEMIDLIST PathID, ItemID;
3391-
SHGetMalloc(&Malloc);
33923390
SHGetDesktopFolder(&Desktop);
33933391
DWORD Eaten, Attribs;
33943392
if(SUCCEEDED(Desktop->ParseDisplayName(nullptr, nullptr, cmemDir.GetStringPtr(), &Eaten, &PathID, &Attribs)))
33953393
{
33963394
Desktop->BindToObject(PathID, nullptr, IID_IShellFolder, (void**)&Folder);
3397-
Malloc->Free(PathID);
3395+
CoTaskMemFree(PathID);
33983396
if(SUCCEEDED(Folder->ParseDisplayName(nullptr, nullptr, cmemTitle.GetStringPtr(), &Eaten, &ItemID, &Attribs)))
33993397
{
34003398
LPCITEMIDLIST List[1];
34013399
List[0] = ItemID;
34023400
Folder->GetUIObjectOf(nullptr, 1, List, IID_IDataObject, nullptr, (void**)&DataObject);
3403-
Malloc->Free(ItemID);
3401+
CoTaskMemFree(ItemID);
34043402
#define DDASTEXT
34053403
#ifdef DDASTEXT
34063404
//テキストでも持たせる…便利
@@ -3434,7 +3432,6 @@ LRESULT CEditWnd::OnMouseMove( WPARAM wParam, LPARAM lParam )
34343432
Folder->Release();
34353433
}
34363434
Desktop->Release();
3437-
Malloc->Release();
34383435
}
34393436
}
34403437
}

0 commit comments

Comments
 (0)