Skip to content

Commit edd24de

Browse files
authored
feat(track): performance improvements (#988)
- Adds playwright - Add playwright test which measures how long it takes to zoom in an example spec (from - Improve performance of json-type by removing deep-clones of spec/data #823 (comment)) - Persist resolved spec as a property of GoslingTrackClass so that it doesn't have to be regenerated every time - Minimize number of deep clones of the spec or the data.
1 parent 3bd9607 commit edd24de

15 files changed

+83049
-82
lines changed

.github/workflows/playwright.yml

+27
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
name: Playwright Tests
2+
on:
3+
push:
4+
branches: [ main, master ]
5+
pull_request:
6+
branches: [ main, master ]
7+
jobs:
8+
test:
9+
timeout-minutes: 60
10+
runs-on: ubuntu-latest
11+
steps:
12+
- uses: actions/checkout@v3
13+
- uses: actions/setup-node@v3
14+
with:
15+
node-version: 18
16+
- name: Install dependencies
17+
run: yarn
18+
- name: Install Playwright Browsers
19+
run: yarn playwright install --with-deps chromium
20+
- name: Run Playwright tests
21+
run: yarn playwright test
22+
- uses: actions/upload-artifact@v3
23+
if: always()
24+
with:
25+
name: playwright-report
26+
path: playwright-report/
27+
retention-days: 30

.github/workflows/test.yml

+15
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
name: Playwright Tests 2
2+
on:
3+
issue_comment:
4+
types: [created]
5+
jobs:
6+
test:
7+
timeout-minutes: 60
8+
runs-on: ubuntu-latest
9+
steps:
10+
- uses: actions/checkout@v3
11+
- uses: actions/setup-node@v3
12+
with:
13+
node-version: 18
14+
- name: Install dependencies
15+
run: yarn

.gitignore

+3
Original file line numberDiff line numberDiff line change
@@ -21,3 +21,6 @@ report.*
2121
*.swp
2222
*.swo
2323
*~
24+
/test-results/
25+
/playwright-report/
26+
/playwright/.cache/

e2e/assets/example-spec-expected.png

33.6 KB
Loading

0 commit comments

Comments
 (0)