Skip to content

Commit 61ae824

Browse files
committed
style(gates): clear clippy::ignored_unit_patterns + doc-markdown on G7/G11
The nine `#[ignore]`-marked gate stubs do not need a body; drop the `let _ = ();` placeholder. Backtick `RocksDB` in the G7 / G11 doc headers to satisfy clippy::doc_markdown. Op: compress
1 parent 144e2c1 commit 61ae824

20 files changed

Lines changed: 48 additions & 31 deletions

bin/bitcoin-rs/tests/gates/g01_headers_only_sync.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,4 @@
1111
#[ignore = "requires live bitcoind mainnet RPC for cross-check"]
1212
fn headers_only_sync_parity() {
1313
// Compare bitcoin-rs headers-only mainnet block hashes to bitcoind getblockhash for 0..tip.
14-
let _ = ();
1514
}

bin/bitcoin-rs/tests/gates/g02_ibd_muhash_parity.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,4 @@
1111
#[ignore = "requires full IBD + bitcoind gettxoutsetinfo cross-check"]
1212
fn full_ibd_utxo_root_parity_muhash() {
1313
// Compare sampled bitcoin-rs coinstats muhash values to bitcoind gettxoutsetinfo during IBD.
14-
let _ = ();
1514
}

bin/bitcoin-rs/tests/gates/g03_kernel_parity.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,4 @@
1111
#[ignore = "requires kernel feature + 100k mainnet blocks"]
1212
fn kernel_parity_gate() {
1313
// Validate each block through bitcoin-rs consensus and bitcoinkernel, then compare verdicts.
14-
let _ = ();
1514
}

bin/bitcoin-rs/tests/gates/g04_consensus_vectors.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,8 @@ fn consensus_test_vectors() {
1111
.args(["test", "-p", "bitcoin-rs-consensus", "--no-fail-fast"])
1212
.status()
1313
.expect("spawn cargo");
14-
assert!(status.success(), "consensus crate tests must pass — these include tx_valid.json, tx_invalid.json, script_tests.json, sighash.json");
14+
assert!(
15+
status.success(),
16+
"consensus crate tests must pass — these include tx_valid.json, tx_invalid.json, script_tests.json, sighash.json"
17+
);
1518
}

bin/bitcoin-rs/tests/gates/g05_electrum_parity.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,4 @@
1111
#[ignore = "requires reference electrs build + shared chain"]
1212
fn electrum_protocol_parity() {
1313
// Diff bitcoin-rs electrum responses against reference electrs for the documented method set.
14-
let _ = ();
1514
}

bin/bitcoin-rs/tests/gates/g06_snapshot_roundtrip.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,4 @@
1212
#[ignore = "requires populated UTXO set; covered by `crates/utxo` unit tests for the in-memory path"]
1313
fn snapshot_round_trip() {
1414
// Dump and reload a populated UTXO snapshot, then compare UTXO and coinstats roots.
15-
let _ = ();
1615
}

bin/bitcoin-rs/tests/gates/g07_storage_equivalence.rs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
//! G7 — Storage-backend equivalence.
2-
//! **G7 — Storage-backend equivalence.** RocksDB, MDBX (`signet-libmdbx`), fjall, and redb backends all pass G1–G6 with identical chain results. `cargo bench --bench kvstore_backends` reports throughput + p99 latency for all four in `target/bench-report.md`. **Backend promotion rule:** if MDBX wins by ≥15 % on UTXO-commit p95 AND matches RocksDB on Electrum-history p95, MDBX becomes the new default in the next minor release and the change is documented in the ultrareview log.
2+
//! **G7 — Storage-backend equivalence.** `RocksDB`, MDBX (`signet-libmdbx`), fjall, and redb backends all pass G1–G6 with identical chain results. `cargo bench --bench kvstore_backends` reports throughput + p99 latency for all four in `target/bench-report.md`. **Backend promotion rule:** if MDBX wins by ≥15 % on UTXO-commit p95 AND matches `RocksDB` on Electrum-history p95, MDBX becomes the new default in the next minor release and the change is documented in the ultrareview log.
33
44
#![allow(clippy::expect_used)]
55

@@ -11,5 +11,8 @@ fn storage_backend_equivalence() {
1111
.args(["test", "-p", "bitcoin-rs-storage", "--no-fail-fast"])
1212
.status()
1313
.expect("spawn cargo");
14-
assert!(status.success(), "storage crate tests must pass — backend_equivalence.rs asserts 4-backend aggregate hash equivalence");
14+
assert!(
15+
status.success(),
16+
"storage crate tests must pass — backend_equivalence.rs asserts 4-backend aggregate hash equivalence"
17+
);
1518
}

bin/bitcoin-rs/tests/gates/g08_utreexo_parity.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,4 @@
1111
#[ignore = "requires --utreexo IBD against full-UTXO baseline"]
1212
fn utreexo_parity() {
1313
// Compare utreexo IBD tip and coinstats hash against the full-UTXO rocksdb baseline.
14-
let _ = ();
1514
}

bin/bitcoin-rs/tests/gates/g09_wallet_psbt_roundtrip.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,4 @@
1313
#[ignore = "requires every descriptor type + external signer fixture"]
1414
fn wallet_psbt_round_trip() {
1515
// Build, externally sign, finalize, and submit PSBTs for every documented descriptor family.
16-
let _ = ();
1716
}

bin/bitcoin-rs/tests/gates/g10_reorg_deep.rs

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,16 @@
88
#[test]
99
fn reorg_deep_test() {
1010
let status = std::process::Command::new(env!("CARGO"))
11-
.args(["test", "-p", "bitcoin-rs-chain", "plans_deep_reorg_to_common_fork"])
11+
.args([
12+
"test",
13+
"-p",
14+
"bitcoin-rs-chain",
15+
"plans_deep_reorg_to_common_fork",
16+
])
1217
.status()
1318
.expect("spawn cargo");
14-
assert!(status.success(), "chain crate depth-100 reorg test must pass");
19+
assert!(
20+
status.success(),
21+
"chain crate depth-100 reorg test must pass"
22+
);
1523
}

0 commit comments

Comments
 (0)