net7.0

Author: goswinr

CHANGELOG.md

@@ -8,7 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
-## [0.11.0-net7] - 2025-03-15
+## [0.11.0] - 2025-03-15
 ### Added
 - build for net7.0 too
 

ForPublishing.fsproj

@@ -68,11 +68,11 @@
 
   <ItemGroup>
     <PackageReference Include="FSharp.Core" Version="6.0.7" /> <!-- so that dependabot does not fail, even though it is set to be excluded -->
-    <PackageReference Include="RhinoCommon" Version="8.19.25098.10001-rc" PrivateAssets="All" ExcludeAssets="runtime" />
     <PackageReference Include="Ionide.KeepAChangelog.Tasks" Version="0.1.8" PrivateAssets="All"  />
     <PackageReference Include="Eto.Forms" Version="2.9.0" PrivateAssets="All" /> <!-- so it works on Mac too and doesn't need Mac.Mono https://discourse.mcneel.com/t/rhino-for-mac-wip-goodbye-mono-hello-net-6/131925 -->
 
-    <!-- <PackageReference Include="System.Drawing.Common" Version="7.0.0" ExcludeAssets="runtime" /> -->
+    <PackageReference Include="RhinoCommon" Version="7.0.20314.3001"  Condition="'$(TargetFramework)' == 'net48'"  PrivateAssets="all" ExcludeAssets="runtime" /> <!--should be the same version as Rhino.Scripting and Rhino.Scripting.Extension -->
+    <PackageReference Include="RhinoCommon" Version="8.19.25132.1001" Condition="'$(TargetFramework)' == 'net7.0'" PrivateAssets="all" ExcludeAssets="runtime" /><!--should be the same version as Rhino.Scripting and Rhino.Scripting.Extension -->
 
     <!-- This is probably not working to the editing files because the way files a structured on github does not match the way the are compiled from a one big generated file.-->
     <PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All" IncludeAssets="runtime; build; native; contentfiles; analyzers; buildtransitive" />

README.md

@@ -156,9 +156,14 @@ These are implemented with 3 overloads and  `Optional` and `DefaultParameterValu
         let obj = RhinoScriptSyntax.CoerceRhinoObject(objectId)
         let layerIndex =
             if createLayerIfMissing then
-                UtilLayer.getOrCreateLayer(layer, UtilLayer.randomLayerColor,
-                    UtilLayer.ByParent, UtilLayer.ByParent,
-                    allowAllUnicode,collapseParents).Index
+                UtilLayer.getOrCreateLayer(
+                    layer,
+                    UtilLayer.randomLayerColor,
+                    UtilLayer.ByParent,
+                    UtilLayer.ByParent,
+                    allowAllUnicode,
+                    collapseParents
+                    ).Index
             else
                 RhinoScriptSyntax.CoerceLayer(layer).Index
         obj.Attributes.LayerIndex <- layerIndex
@@ -184,9 +189,14 @@ These are implemented with 3 overloads and  `Optional` and `DefaultParameterValu
                              , [<OPT;DEF(false:bool)>]collapseParents:bool) : unit = //MULTISET
         let layerIndex =
             if createLayerIfMissing then
-                UtilLayer.getOrCreateLayer(layer,
-                    UtilLayer.randomLayerColor, UtilLayer.ByParent,
-                    UtilLayer.ByParent, allowUnicode, collapseParents).Index
+                UtilLayer.getOrCreateLayer(
+                    layer,
+                    UtilLayer.randomLayerColor,
+                    UtilLayer.ByParent,
+                    UtilLayer.ByParent,
+                    allowUnicode,
+                    collapseParents
+                    ).Index
             else
                 RhinoScriptSyntax.CoerceLayer(layer).Index
         for objectId in objectIds do
@@ -203,17 +213,7 @@ These are implemented with 3 overloads and  `Optional` and `DefaultParameterValu
 
 ## .NET Framework or .NET Core?
 
-This library is currently only targeting .NET Framework 4.8.<br>
-However, it should work in .NET 7.0 or higher as well as per [the offical guidelines](https://developer.rhino3d.com/guides/rhinocommon/moving-to-dotnet-7/#migrating-your-plugin)
-
-But I can not be compiled for net7.0.
-C# allows a project with RhinoCommon to compile targeting net7, but arguably it shouldn't.
-F# is stricter and does not allow this. See [dotnet/fsharp#17295 (comment)](https://github.com/dotnet/fsharp/issues/17295#issuecomment-2158893769)
-
-So this libary is waiting for a [RhinoCommon Nuget](https://www.nuget.org/packages/RhinoCommon/#supportedframeworks-body-tab) nuget properly targeting `net7.0`.
-It is actually planned but seems to be tricky because of some hacks from the past:
-https://mcneel.myjetbrains.com/youtrack/issue/RH-77311/Add-.NET-7-target-to-nuget-packages
-
+On Rhino 8.19 or higher, you can use .NET 7.0 too.<br>
 
 
 ## Build from source
@@ -224,7 +224,7 @@ dotnet build ForPublishing.fsproj
 ```
 
 This will first combine all `Scripting_*.fs` files into one file and compile it.<br>
-This is neede because F# type extension are not visible from C# editor tooling.
+This is needed because F# type extensions are not visible from C# editor tooling.
 
 ## Edit the source
 While having all 900 methods on one class in one file is needed for publishing via `ForPublishing.fsproj` <br>