chore: minor adjustments

Author: ernado

telegram/auth/qrlogin/errors.go

@@ -1,16 +1,11 @@
 package qrlogin
 
 import (
-	"errors"
 	"fmt"
 
 	"github.com/gotd/td/tg"
 )
 
-// ErrAlreadyAuthenticated indicates that user is already authenticated
-// and no new QR token is needed.
-var ErrAlreadyAuthenticated = errors.New("already authenticated")
-
 // MigrationNeededError reports that Telegram requested DC migration to continue login.
 type MigrationNeededError struct {
 	MigrateTo *tg.AuthLoginTokenMigrateTo

telegram/auth/qrlogin/qrlogin.go

@@ -159,8 +159,8 @@ func (q QR) Auth(
 	}
 
 	// If token is empty, it means AuthLoginTokenSuccess was returned
-	// and authentication is already complete, but we should wait for the signal
-	if token.String() == "" {
+	// and authentication is already complete, but we should wait for the signal.
+	if token.Empty() {
 		select {
 		case <-ctx.Done():
 			return nil, ctx.Err()
@@ -186,9 +186,9 @@ func (q QR) Auth(
 				return nil, err
 			}
 
-			// If empty token, it means AuthLoginTokenSuccess was returned
-			if t.String() == "" {
-				// QR was scanned and accepted, break out of loop
+			if t.Empty() {
+				// If empty token, it means AuthLoginTokenSuccess was returned.
+				// QR was scanned and accepted, break to import.
 				break
 			}
 

telegram/auth/qrlogin/qrlogin_test.go

@@ -197,7 +197,7 @@ func TestMigrationNeededError_Error(t *testing.T) {
 	a.Equal("migration to 2 needed", err.Error())
 }
 
-// Mock dispatcher that implements the required interface
+// Mock dispatcher that implements the required interface.
 type mockDispatcher struct {
 	handler tg.LoginTokenHandler
 }
@@ -212,32 +212,32 @@ func TestOnLoginToken(t *testing.T) {
 	dispatcher := &mockDispatcher{}
 	loggedIn := OnLoginToken(dispatcher)
 
-	// Verify that handler was set
+	// Verify that handler was set.
 	a.NotNil(dispatcher.handler)
 
 	// Test the handler
 	ctx := context.Background()
 	entities := tg.Entities{}
 	update := &tg.UpdateLoginToken{}
 
-	// First call should send to channel
+	// First call should send to channel.
 	done := make(chan error, 1)
 	go func() {
 		done <- dispatcher.handler(ctx, entities, update)
 	}()
 
-	// Should receive signal
+	// Should receive signal.
 	select {
 	case <-loggedIn:
 		// Good
-	case <-time.After(time.Second):
+	case <-time.After(time.Second * 5):
 		t.Fatal("should receive signal")
 	}
 
-	// Handler should return nil
+	// Handler should return nil.
 	a.NoError(<-done)
 
-	// Second call when channel is full should not block
+	// Second call when channel is full should not block.
 	err := dispatcher.handler(ctx, entities, update)
 	a.NoError(err)
 }
@@ -246,12 +246,12 @@ func TestToken_Image(t *testing.T) {
 	a := require.New(t)
 	token := NewToken([]byte("test_token"), int(time.Now().Unix()))
 
-	// Test with valid QR level
+	// Test with valid QR level.
 	img, err := token.Image(qr.L)
 	a.NoError(err)
 	a.NotNil(img)
 
-	// Test with different QR levels
+	// Test with different QR levels.
 	levels := []qr.Level{qr.L, qr.M, qr.Q, qr.H}
 
 	for _, level := range levels {
@@ -265,7 +265,7 @@ func TestQR_Import_WithMigration(t *testing.T) {
 	ctx := context.Background()
 	a := require.New(t)
 
-	// Test with migration function
+	// Test with migration function.
 	migrateCalled := false
 	migrate := func(ctx context.Context, dcID int) error {
 		migrateCalled = true
@@ -279,7 +279,7 @@ func TestQR_Import_WithMigration(t *testing.T) {
 		User: &tg.User{ID: 10},
 	}
 
-	// First call returns migration needed
+	// First call returns migration needed.
 	mock.ExpectCall(&tg.AuthExportLoginTokenRequest{
 		APIID:   constant.TestAppID,
 		APIHash: constant.TestAppHash,
@@ -302,7 +302,7 @@ func TestQR_Import_MigrationError(t *testing.T) {
 	ctx := context.Background()
 	a := require.New(t)
 
-	// Test with migration function that returns error
+	// Test with migration function that returns error,
 	migrate := func(ctx context.Context, dcID int) error {
 		return testutil.TestError()
 	}

telegram/auth/qrlogin/token.go

@@ -59,6 +59,11 @@ func (t Token) String() string {
 	return base64.URLEncoding.EncodeToString(t.token)
 }
 
+// Empty reports whether token is empty.
+func (t Token) Empty() bool {
+	return len(t.token) == 0
+}
+
 // URL returns login URL.
 //
 // See https://core.telegram.org/api/qr-login#exporting-a-login-token.