From 167f442970dee0b00e1c93e15cbcf8609369464a Mon Sep 17 00:00:00 2001 From: ggqshr Date: Sat, 11 Oct 2025 03:47:41 +0000 Subject: [PATCH 1/5] fix: fix markdown embed image issue --- ui/src/common/Markdown.tsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ui/src/common/Markdown.tsx b/ui/src/common/Markdown.tsx index 33ac661b..694be452 100644 --- a/ui/src/common/Markdown.tsx +++ b/ui/src/common/Markdown.tsx @@ -11,7 +11,8 @@ export const Markdown = ({ }) => ( }} - remarkPlugins={[gfm]}> + remarkPlugins={[gfm]} + urlTransform={(value: string) => value}> {children} ); From 9825769be5bf68e8debfb538b4231e3550f773fe Mon Sep 17 00:00:00 2001 From: ggqshr Date: Sat, 11 Oct 2025 12:13:03 +0000 Subject: [PATCH 2/5] fix urlTransform filter condition --- ui/src/common/Markdown.tsx | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/ui/src/common/Markdown.tsx b/ui/src/common/Markdown.tsx index 694be452..a990e406 100644 --- a/ui/src/common/Markdown.tsx +++ b/ui/src/common/Markdown.tsx @@ -1,7 +1,17 @@ import React from 'react'; -import ReactMarkdown from 'react-markdown'; +import ReactMarkdown,{defaultUrlTransform} from 'react-markdown'; +import type { UrlTransform } from 'react-markdown'; import gfm from 'remark-gfm'; +// Copy from mlflow/server/js/src/shared/web-shared/genai-markdown-renderer/GenAIMarkdownRenderer.tsx +// Related PR: https://github.com/mlflow/mlflow/pull/16761 +const urlTransform: UrlTransform = (value) => { + if (value.startsWith('data:image/png;') || value.startsWith('data:image/jpeg;')) { + return value; + } + return defaultUrlTransform(value); +} + export const Markdown = ({ children, onImageLoaded = () => {}, @@ -12,7 +22,7 @@ export const Markdown = ({ }} remarkPlugins={[gfm]} - urlTransform={(value: string) => value}> + urlTransform={urlTransform}> {children} ); From 82ab0e9dd8c15303fb3d3fc29776a97461033b92 Mon Sep 17 00:00:00 2001 From: ggqshr Date: Sat, 11 Oct 2025 12:38:24 +0000 Subject: [PATCH 3/5] fix code format --- ui/src/common/Markdown.tsx | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/ui/src/common/Markdown.tsx b/ui/src/common/Markdown.tsx index a990e406..521248bf 100644 --- a/ui/src/common/Markdown.tsx +++ b/ui/src/common/Markdown.tsx @@ -1,16 +1,16 @@ import React from 'react'; -import ReactMarkdown,{defaultUrlTransform} from 'react-markdown'; -import type { UrlTransform } from 'react-markdown'; +import ReactMarkdown, {defaultUrlTransform} from 'react-markdown'; +import type {UrlTransform} from 'react-markdown'; import gfm from 'remark-gfm'; // Copy from mlflow/server/js/src/shared/web-shared/genai-markdown-renderer/GenAIMarkdownRenderer.tsx // Related PR: https://github.com/mlflow/mlflow/pull/16761 const urlTransform: UrlTransform = (value) => { - if (value.startsWith('data:image/png;') || value.startsWith('data:image/jpeg;')) { - return value; - } - return defaultUrlTransform(value); -} + if (value.startsWith('data:image/png;') || value.startsWith('data:image/jpeg;')) { + return value; + } + return defaultUrlTransform(value); +}; export const Markdown = ({ children, From 193e5c6cdd3934583c10e44ea8f06f668f775738 Mon Sep 17 00:00:00 2001 From: ggqshr Date: Mon, 13 Oct 2025 00:38:41 +0000 Subject: [PATCH 4/5] add image/gif filter --- ui/src/common/Markdown.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/src/common/Markdown.tsx b/ui/src/common/Markdown.tsx index 521248bf..81da4d83 100644 --- a/ui/src/common/Markdown.tsx +++ b/ui/src/common/Markdown.tsx @@ -6,7 +6,7 @@ import gfm from 'remark-gfm'; // Copy from mlflow/server/js/src/shared/web-shared/genai-markdown-renderer/GenAIMarkdownRenderer.tsx // Related PR: https://github.com/mlflow/mlflow/pull/16761 const urlTransform: UrlTransform = (value) => { - if (value.startsWith('data:image/png;') || value.startsWith('data:image/jpeg;')) { + if (value.startsWith('data:image/png;') || value.startsWith('data:image/jpeg;') || value.startsWith('data:image/gif;')) { return value; } return defaultUrlTransform(value); From 5244fa18fc880d2442517c0cb980c936eb40f65c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=A5=BA=E5=AD=90w=20=28Yumechi=29?= <35571479+eternal-flame-AD@users.noreply.github.com> Date: Mon, 13 Oct 2025 02:11:55 +0000 Subject: [PATCH 5/5] Format code --- ui/src/common/Markdown.tsx | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ui/src/common/Markdown.tsx b/ui/src/common/Markdown.tsx index 81da4d83..aedcfe11 100644 --- a/ui/src/common/Markdown.tsx +++ b/ui/src/common/Markdown.tsx @@ -6,7 +6,11 @@ import gfm from 'remark-gfm'; // Copy from mlflow/server/js/src/shared/web-shared/genai-markdown-renderer/GenAIMarkdownRenderer.tsx // Related PR: https://github.com/mlflow/mlflow/pull/16761 const urlTransform: UrlTransform = (value) => { - if (value.startsWith('data:image/png;') || value.startsWith('data:image/jpeg;') || value.startsWith('data:image/gif;')) { + if ( + value.startsWith('data:image/png;') || + value.startsWith('data:image/jpeg;') || + value.startsWith('data:image/gif;') + ) { return value; } return defaultUrlTransform(value);