feat: remove the connection group count metric from the go routine

Author: siddhanta-rath

services/rest/service.go

@@ -2,16 +2,12 @@ package rest
 
 import (
 	"context"
-	"fmt"
-	"net/http"
-	"time"
-
 	"github.com/gorilla/mux"
 	"github.com/goto/raccoon/collection"
 	"github.com/goto/raccoon/config"
-	"github.com/goto/raccoon/metrics"
 	"github.com/goto/raccoon/services/rest/websocket"
 	"github.com/goto/raccoon/services/rest/websocket/connection"
+	"net/http"
 )
 
 type Service struct {
@@ -24,8 +20,6 @@ func NewRestService(c collection.Collector) *Service {
 	wh := websocket.NewHandler(pingChannel, c)
 	go websocket.Pinger(pingChannel, config.ServerWs.PingerSize, config.ServerWs.PingInterval, config.ServerWs.WriteWaitInterval)
 
-	go reportConnectionMetrics(*wh.Table())
-
 	go websocket.AckHandler(websocket.AckChan)
 
 	restHandler := NewHandler(c)
@@ -50,16 +44,6 @@ func pingHandler(w http.ResponseWriter, r *http.Request) {
 	w.Write([]byte("pong"))
 }
 
-func reportConnectionMetrics(conn connection.Table) {
-	t := time.Tick(config.MetricStatsd.FlushPeriodMs)
-	for {
-		<-t
-		for k, v := range conn.TotalConnectionPerGroup() {
-			metrics.Gauge("connections_count_current", v, fmt.Sprintf("conn_group=%s", k))
-		}
-	}
-}
-
 func (s *Service) Init(context.Context) error {
 	return s.s.ListenAndServe()
 }

services/rest/websocket/connection/table.go

@@ -2,9 +2,11 @@ package connection
 
 import (
 	"errors"
+	"fmt"
 	"sync"
 
 	"github.com/goto/raccoon/identification"
+	"github.com/goto/raccoon/metrics"
 )
 
 var (
@@ -46,6 +48,7 @@ func (t *Table) Store(c identification.Identifier) error {
 	}
 	t.connMap[c] = make(map[string]struct{})
 	t.counter[c.Group] = t.counter[c.Group] + 1
+	metrics.Gauge("connections_count_current", t.counter[c.Group], fmt.Sprintf("conn_group=%s", c.Group))
 	return nil
 }
 
@@ -75,6 +78,7 @@ func (t *Table) Remove(c identification.Identifier) {
 	defer t.m.Unlock()
 	delete(t.connMap, c)
 	t.counter[c.Group] = t.counter[c.Group] - 1
+	metrics.Gauge("connections_count_current", t.counter[c.Group], fmt.Sprintf("conn_group=%s", c.Group))
 }
 
 func (t *Table) TotalConnection() int {