Skip to content

Commit 4b167e5

Browse files
Ali HaiderAli Haider
authored andcommitted
Merge branch 'release/3.x/10.3.5' into 3.x-master
2 parents 7656a6d + a92372e commit 4b167e5

8 files changed

Lines changed: 50 additions & 20 deletions

File tree

.docker/Dockerfile.nginx-drupal

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,3 +33,6 @@ RUN echo 'env JS_SBOM_REPLACE;' >> /etc/nginx/nginx.conf
3333

3434
# Define where the Drupal Root is located
3535
ENV WEBROOT=web
36+
37+
# Add default for resty resolver.
38+
ENV RESTY_RESOLVER=${RESTY_RESOLVER:-8.8.8.8}

.docker/config/simplesaml/config/authsources.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,13 +77,13 @@
7777
/*
7878
* Whether logout requests and logout responses sent to this SP should be signed. The default is FALSE .
7979
*/
80-
'redirect.sign' => TRUE,
80+
'redirect.sign' => filter_var(getenv('SIMPLESAMLPHP_SP_SIGN_AUTH'), FILTER_VALIDATE_BOOLEAN, FILTER_NULL_ON_FAILURE) ?? true,
8181

8282
/*
8383
* Whether authentication requests, logout requests and logout responses received from this SP should be validated.
8484
* The default is FALSE
8585
*/
86-
'redirect.validate' => TRUE,
86+
'redirect.validate' => filter_var(getenv('SIMPLESAMLPHP_SP_VALIDATE_AUTH'), FILTER_VALIDATE_BOOLEAN, FILTER_NULL_ON_FAILURE) ?? true,
8787

8888
/*
8989
* Whether we require signatures on authentication requests sent from this SP. Set it to:

.docker/config/simplesaml/metadata/saml20-idp-remote.php

Lines changed: 25 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -5,19 +5,30 @@
55
$fallbackBinding = getenv('SIMPLESAMLPHP_IDP_DEFAULT_BINDING');
66

77
$bindings = [
8-
'SIMPLESAMLPHP_IDP_HTTP_POST_BINDING' => $fallbackBinding,
9-
'SIMPLESAMLPHP_IDP_HTTP_REDIRECT_BINDING' => $fallbackBinding,
10-
'SIMPLESAMLPHP_IDP_SOAP_BINDING' => $fallbackBinding,
11-
'SIMPLESAMLPHP_IDP_HTTP_ARTIFACT' => $fallbackBinding,
8+
'SIMPLESAMLPHP_IDP_HTTP_POST_BINDING' => $fallbackBinding,
9+
'SIMPLESAMLPHP_IDP_HTTP_REDIRECT_BINDING' => $fallbackBinding,
10+
'SIMPLESAMLPHP_IDP_SOAP_BINDING' => $fallbackBinding,
11+
'SIMPLESAMLPHP_IDP_HTTP_ARTIFACT' => $fallbackBinding,
12+
'SIMPLESAMLPHP_IDP_LOGOUT_HTTP_POST_BINDING' => $fallbackBinding,
13+
'SIMPLESAMLPHP_IDP_LOGOUT_HTTP_REDIRECT_BINDING' => $fallbackBinding,
14+
'SIMPLESAMLPHP_IDP_LOGOUT_SOAP_BINDING' => $fallbackBinding,
15+
'SIMPLESAMLPHP_IDP_LOGOUT_HTTP_ARTIFACT' => $fallbackBinding
1216
];
1317

18+
// Override fallback binding if env variable value is present.
1419
foreach ($bindings as $binding => $fallback) {
15-
$envVar = getenv($binding);
16-
if (empty($envVar)) {
17-
$bindings[$binding] = str_starts_with($fallback, 'http') ? $fallback : $idpBaseURL . $fallback;
18-
continue;
19-
}
20-
$bindings[$binding] = str_starts_with($envVar, 'http') ? $envVar : $idpBaseURL . $envVar;
20+
$envVar = getenv($binding);
21+
22+
// Apply special logic for logout bindings.
23+
if (strpos($binding, 'LOGOUT') !== false) {
24+
if (empty($envVar)) {
25+
// Try fallback to the corresponding non-logout binding first.
26+
$envVar = getenv(str_replace('LOGOUT', '', $binding)) ?: $fallback;
27+
}
28+
}
29+
30+
// Fallback to the base URL if needed.
31+
$bindings[$binding] = str_starts_with($envVar, 'http') ? $envVar : $idpBaseURL . $envVar;
2132
}
2233

2334
$metadata[$idpEntityId] = [
@@ -46,19 +57,19 @@
4657
'SingleLogoutService' => [
4758
[
4859
'Binding' => 'urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST',
49-
'Location' => $bindings['SIMPLESAMLPHP_IDP_HTTP_POST_BINDING'],
60+
'Location' => $bindings['SIMPLESAMLPHP_IDP_LOGOUT_HTTP_POST_BINDING'],
5061
],
5162
[
5263
'Binding' => 'urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect',
53-
'Location' => $bindings['SIMPLESAMLPHP_IDP_HTTP_REDIRECT_BINDING'],
64+
'Location' => $bindings['SIMPLESAMLPHP_IDP_LOGOUT_HTTP_REDIRECT_BINDING'],
5465
],
5566
[
5667
'Binding' => 'urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Artifact',
57-
'Location' => $bindings['SIMPLESAMLPHP_IDP_HTTP_ARTIFACT'],
68+
'Location' => $bindings['SIMPLESAMLPHP_IDP_LOGOUT_HTTP_ARTIFACT'],
5869
],
5970
[
6071
'Binding' => 'urn:oasis:names:tc:SAML:2.0:bindings:SOAP',
61-
'Location' => $bindings['SIMPLESAMLPHP_IDP_SOAP_BINDING'],
72+
'Location' => $bindings['SIMPLESAMLPHP_IDP_LOGOUT_SOAP_BINDING'],
6273
],
6374
],
6475
'ArtifactResolutionService' => [

.docker/images/nginx/helpers/206-x_robots_tag_header.conf

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,9 @@ if ($host ~* ^(?!www\.govcms\.gov\.au$)(?:[\w\-]+\.)+govcms\.gov\.au$){
1111
set $robots_header "none";
1212
}
1313

14+
# Set none for Drupal /admin and /user routes.
15+
if ($uri ~* ^/(admin|user)/.*$) {
16+
set $robots_header "none";
17+
}
18+
1419
add_header X-Robots-Tag $robots_header;

.env.default

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,11 @@ X_FRAME_OPTIONS=SAMEORIGIN
3535

3636
# Set the version of GovCMS and Drupal Core to use - you can use a tag or branch reference (3.x-dev) here
3737
# See https://github.com/govCMS/GovCMS/releases
38-
GOVCMS_PROJECT_VERSION=3.21.2
38+
GOVCMS_PROJECT_VERSION=3.22.0
3939

4040
# Set the Lagoon tag to use for the upstream dockerfiles (e.g. 20.12.0)
4141
# See https://github.com/uselagoon/lagoon-images/releases
42-
LAGOON_IMAGE_VERSION=24.12.0
42+
LAGOON_IMAGE_VERSION=25.2.0
4343

4444
# Set the CLI image name
4545
# Support both legacy (govcms8lagoon/govcms8) and newer (govcms/govcms) images.

.gitlab-ci.yml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,17 @@ stages:
1616
# ---
1717
workflow:
1818
rules:
19+
## D11
20+
- if: $CI_COMMIT_REF_NAME == "4.x-develop"
21+
variables:
22+
DEPLOY_TAG: "11.x-edge"
23+
- if: $CI_COMMIT_REF_NAME == "4.x-master"
24+
variables:
25+
DEPLOY_TAG: "11.x-latest"
26+
- if: $CI_COMMIT_REF_NAME =~ /^release\/4.x\//
27+
variables:
28+
DEPLOY_TAG: "11.x-beta"
29+
1930
## D10
2031
- if: $CI_COMMIT_REF_NAME == "3.x-develop"
2132
variables:

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
## Purpose
44

5-
This project is used to create the images required by Lagoon, using the GovCMS distribution - it is only intended to
5+
This project is used to create the images required by Lagoon, using the GovCMS distribution - it is only intended to
66
be used by distribution/platform maintainers.
77

88
Images are published to the [govcms](https://hub.docker.com/u/govcms) namespace on Docker Hub.

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
"drupal/bartik": "^1.0",
2020
"govcms/govcms": "3.x-develop-dev",
2121
"govcms/govcms-custom": "*",
22-
"govcms/scaffold-tooling": "5.4.0"
22+
"govcms/scaffold-tooling": "5.4.1"
2323
},
2424
"require-dev": {
2525
"drupal/core-dev": "^10.0",

0 commit comments

Comments
 (0)