Skip to content
This repository was archived by the owner on Aug 26, 2021. It is now read-only.
This repository was archived by the owner on Aug 26, 2021. It is now read-only.

Header react module renders <div> instead of <header> #898

Open
@takumi-ae86

Description

@takumi-ae86

Bug Report

  • I’ve read and understood the Contributing guidelines and have done my best effort to follow them.
  • I’ve read and agree to the Code of Conduct.
  • I’ve searched for any related issues and avoided creating a duplicate issue.

What happened

When using the AU header react component the it appears to render a <div class="au_header">

What I expected to happen

From the example in the documentation we expect it would have render a <header class="au_header"> element

Reproducing

  • Module name: @gov.au/header
  • Module version: 4.1.12
  • Pancake version: ~1 (As used by the header component)
"dependencies": {
    "@gov.au/core": "^3.0.0",
    "@gov.au/pancake": "~1",
    "@gov.au/pancake-json": "~1",
    "@gov.au/pancake-react": "~1",
    "@gov.au/pancake-sass": "~2"
  },
  • Node version: v12.13.1

  • npm version: 6.12.1

  • Pancake settings in your package.json:

Steps to reproduce:

  1. Compare the difference between static and react rendering of header component here
    https://auds.service.gov.au/packages/header/tests/react/
    https://auds.service.gov.au/packages/header/tests/site/

Attachments

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions