Order Condition groups by selection option

We want to display the conditions for a page on the page list in the
same order as the selection options on the page.

To do this, we get a list of selection options from the page's answer
settings, and then use this list to sort the conditions.

We turn off the filter for the call to `in_order_of` so that any extra
conditions are included, even if they aren't included in the order.

group_by preservers order when given an array so we are safe to use it
like this.

We still sort by the `goto_page_id` so that the conditions are grouped
by the page they go to and nil comes last.

Author: thomasiles

app/components/page_list_component/view.rb

@@ -101,7 +101,12 @@ def skip_condition_route_page_text(condition)
     end
 
     def answer_value_groups(page)
-      page.routing_conditions.group_by(&:goto_page_id).sort_by { |goto_page_id, _| goto_page_id || Float::INFINITY }
+      answer_order = page.answer_settings&.selection_options&.map(&:value) || []
+
+      page.routing_conditions.to_a
+        .in_order_of(:answer_value, answer_order, filter: false)
+        .group_by(&:goto_page_id)
+        .sort_by { |goto_page_id, _| goto_page_id || Float::INFINITY }
     end
   end
 end

spec/components/page_list_component/view_spec.rb

@@ -563,5 +563,26 @@
       result = page_list_component.answer_value_groups(pages.first)
       expect(result).to eq expected
     end
+
+    context "when given a different order of selection options" do
+      let(:selection_options) do
+        [
+          { value: "Option 3" },
+          { value: "Option 2" },
+          { value: "Option 1" },
+        ]
+      end
+
+      it "returns the conditions in the same order" do
+        expected = [
+          [103, [conditions.second, conditions.first]],
+          [104, [conditions.third]],
+          [nil, [conditions.fourth]],
+        ]
+
+        result = page_list_component.answer_value_groups(pages.first)
+        expect(result).to eq expected
+      end
+    end
   end
 end