Update content for opt in page and add additional testing for user research contact preference

This commit adds the updated content for the contact for research page, as well as addidng tests for the contact for research controller

It also adds a feature test to test the functionality of add a user research contact preference

Author: alice-carr

app/controllers/account/contact_for_research_controller.rb

@@ -2,7 +2,6 @@ module Account
   class ContactForResearchController < ApplicationController
     include AfterSignInPathHelper
 
-    # before_action :redirect_contact_for_research_set
     skip_before_action :redirect_if_account_not_completed
 
     def edit

app/views/account/contact_for_research/edit.html.erb

@@ -9,9 +9,7 @@
         <%=t("page_titles.account_contact_for_research")%>
       </h1>
 
-      <%= t(".content_html") %>
-
-      <%= f.govuk_collection_radio_buttons :research_contact_status, @contact_for_research_input.values, :itself, nil %>
+      <%= f.govuk_collection_radio_buttons :research_contact_status, @contact_for_research_input.values, :itself, legend: nil, hint:{ text: @hint } %>
 
       <%= f.govuk_submit t('continue') %>
     <% end %>

config/locales/en.yml

@@ -1,21 +1,6 @@
 ---
 en:
   account:
-    contact_for_research:
-      edit:
-        content_html: |
-          <p>GOV.UK Forms needs your help to improve and to make sure our platform works well for the people who use it. You can help by agreeing to take part in user research.</p>
-          <p>If you select yes, you will get a confirmation email with a link to our sign up form. When you’ve completed the form, your name will be added to a list that we’ll use to recruit research participants. Your details will be stored in compliance with GDPR.</p>
-          <p>We’ll only contact you about upcoming research or to verify that your details are up to date.</p>
-          <p>We might invite you to:</p>
-
-          <ul class="govuk-list govuk-list--bullet">
-            <li>try out new things we are working on</li>
-            <li>answer questions by survey or email</li>
-            <li>talk to us about how you work with forms</li>
-          </ul>
-
-          <p>You can always say no to an invite and you can ask to be taken off our list at any time.</p>
     organisation_details_summary: If your organisation is not listed
     organisation_text_html: |
       <p>If you’re from a central government organisation that publishes content on the GOV.UK website but your organisation is not listed, please %{contact_link}.</p>
@@ -1154,7 +1139,7 @@ en:
       length: Length
   page_titles:
     access_denied: You do not have permission to access GOV.UK Forms
-    account_contact_for_research: Choose to take part in user research
+    account_contact_for_research: Can we send you an email with information about taking part in user research to improve GOV.UK Forms?
     account_name: Enter your name
     account_organisation: Select your organisation
     account_terms_of_use: Terms of use

config/locales/input_objects/contact_for_research.yml

@@ -6,13 +6,13 @@ en:
         account/contact_for_research_input:
           attributes:
             research_contact_status:
-              blank: Choose if you want to sign up to take part in research
+              blank: Select ‘Yes’ if you’re happy for us to send you an email with information about taking part in user research
   helpers:
+    hint:
+      account_contact_for_research_input:
+        research_contact_status: This is not a commitment to take part. If you say ‘yes’ we’ll send you an email with more details about what’s involved and how to sign up.
     label:
       account_contact_for_research_input:
         research_contact_status_options:
           consented: 'Yes'
           declined: 'No'
-    legend:
-      account_contact_for_research_input:
-        research_contact_status: Do you want to sign up to take part in user research?

spec/features/research/add_user_research_contact_preference_spec.rb

@@ -0,0 +1,30 @@
+require "rails_helper"
+
+feature "Add user research contact preference", type: :feature do
+  let(:user) { create(:user, name: "Test name", research_contact_status: "to_be_asked") }
+
+  before do
+    login_as user
+  end
+
+  describe "user adds their user research content preference" do
+    scenario "user can update their preference" do
+      when_i_visit_the_edit_page
+      when_i_choose_yes
+      then_i_should_be_redirecteed_to_the_groups_page
+    end
+  end
+
+  def when_i_visit_the_edit_page
+    visit edit_account_contact_for_research_path
+  end
+
+  def when_i_choose_yes
+    choose "Yes"
+    click_button "Continue"
+  end
+
+  def then_i_should_be_redirecteed_to_the_groups_page
+    expect(page.find("h1")).to have_text "Your groups"
+  end
+end

spec/requests/account/contact_for_research_controller_spec.rb

@@ -0,0 +1,55 @@
+require "rails_helper"
+
+describe Account::ContactForResearchController do
+  let(:user) { create(:user, name: nil, research_contact_status: "to_be_asked") }
+
+  before do
+    login_as user
+  end
+
+  describe "GET #edit" do
+    context "when user adds a research contact status" do
+      it "assigns a new ContactForResearchInput to @contact_for_research_input" do
+        get edit_account_contact_for_research_path
+        expect(assigns(:contact_for_research_input)).to be_a(Account::ContactForResearchInput)
+      end
+    end
+  end
+
+  describe "PUT #update" do
+    context "with valid params" do
+      let(:valid_params) { { account_contact_for_research_input: { research_contact_status: "consented" } } }
+
+      before do
+        # rubocop:disable RSpec/AnyInstance
+        allow_any_instance_of(AfterSignInPathHelper).to receive(:after_sign_in_next_path).and_return("/next-path")
+        # rubocop:enable RSpec/AnyInstance
+      end
+
+      it "updates the user's research contact status" do
+        put account_contact_for_research_path, params: valid_params
+        expect(user.reload.research_contact_status).to eq("consented")
+      end
+
+      it "redirects to the root path" do
+        put account_contact_for_research_path, params: valid_params
+        expect(response).to redirect_to("/next-path")
+      end
+    end
+
+    context "with invalid params" do
+      let(:invalid_params) { { account_contact_for_research_input: { research_contact_status: "" } } }
+
+      it "does not update the user's research contact status" do
+        put account_contact_for_research_path, params: invalid_params
+        expect(user.reload.research_contact_status).to eq("to_be_asked")
+      end
+
+      it "renders the edit template" do
+        put account_contact_for_research_path, params: invalid_params
+        expect(response).to have_http_status(:unprocessable_content)
+        expect(response).to render_template(:edit)
+      end
+    end
+  end
+end