Add redirect if feature flag isn't enabled

Author: DavidBiddle

app/controllers/forms/welsh_translation_controller.rb

@@ -4,11 +4,15 @@ class WelshTranslationController < WebController
 
     def new
       authorize current_form, :can_view_form?
+      return redirect_to form_path(current_form) unless welsh_enabled?
+
       @welsh_translation_input = WelshTranslationInput.new(form: current_form).assign_form_values
     end
 
     def create
       authorize current_form, :can_view_form?
+      return redirect_to form_path(current_form) unless welsh_enabled?
+
       @welsh_translation_input = WelshTranslationInput.new(**welsh_translation_input_params)
 
       if @welsh_translation_input.submit
@@ -27,5 +31,9 @@ def create
     def welsh_translation_input_params
       params.require(:forms_welsh_translation_input).permit(:mark_complete).merge(form: current_form)
     end
+
+    def welsh_enabled?
+      FeatureService.new(group: current_form.group).enabled?(:welsh)
+    end
   end
 end

spec/requests/forms/welsh_translation_controller_spec.rb

@@ -5,7 +5,9 @@
   let(:id) { form.id }
 
   let(:current_user) { standard_user }
-  let(:group) { create(:group, organisation: standard_user.organisation, welsh_enabled: false) }
+  let(:group) { create(:group, organisation: standard_user.organisation, welsh_enabled:) }
+
+  let(:welsh_enabled) { true }
 
   before do
     Membership.create!(group_id: group.id, user: standard_user, added_by: standard_user)
@@ -34,6 +36,14 @@
         expect(response).to have_http_status(:forbidden)
       end
     end
+
+    context "when the welsh feature is not enabled for the group" do
+      let(:welsh_enabled) { false }
+
+      it "redirects to the form" do
+        expect(response).to redirect_to(form_path(id))
+      end
+    end
   end
 
   describe "#create" do
@@ -119,5 +129,20 @@
         expect(response).to have_http_status(:forbidden)
       end
     end
+
+    context "when the welsh feature is not enabled for the group" do
+      let(:welsh_enabled) { false }
+
+      it "does not update the form" do
+        expect {
+          post(welsh_translation_create_path(id), params:)
+        }.not_to(change { form.reload.welsh_completed })
+      end
+
+      it "redirects to the form" do
+        post(welsh_translation_create_path(id), params:)
+        expect(response).to redirect_to(form_path(id))
+      end
+    end
   end
 end