Make task status service aware of current user

Author: DavidBiddle

app/controllers/forms_controller.rb

@@ -25,7 +25,7 @@ def current_archived_welsh_form
 
   def load_form
     @current_form = Form.find(params[:form_id])
-    @current_form.set_task_status_service(TaskStatusService.new(form: @current_form))
+    @current_form.set_task_status_service(TaskStatusService.new(form: @current_form, current_user:))
     @initial_form_state = @current_form.state
   end
 

app/services/form_task_list_service.rb

@@ -12,7 +12,7 @@ def call(**args)
   def initialize(form:, current_user:)
     @current_user = current_user
     @form = form
-    @form.set_task_status_service(TaskStatusService.new(form:))
+    @form.set_task_status_service(TaskStatusService.new(form:, current_user:))
     @task_statuses = form.all_task_statuses
     @task_counts = status_counts
   end

app/services/task_status_service.rb

@@ -1,6 +1,7 @@
 class TaskStatusService
-  def initialize(form:)
+  def initialize(form:, current_user:)
     @form = form
+    @current_user = current_user
   end
 
   def mandatory_tasks_completed?(ignore_missing_welsh: false)
@@ -144,7 +145,7 @@ def make_live_status_for_draft
 
   def welsh_translations_invalid
     @welsh_translations_invalid ||= begin
-      translation_input = Forms::WelshTranslationInput.new(form: @form, mark_complete: true).assign_form_values
+      translation_input = Forms::WelshTranslationInput.new(form: @form, mark_complete: true, current_user: @current_user).assign_form_values
       translation_input.invalid?
     end
   end

spec/input_objects/forms/make_live_input_spec.rb

@@ -6,7 +6,7 @@
   let(:user) { build :user }
 
   before do
-    form.set_task_status_service(TaskStatusService.new(form:))
+    form.set_task_status_service(TaskStatusService.new(form:, current_user: user))
   end
 
   describe "validations" do

spec/models/form_spec.rb

@@ -3,6 +3,8 @@
 RSpec.describe Form, type: :model do
   subject(:form) { described_class.new }
 
+  let(:current_user) { build :user }
+
   describe "factory" do
     it "has a valid factory" do
       form = create :form
@@ -37,7 +39,7 @@
 
     describe "task status traits" do
       before do
-        form.set_task_status_service(TaskStatusService.new(form:))
+        form.set_task_status_service(TaskStatusService.new(form:, current_user:))
       end
 
       describe "ready for live trait" do
@@ -516,7 +518,7 @@
 
   describe "FormStateMachine" do
     before do
-      form.set_task_status_service(TaskStatusService.new(form: form))
+      form.set_task_status_service(TaskStatusService.new(form:, current_user:))
     end
 
     describe "#make_live!" do
@@ -878,7 +880,7 @@
 
   describe "#ready_for_live" do
     before do
-      form.set_task_status_service(TaskStatusService.new(form:))
+      form.set_task_status_service(TaskStatusService.new(form:, current_user:))
     end
 
     context "when a form is complete and ready to be made live" do
@@ -920,7 +922,7 @@
 
   describe "#all_incomplete_tasks" do
     before do
-      form.set_task_status_service(TaskStatusService.new(form: form))
+      form.set_task_status_service(TaskStatusService.new(form:, current_user:))
     end
 
     context "when a form is complete and ready to be made live" do
@@ -1022,10 +1024,10 @@
 
   describe "#all_task_statuses" do
     let(:group) { create :group }
-    let(:completed_form) { build :form, :live, :with_group, group: }
+    let(:form) { build :form, :live, :with_group, group: }
 
     before do
-      completed_form.set_task_status_service(TaskStatusService.new(form: completed_form))
+      form.set_task_status_service(TaskStatusService.new(form:, current_user:))
     end
 
     it "returns a hash with each of the task statuses" do
@@ -1045,7 +1047,7 @@
         share_preview_status: :completed,
         make_live_status: :completed,
       }
-      expect(completed_form.all_task_statuses).to eq expected_hash
+      expect(form.all_task_statuses).to eq expected_hash
     end
   end
 

spec/requests/forms/make_live_controller_spec.rb

@@ -12,7 +12,7 @@
   let(:group) { create(:group, organisation:, status: :active) }
 
   before do
-    form.set_task_status_service(TaskStatusService.new(form:))
+    form.set_task_status_service(TaskStatusService.new(form:, current_user: user))
   end
 
   describe "#new" do

spec/services/make_form_live_service_spec.rb

@@ -7,7 +7,7 @@
   let(:current_user) { build :user }
 
   before do
-    current_form.set_task_status_service(TaskStatusService.new(form: current_form))
+    current_form.set_task_status_service(TaskStatusService.new(form: current_form, current_user:))
   end
 
   describe "#make_live" do

spec/services/org_admin_alerts_service_spec.rb

@@ -10,7 +10,7 @@
 
   before do
     GroupForm.create!(form: form, group:)
-    form.set_task_status_service(TaskStatusService.new(form:))
+    form.set_task_status_service(TaskStatusService.new(form:, current_user:))
   end
 
   describe "#form_made_live" do

spec/services/step_summary_card_service_spec.rb

@@ -13,8 +13,10 @@
 
   let(:pages) { form.pages }
 
+  let(:current_user) { build :user }
+
   before do
-    form.set_task_status_service(TaskStatusService.new(form:))
+    form.set_task_status_service(TaskStatusService.new(form:, current_user:))
   end
 
   describe "#all_options_for_answer_type" do

spec/services/step_summary_table_service_spec.rb

@@ -15,8 +15,10 @@
   let(:form_document_step) { FormDocument::Step.new(page.as_form_document_step(nil)) }
   let(:welsh_form_document) { FormDocument::Content.from_form_document(form.live_welsh_form_document) }
 
+  let(:current_user) { build :user }
+
   before do
-    form.set_task_status_service(TaskStatusService.new(form:))
+    form.set_task_status_service(TaskStatusService.new(form:, current_user:))
   end
 
   def create_form(attributes = {})