Add multiple branches error summary to page list

Add multiple branch error summary to page list.

Author: thomasiles

app/components/page_list_component/error_summary/view.rb

@@ -48,15 +48,28 @@ def error_object(error_name:, condition:, page:)
       end
 
       def errors_for_summary
-        @form.conditions.map { |condition|
-          condition.validation_errors.map do |error|
-            error_object(
-              error_name: error.name,
-              page: condition.check_page,
-              condition: condition,
+        if FeatureService.new(group: @form.group).enabled?(:multiple_branches)
+          @form.pages.map { |page|
+            error_message = self.class.multiple_branch_error_message(page)
+
+            next if error_message.blank?
+
+            OpenStruct.new(
+              message: error_message,
+              link: "##{self.class.page_error_id(page)}",
             )
-          end
-        }.flatten
+          }.compact
+        else
+          @form.conditions.map { |condition|
+            condition.validation_errors.map do |error|
+              error_object(
+                error_name: error.name,
+                page: condition.check_page,
+                condition: condition,
+              )
+            end
+          }.flatten
+        end
       end
     end
   end

app/views/pages/index.html.erb

@@ -4,9 +4,7 @@
 
 <div class="govuk-grid-row">
   <div class="govuk-grid-column-two-thirds">
-    <% unless FeatureService.new(group: current_form.group).enabled?(:multiple_branches) %>
-      <%= render PageListComponent::ErrorSummary::View.new(current_form) %>
-    <% end %>
+    <%= render PageListComponent::ErrorSummary::View.new(current_form) %>
 
     <h1 class="govuk-heading-l govuk-!-margin-bottom-2">
       <span class="govuk-caption-l"><%= current_form.name %></span><span class="govuk-visually-hidden"> - </span>

spec/components/page_list_component/error_summary/error_summary_component_preview.rb

@@ -2,7 +2,7 @@ class PageListComponent::ErrorSummary::ErrorSummaryComponentPreview < ViewCompon
   include FactoryBot::Syntax::Methods
 
   def default
-    form = build(:form, id: 1, pages: [])
+    form = build(:form, :with_group, id: 1, pages: [])
 
     render(PageListComponent::ErrorSummary::View.new(form))
   end
@@ -13,7 +13,7 @@ def error_component_without_errors
     pages = [(build :page, id: 1, position: 1, question_text: "Enter your name", routing_conditions:),
              (build :page, id: 2, position: 2, question_text: "What is your pet's phone number?", routing_conditions: []),
              (build :page, id: 3, position: 3, question_text: "How many pets do you own?", routing_conditions: [])]
-    form = build(:form, id: 0, pages:)
+    form = build(:form, :with_group, id: 0, pages:)
 
     # We need to build the records rather than create them so that we don't save them to the database when we view the
     # preview. However, this means that the associations aren't available so we need to manually set the associations
@@ -35,7 +35,7 @@ def error_component_with_errors
     pages = [(build :page, id: 1, position: 1, question_text: "Enter your name", routing_conditions: routing_conditions_page_1),
              (build :page, id: 2, position: 2, question_text: "What is your pet's phone number?", routing_conditions: routing_conditions_page_2),
              (build :page, id: 3, position: 3, question_text: "How many pets do you own?", routing_conditions: [])]
-    form = build(:form, id: 0, pages:)
+    form = build(:form, :with_group, id: 0, pages:)
 
     # We need to build the records rather than create them so that we don't save them to the database when we view the
     # preview. However, this means that the associations aren't available so we need to manually set the associations

spec/components/page_list_component/error_summary/view_spec.rb

@@ -5,7 +5,7 @@
   let(:pages) { form.reload.pages }
   let(:error_summary_component) { described_class.new(form) }
 
-  describe "rendering component" do
+  describe "rendering component", feature_multiple_branches: false do
     context "when there are no pages" do
       it "is blank" do
         render_inline(error_summary_component)
@@ -138,11 +138,34 @@
     end
 
     describe "#errors_for_summary" do
-      it "returns all of the routing errors for a form with their respective positions and links" do
-        expect(error_summary_component.errors_for_summary).to eq [
-          OpenStruct.new(message: I18n.t("errors.page_conditions.answer_value_doesnt_exist", question_number: pages.first.position, route_number: 1), link: "#condition_#{condition_with_answer_value_missing.id}"),
-          OpenStruct.new(message: I18n.t("errors.page_conditions.goto_page_doesnt_exist", question_number: pages.second.position, route_number: 1), link: "#condition_#{condition_with_goto_page_missing.id}"),
-        ]
+      context "when the multiple_branches feature is disabled", feature_multiple_branches: false do
+        it "returns all of the routing errors for a form with their respective positions and links" do
+          expect(error_summary_component.errors_for_summary).to eq [
+            OpenStruct.new(message: I18n.t("errors.page_conditions.answer_value_doesnt_exist", question_number: pages.first.position, route_number: 1), link: "#condition_#{condition_with_answer_value_missing.id}"),
+            OpenStruct.new(message: I18n.t("errors.page_conditions.goto_page_doesnt_exist", question_number: pages.second.position, route_number: 1), link: "#condition_#{condition_with_goto_page_missing.id}"),
+          ]
+        end
+      end
+
+      context "when the multiple_branches feature is enabled", :feature_multiple_branches do
+        it "returns an empty array" do
+          expect(error_summary_component.errors_for_summary).to eq []
+        end
+
+        context "when there is a backward route" do
+          let(:expected_page_field_id) { "page-#{form.pages.second.id}" }
+
+          before do
+            create :condition, routing_page_id: form.pages.second.id, check_page_id: form.pages.second.id, goto_page_id: form.pages.first.id
+            form.pages.second.reload
+          end
+
+          it "returns only the backward route error" do
+            expect(error_summary_component.errors_for_summary).to eq [
+              OpenStruct.new(message: "A route from question 2 is going to a previous question - edit this route", link: "##{expected_page_field_id}"),
+            ]
+          end
+        end
       end
     end
   end