Skip to content

Commit c017153

Browse files
committed
Remove feedback link from phase banner
For the trial of the new feedback component, we want to remove the feedback link from the existing phase banner to make the test as fair as possible.
1 parent 041c81e commit c017153

3 files changed

Lines changed: 3 additions & 10 deletions

File tree

app/views/layouts/application.html.erb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,7 @@
1212

1313
<% content_for :before_content do %>
1414
<%= govuk_phase_banner(tag: { text: "Beta" }) do %>
15-
<%= t("phase_banner.before_link") %>
16-
<%= govuk_link_to t("phase_banner.link"), t("phase_banner.feedback_survey_url") %>
17-
<%= t("phase_banner.after_link") %>
15+
<%= t("phase_banner") %>
1816
<% end %>
1917
<%= yield :back_link %>
2018
<%= render ActAsUserBannerComponent::View.new(acting_as_user, actual_user) %>

config/locales/en.yml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1693,11 +1693,7 @@ en:
16931693
<p class="govuk-inset-text">It could be up to several months before you’re ready to take payments. This depends on the PSP arrangements for your organisation.</p>
16941694
heading: Setting up GOV.UK Pay
16951695
submit_button: Save and continue
1696-
phase_banner:
1697-
after_link: will help us improve it.
1698-
before_link: This is a new service, your
1699-
feedback_survey_url: https://surveys.publishing.service.gov.uk/s/T7OW3C/
1700-
link: feedback
1696+
phase_banner: This is a new service.
17011697
privacy_policy_input:
17021698
body_html: |
17031699
<p>

spec/requests/web_controller_spec.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -229,8 +229,7 @@
229229
end
230230

231231
it "contains the feedback link component" do
232-
expect(response.body).to include("Help us improve this service")
233-
expect(response.body).to include("<a href=\"#{I18n.t('phase_banner.feedback_survey_url')}\" class=\"govuk-link\">giving us your feedback</a>")
232+
expect(response.body).to include("This is a new service.")
234233
end
235234

236235
it "contains links related to the service" do

0 commit comments

Comments
 (0)