Add logic to make individual languages live separately

Co-authored-by: Stephen Daly <stephen.daly@digital.cabinet-office.gov.uk>

Author: DavidBiddle

app/controllers/forms/make_language_live_controller.rb

@@ -2,7 +2,10 @@ module Forms
   class MakeLanguageLiveController < FormsController
     def new
       authorize current_form, :can_make_language_live?
+      return redirect_to form_path(form_id: current_form.id) unless current_form.can_make_language_live?(language: params[:language])
+
       @make_language_live_input = MakeLiveInput.new(form: current_form)
+
       render_new
     end
 
@@ -13,9 +16,10 @@ def create
 
       return render_new(status: :unprocessable_content) unless @make_language_live_input.valid?
       return redirect_to form_path(@make_language_live_input.form.id) unless @make_language_live_input.confirmed?
+      return redirect_to form_path(form_id: current_form.id) unless current_form.can_make_language_live?(language: params[:language])
 
       @make_form_live_service = MakeFormLiveService.call(current_form:, current_user:, language: params[:language])
-      # TODO: actually make the language live
+      @make_form_live_service.make_language_live
 
       redirect_to make_language_live_show_confirmation_path
     end

app/models/form.rb

@@ -224,6 +224,12 @@ def set_task_status_service(service)
     self.task_status_service = service
   end
 
+  def can_make_language_live?(language:)
+    return can_make_english_version_live? if language == "en"
+
+    can_make_welsh_version_live? if language == "cy"
+  end
+
 private
 
   def set_external_id
@@ -267,6 +273,30 @@ def after_make_live
     FormDocumentSyncService.new(self).synchronize_live_form
   end
 
+  def before_make_english_live
+    before_make_live
+  end
+
+  def after_make_english_live
+    FormDocumentSyncService.new(self).synchronize_only_live_english_form
+  end
+
+  def before_make_welsh_live
+    before_make_live
+  end
+
+  def after_make_welsh_live
+    FormDocumentSyncService.new(self).synchronize_only_live_welsh_form
+  end
+
+  def can_make_english_version_live?
+    draft? && ready_for_live && live_form_document.blank? && live_welsh_form_document.blank?
+  end
+
+  def can_make_welsh_version_live?
+    has_live_version && ready_for_live && live_form_document.present? && live_welsh_form_document.blank?
+  end
+
   def after_archive
     FormDocumentSyncService.new(self).synchronize_archived_form
   end

app/services/form_document_sync_service.rb

@@ -52,6 +52,44 @@ def synchronize_archived_welsh_form
     end
   end
 
+  def synchronize_only_live_english_form
+    FormDocument.transaction do
+      # If we've already made the Welsh version live, changes to the Welsh version must be made live at the same time by calling a different method
+      raise ActiveRecord::RecordNotFound, "Cannot make changes to only the live English form if there is already a live Welsh version." if FormDocument.where(form:, tag: LIVE_TAG, language: "cy").exists?
+
+      content = form_content("en", live_at: form.updated_at)
+      update_or_create_form_document(LIVE_TAG, content, "en")
+
+      # Update the content of the live English version to to not include Welsh in available_languages
+      FormDocument.where(form:, tag: [LIVE_TAG], language: "en").find_each do |live_document|
+        live_document.content["available_languages"] = %w[en]
+        live_document.save!
+      end
+
+      # A new live version replaces any previous archived version
+      delete_form_documents_by_tag(ARCHIVED_TAG)
+    end
+  end
+
+  def synchronize_only_live_welsh_form
+    FormDocument.transaction do
+      # Ensure we only make Welsh version live if there is already an existing live English version
+      raise ActiveRecord::RecordNotFound, "Cannot make Welsh version live unless there is already a live English version." unless FormDocument.where(form:, tag: LIVE_TAG, language: "en").exists?
+
+      content = form_content("cy", live_at: form.updated_at)
+      update_or_create_form_document(LIVE_TAG, content, "cy")
+
+      # Update the content of the live English version to show that it now supports Welsh
+      FormDocument.where(form:, tag: [LIVE_TAG], language: "en").find_each do |live_document|
+        live_document.content["available_languages"] = %w[en cy]
+        live_document.save!
+      end
+
+      # A new live version replaces any previous archived version
+      delete_form_documents_by_tag(ARCHIVED_TAG)
+    end
+  end
+
   def update_draft_form_document
     synchronize_documents_for_tag(DRAFT_TAG)
   end
@@ -79,6 +117,7 @@ def update_or_create_form_document(tag, content, language)
       language:,
     )
     form_document.content = content
+
     form_document.save!
   end
 

app/services/make_form_live_service.rb

@@ -27,6 +27,14 @@ def make_live
     end
   end
 
+  def make_language_live
+    if @language == "en"
+      make_english_live
+    else
+      make_welsh_live
+    end
+  end
+
   def page_title
     return I18n.t("page_titles.your_form_is_live") if @current_form_was_archived
     return I18n.t("page_titles.your_changes_are_live") if @current_form_was_live
@@ -48,6 +56,14 @@ def confirmation_page_body
 
 private
 
+  def make_english_live
+    @current_form.make_english_version_live!
+  end
+
+  def make_welsh_live
+    @current_form.make_welsh_version_live!
+  end
+
   def live_form_submission_email_has_changed
     @current_form_was_live && @current_live_form.submission_email != @current_form.submission_email
   end

app/state_machines/form_state_machine.rb

@@ -33,6 +33,20 @@ module FormStateMachine
         transitions from: %i[draft live_with_draft archived archived_with_draft], to: :live, guard: :ready_for_live
       end
 
+      event :make_english_version_live do
+        before :before_make_english_live
+        after :after_make_english_live
+
+        transitions from: %i[draft live live_with_draft], to: :live, guard: :can_make_english_version_live?
+      end
+
+      event :make_welsh_version_live do
+        before :before_make_welsh_live
+        after :after_make_welsh_live
+
+        transitions from: %i[live live_with_draft], to: :live, guard: :can_make_welsh_version_live?
+      end
+
       event :create_draft_from_live_form do
         after :after_create_draft
 

spec/models/form_spec.rb

@@ -1464,4 +1464,182 @@
       end
     end
   end
+
+  describe "#can_make_language_live" do
+    let(:form) { create :form }
+
+    before do
+      form.set_task_status_service(TaskStatusService.new(form:, current_user:))
+    end
+
+    context "when the language being checked is English" do
+      let(:language) { "en" }
+
+      context "when the form is draft" do
+        context "when the form does not have all mandatory tasks completed" do
+          let(:form) { create :form }
+
+          it "returns false" do
+            expect(form.can_make_language_live?(language:)).to be false
+          end
+        end
+
+        context "when the form has all mandatory tasks completed" do
+          let(:form) { create :form, :ready_for_live }
+
+          context "when the form does not have a live English form document" do
+            context "when the form does not have a live Welsh form document" do
+              it "returns true" do
+                expect(form.can_make_language_live?(language:)).to be true
+              end
+            end
+
+            context "when the form already has a live Welsh form document" do
+              before do
+                create :form_document, :live, form:, language: "cy", content: form.as_form_document
+              end
+
+              it "returns false" do
+                expect(form.can_make_language_live?(language:)).to be false
+              end
+            end
+          end
+
+          context "when the form already has a live English form document" do
+            before do
+              create :form_document, :live, form:, language: "en", content: form.as_form_document
+            end
+
+            it "returns false" do
+              expect(form.can_make_language_live?(language:)).to be false
+            end
+          end
+        end
+      end
+
+      context "when the form is live" do
+        context "when the form has all mandatory tasks completed" do
+          let(:form) { create :form, state: "live" }
+
+          context "when the form does not have a live English form document" do
+            context "when the form does not have a live Welsh form document" do
+              it "returns false" do
+                expect(form.can_make_language_live?(language:)).to be false
+              end
+            end
+
+            context "when the form already has a live Welsh form document" do
+              before do
+                create :form_document, :live, form:, language: "cy", content: form.as_form_document
+              end
+
+              it "returns false" do
+                expect(form.can_make_language_live?(language:)).to be false
+              end
+            end
+          end
+
+          context "when the form already has a live English form document" do
+            before do
+              create :form_document, :live, form:, language: "en", content: form.as_form_document
+            end
+
+            it "returns false" do
+              expect(form.can_make_language_live?(language:)).to be false
+            end
+          end
+        end
+      end
+    end
+
+    context "when the language being checked is Welsh" do
+      let(:language) { "cy" }
+
+      context "when the form is draft" do
+        context "when the form does not have all mandatory tasks completed" do
+          let(:form) { create :form }
+
+          it "returns false" do
+            expect(form.can_make_language_live?(language:)).to be false
+          end
+        end
+
+        context "when the form has all mandatory tasks completed" do
+          let(:form) { create :form, :ready_for_live }
+
+          context "when the form does not have a live English form document" do
+            context "when the form does not have a live Welsh form document" do
+              it "returns false" do
+                expect(form.can_make_language_live?(language:)).to be false
+              end
+            end
+
+            context "when the form already has a live Welsh form document" do
+              before do
+                create :form_document, :live, form:, language: "cy", content: form.as_form_document
+              end
+
+              it "returns false" do
+                expect(form.can_make_language_live?(language:)).to be false
+              end
+            end
+          end
+
+          context "when the form already has a live English form document" do
+            before do
+              create :form_document, :live, form:, language: "en", content: form.as_form_document
+            end
+
+            it "returns false" do
+              expect(form.can_make_language_live?(language:)).to be false
+            end
+          end
+        end
+      end
+
+      context "when the form is live" do
+        let(:form) { create :form, :ready_for_live, state: "live" }
+
+        context "when the form does not have a live English form document" do
+          context "when the form does not have a live Welsh form document" do
+            it "returns false" do
+              expect(form.can_make_language_live?(language:)).to be false
+            end
+          end
+
+          context "when the form already has a live Welsh form document" do
+            before do
+              create :form_document, :live, form:, language: "cy", content: form.as_form_document
+            end
+
+            it "returns false" do
+              expect(form.can_make_language_live?(language:)).to be false
+            end
+          end
+        end
+
+        context "when the form already has a live English form document" do
+          before do
+            create :form_document, :live, form:, language: "en", content: form.as_form_document
+          end
+
+          context "when the form does not have a live Welsh form document" do
+            it "returns true" do
+              expect(form.can_make_language_live?(language:)).to be true
+            end
+          end
+
+          context "when the form already has a live Welsh form document" do
+            before do
+              create :form_document, :live, form:, language: "cy", content: form.as_form_document
+            end
+
+            it "returns false" do
+              expect(form.can_make_language_live?(language:)).to be false
+            end
+          end
+        end
+      end
+    end
+  end
 end