Merge pull request #2079 from alphagov/ldeb-fix-model-specs

Fix specs for forms models

Author: lfdebrux

spec/factories/models/condition_resource.rb

@@ -0,0 +1,47 @@
+FactoryBot.define do
+  factory :condition_resource, class: "Api::V1::ConditionResource" do
+    routing_page_id { nil }
+    check_page_id { nil }
+    answer_value { nil }
+    goto_page_id { nil }
+    skip_to_end { false }
+    validation_errors { [] }
+    has_routing_errors { false }
+    exit_page_heading { nil }
+    exit_page_markdown { nil }
+
+    trait :with_answer_value_missing do
+      answer_value { nil }
+      has_routing_errors { true }
+      validation_errors { [OpenStruct.new(name: "answer_value_doesnt_exist")] }
+    end
+
+    trait :with_goto_page_missing do
+      goto_page_id { nil }
+      has_routing_errors { true }
+      validation_errors { [OpenStruct.new(name: "goto_page_doesnt_exist")] }
+    end
+
+    trait :with_goto_page_before_check_page do
+      has_routing_errors { true }
+      validation_errors { [OpenStruct.new(name: "cannot_have_goto_page_before_routing_page")] }
+    end
+
+    trait :with_goto_page_immediately_after_check_page do
+      has_routing_errors { true }
+      validation_errors { [OpenStruct.new(name: "cannot_route_to_next_page")] }
+    end
+
+    trait :with_answer_value_and_goto_page_missing do
+      goto_page_id { nil }
+      has_routing_errors { true }
+      validation_errors { [OpenStruct.new(name: "answer_value_doesnt_exist"), OpenStruct.new(name: "goto_page_doesnt_exist")] }
+    end
+
+    trait :with_exit_page do
+      goto_page_id { nil }
+      exit_page_heading { "Exit page heading" }
+      exit_page_markdown { "Exit page markdown" }
+    end
+  end
+end

spec/factories/models/conditions.rb

@@ -1,47 +1,3 @@
 FactoryBot.define do
-  factory :condition, class: "Api::V1::ConditionResource" do
-    routing_page_id { nil }
-    check_page_id { nil }
-    answer_value { nil }
-    goto_page_id { nil }
-    skip_to_end { false }
-    validation_errors { [] }
-    has_routing_errors { false }
-    exit_page_heading { nil }
-    exit_page_markdown { nil }
-
-    trait :with_answer_value_missing do
-      answer_value { nil }
-      has_routing_errors { true }
-      validation_errors { [OpenStruct.new(name: "answer_value_doesnt_exist")] }
-    end
-
-    trait :with_goto_page_missing do
-      goto_page_id { nil }
-      has_routing_errors { true }
-      validation_errors { [OpenStruct.new(name: "goto_page_doesnt_exist")] }
-    end
-
-    trait :with_goto_page_before_check_page do
-      has_routing_errors { true }
-      validation_errors { [OpenStruct.new(name: "cannot_have_goto_page_before_routing_page")] }
-    end
-
-    trait :with_goto_page_immediately_after_check_page do
-      has_routing_errors { true }
-      validation_errors { [OpenStruct.new(name: "cannot_route_to_next_page")] }
-    end
-
-    trait :with_answer_value_and_goto_page_missing do
-      goto_page_id { nil }
-      has_routing_errors { true }
-      validation_errors { [OpenStruct.new(name: "answer_value_doesnt_exist"), OpenStruct.new(name: "goto_page_doesnt_exist")] }
-    end
-
-    trait :with_exit_page do
-      goto_page_id { nil }
-      exit_page_heading { "Exit page heading" }
-      exit_page_markdown { "Exit page markdown" }
-    end
-  end
+  factory :condition, parent: :condition_resource
 end

spec/factories/models/form_record.rb

@@ -29,15 +29,15 @@
       end
 
       pages do
-        Array.new(pages_count) { association(:page, factory: :page_record) }
+        Array.new(pages_count) { association(:page_record) }
       end
 
       question_section_completed { true }
     end
 
     trait :with_text_page do
       pages do
-        Array.new(1) { association(:page, factory: :page_record, answer_type: "text", answer_settings: { input_type: %w[single_line long_text].sample }) }
+        Array.new(1) { association(:page_record, answer_type: "text", answer_settings: { input_type: %w[single_line long_text].sample }) }
       end
 
       question_section_completed { true }

spec/factories/models/form_resource.rb

@@ -0,0 +1,152 @@
+FactoryBot.define do
+  factory :form_resource, class: "Api::V1::FormResource" do
+    sequence(:name) { |n| "Form #{n}" }
+    sequence(:form_slug) { |n| "form-#{n}" }
+    has_draft_version { true }
+    submission_email { Faker::Internet.email(domain: "example.gov.uk") }
+    submission_type { "email" }
+    privacy_policy_url { Faker::Internet.url(host: "gov.uk") }
+    language { "en" }
+    live_at { nil }
+    support_email { nil }
+    support_phone { nil }
+    support_url { nil }
+    support_url_text { nil }
+    what_happens_next_markdown { nil }
+    declaration_text { nil }
+    question_section_completed { false }
+    declaration_section_completed { false }
+    share_preview_completed { false }
+    has_routing_errors { false }
+    creator_id { nil }
+    ready_for_live { false }
+    incomplete_tasks { %i[missing_pages missing_privacy_policy_url missing_contact_details missing_what_happens_next share_preview_not_completed] }
+    state { :draft }
+
+    transient do
+      statuses { { declaration_status: "not_started", make_live_status: "cannot_start", name_status: "completed", pages_status: "not_started", privacy_policy_status: "not_started", support_contact_details_status: "not_started", what_happens_next_status: "not_started" } }
+    end
+    task_statuses { OpenStruct.new(attributes: statuses) }
+
+    trait :new_form do
+      submission_email { "" }
+      privacy_policy_url { "" }
+      state { :draft }
+    end
+
+    trait :with_id do
+      sequence(:id) { |n| n }
+    end
+
+    trait :ready_for_live do
+      with_pages
+      support_email { Faker::Internet.email(domain: "example.gov.uk") }
+      what_happens_next_markdown { "We usually respond to applications within 10 working days." }
+      question_section_completed { true }
+      declaration_section_completed { true }
+      share_preview_completed { true }
+      ready_for_live { true }
+      incomplete_tasks { [] }
+      transient do
+        statuses { { declaration_status: "completed", make_live_status: "not_started", name_status: "completed", pages_status: "completed", privacy_policy_status: "completed", support_contact_details_status: "completed", what_happens_next_status: "completed" } }
+      end
+      task_statuses { OpenStruct.new(attributes: statuses) }
+    end
+
+    trait :live do
+      ready_for_live
+      live_at { Time.zone.now }
+      has_draft_version { false }
+      state { :live }
+    end
+
+    trait :live_with_draft do
+      live
+      state { :live_with_draft }
+      has_draft_version { true }
+    end
+
+    trait :archived do
+      live
+      state { :archived }
+    end
+
+    trait :archived_with_draft do
+      live
+      state { :archived_with_draft }
+    end
+
+    trait :with_active_resource do
+      task_statuses { statuses }
+    end
+
+    trait :with_pages do
+      transient do
+        pages_count { 5 }
+      end
+
+      pages do
+        Array.new(pages_count) { association(:page_resource) }
+      end
+
+      question_section_completed { true }
+    end
+
+    trait :with_support do
+      support_email { Faker::Internet.email(domain: "example.gov.uk") }
+      support_phone { Faker::Lorem.paragraph(sentence_count: 2, supplemental: true, random_sentences_to_add: 4) }
+      support_url { Faker::Internet.url(host: "gov.uk") }
+      support_url_text { Faker::Lorem.sentence(word_count: 1, random_words_to_add: 4) }
+    end
+
+    trait :ready_for_routing do
+      transient do
+        pages_count { 5 }
+      end
+
+      pages do
+        Array.new(pages_count) { association(:page_resource, :with_selection_settings) }
+      end
+
+      after(:build) do |form|
+        if form.pages.present?
+          # assign position and next_page to each page
+          form.pages.each.with_index(1).each_cons(2) do |page_with_index, next_page_with_index|
+            page, page_index = page_with_index
+            next_page, _next_page_index = next_page_with_index
+
+            page.position = page_index
+            page.next_page = next_page&.id
+          end
+        end
+      end
+    end
+
+    trait :ready_for_api_routing do
+      transient do
+        pages_count { 5 }
+      end
+
+      pages do
+        Array.new(pages_count) { association(:page_resource, :with_api_selection_settings) }
+      end
+
+      after(:build) do |form|
+        if form.pages.present?
+          # assign position and next_page to each page
+          form.pages.each.with_index(1).each_cons(2) do |page_with_index, next_page_with_index|
+            page, page_index = page_with_index
+            next_page, _next_page_index = next_page_with_index
+
+            page.position = page_index
+            page.next_page = next_page&.id
+          end
+        end
+      end
+    end
+
+    trait :missing_pages do
+      incomplete_tasks { %i[missing_pages] }
+    end
+  end
+end