Merge pull request #768 from alphagov/update-set-submission-type-tasks

Synchronise form documents for update submission type tasks

Author: stephencdaly

lib/tasks/forms.rake

@@ -52,6 +52,9 @@ namespace :forms do
 
       made_live_form.update!(json_form_blob: form_blob.to_json)
     end
+
+    Api::V2::FormDocumentSyncService.new.synchronize_form(form)
+
     Rails.logger.info("set submission_type to s3 and s3_bucket_name to #{args[:s3_bucket_name]} for form: #{args[:form_id]}")
   end
 
@@ -118,5 +121,7 @@ def set_submission_type(submission_type, form_id)
     made_live_form.update!(json_form_blob: form_blob.to_json)
   end
 
+  Api::V2::FormDocumentSyncService.new.synchronize_form(form)
+
   Rails.logger.info("set submission_type to #{submission_type} for form: #{form_id}")
 end

spec/lib/tasks/forms.rake_spec.rb

@@ -58,6 +58,13 @@
         expect(JSON.parse(form.made_live_forms.last.json_form_blob)["submission_type"]).to eq("email_with_csv")
       end
 
+      it "synchronises the FormDocument" do
+        task.invoke(form.id)
+        form_documents = Api::V2::Form.find(form.id).form_documents
+        expect(form_documents.size).to eq(1)
+        expect(form_documents.first["content"]["submission_type"]).to eq("email_with_csv")
+      end
+
       it "does not update a different form" do
         expect { task.invoke(form.id) }
           .not_to(change { other_form.reload.submission_type })
@@ -74,6 +81,13 @@
         expect { task.invoke(form.id) }
           .to change { form.reload.submission_type }.to("email_with_csv")
       end
+
+      it "synchronises the FormDocument" do
+        task.invoke(form.id)
+        form_documents = Api::V2::Form.find(form.id).form_documents
+        expect(form_documents.size).to eq(1)
+        expect(form_documents.first["content"]["submission_type"]).to eq("email_with_csv")
+      end
     end
 
     context "when the form is archived" do
@@ -91,6 +105,14 @@
         task.invoke(form.id)
         expect(JSON.parse(form.made_live_forms.last.json_form_blob)["submission_type"]).to eq("email")
       end
+
+      it "synchronises the archived and draft FormDocuments" do
+        task.invoke(form.id)
+        form_documents = Api::V2::Form.find(form.id).form_documents
+        expect(form_documents.size).to eq(2)
+        expect(form_documents.first["content"]["submission_type"]).to eq("email_with_csv")
+        expect(form_documents.second["content"]["submission_type"]).to eq("email_with_csv")
+      end
     end
   end
 
@@ -141,6 +163,14 @@
         expect(JSON.parse(form.made_live_forms.last.json_form_blob)["s3_bucket_name"]).to eq(s3_bucket_name)
       end
 
+      it "synchronises the FormDocument" do
+        task.invoke(form.id, s3_bucket_name, s3_bucket_aws_account_id, s3_bucket_region)
+        form_documents = Api::V2::Form.find(form.id).form_documents
+        expect(form_documents.size).to eq(1)
+        expect(form_documents.first["content"]["submission_type"]).to eq("s3")
+        expect(form_documents.first["content"]["s3_bucket_name"]).to eq(s3_bucket_name)
+      end
+
       it "does not update a different form" do
         expect { task.invoke(form.id, s3_bucket_name, s3_bucket_aws_account_id, s3_bucket_region) }
           .not_to(change { other_form.reload.submission_type })
@@ -167,6 +197,14 @@
         expect { task.invoke(form.id, s3_bucket_name, s3_bucket_aws_account_id, s3_bucket_region) }
           .to change { form.reload.s3_bucket_aws_account_id }.to(s3_bucket_aws_account_id)
       end
+
+      it "synchronises the FormDocument" do
+        task.invoke(form.id, s3_bucket_name, s3_bucket_aws_account_id, s3_bucket_region)
+        form_documents = Api::V2::Form.find(form.id).form_documents
+        expect(form_documents.size).to eq(1)
+        expect(form_documents.first["content"]["submission_type"]).to eq("s3")
+        expect(form_documents.first["content"]["s3_bucket_name"]).to eq(s3_bucket_name)
+      end
     end
 
     context "when the form is archived" do
@@ -184,6 +222,16 @@
         task.invoke(form.id, s3_bucket_name, s3_bucket_aws_account_id, s3_bucket_region)
         expect(JSON.parse(form.made_live_forms.last.json_form_blob)["submission_type"]).to eq("email")
       end
+
+      it "synchronises the archived and draft FormDocuments" do
+        task.invoke(form.id, s3_bucket_name, s3_bucket_aws_account_id, s3_bucket_region)
+        form_documents = Api::V2::Form.find(form.id).form_documents
+        expect(form_documents.size).to eq(2)
+        expect(form_documents.first["content"]["submission_type"]).to eq("s3")
+        expect(form_documents.first["content"]["s3_bucket_name"]).to eq(s3_bucket_name)
+        expect(form_documents.second["content"]["submission_type"]).to eq("s3")
+        expect(form_documents.second["content"]["s3_bucket_name"]).to eq(s3_bucket_name)
+      end
     end
 
     context "without arguments" do
@@ -264,6 +312,13 @@
         expect(JSON.parse(form.made_live_forms.last.json_form_blob)["submission_type"]).to eq("email")
       end
 
+      it "synchronises the FormDocument" do
+        task.invoke(form.id)
+        form_documents = Api::V2::Form.find(form.id).form_documents
+        expect(form_documents.size).to eq(1)
+        expect(form_documents.first["content"]["submission_type"]).to eq("email")
+      end
+
       it "does not update a different form" do
         expect { task.invoke(form.id) }
           .not_to(change { other_form.reload.submission_type })
@@ -297,6 +352,14 @@
         task.invoke(form.id)
         expect(JSON.parse(form.made_live_forms.last.json_form_blob)["submission_type"]).to eq("s3")
       end
+
+      it "synchronises the archived and draft FormDocuments" do
+        task.invoke(form.id)
+        form_documents = Api::V2::Form.find(form.id).form_documents
+        expect(form_documents.size).to eq(2)
+        expect(form_documents.first["content"]["submission_type"]).to eq("email")
+        expect(form_documents.second["content"]["submission_type"]).to eq("email")
+      end
     end
   end