Temporarily rename dynamodb_table

We'll want to delete the dynamodb tables after we have enabled native state
locking. For now we are renaming them with a default value so that they do not
depend on values we have removed.

This PR makes sure that the policies are still allowed to modify the dynamodb
tables

Author: cadmiumcat

infra/deployments/deploy/engineer-access/roles.tf

@@ -10,7 +10,7 @@ module "engineer_access" {
   env_name                            = "deploy"
   environment_type                    = "deploy"
   codestar_connection_arn             = var.codestar_connection_arn
-  dynamodb_state_file_locks_table_arn = "arn:aws:dynamodb::${var.deploy_account_id}:table/govuk-forms-deploy-tfstate-locking"
+  dynamodb_state_file_locks_table_arn = "arn:aws:dynamodb::${var.deploy_account_id}:table/*"
   allow_ecs_task_usage                = false
   allow_rds_data_api_access           = false
 

infra/deployments/forms/account/deployer-access.tf

@@ -15,7 +15,7 @@ module "deployer_access" {
   deploy_account_id                   = var.deploy_account_id
   hosted_zone_id                      = aws_route53_zone.public.id
   codestar_connection_arn             = var.codestar_connection_arn
-  dynamodb_state_file_locks_table_arn = "arn:aws:dynamodb:eu-west-2:${var.aws_account_id}:table/${local.dynamodb_table_name}"
+  dynamodb_state_file_locks_table_arn = "arn:aws:dynamodb:eu-west-2:${var.aws_account_id}:table/*"
 
   depends_on = [aws_route53_zone.public]
 }

infra/deployments/forms/account/engineer-access.tf

@@ -13,7 +13,7 @@ module "engineer_access" {
   pentester_cidrs                     = var.pentester_cidr_ranges
   vpn                                 = var.require_vpn_to_access
   codestar_connection_arn             = var.codestar_connection_arn
-  dynamodb_state_file_locks_table_arn = "arn:aws:dynamodb:eu-west-2:${var.aws_account_id}:table/${local.dynamodb_table_name}"
+  dynamodb_state_file_locks_table_arn = "arn:aws:dynamodb:eu-west-2:${var.aws_account_id}:table/*"
   allow_rds_data_api_access           = true
   allow_ecs_task_usage                = true
 }

infra/deployments/forms/account/inputs.tf

@@ -28,6 +28,7 @@ variable "dynamodb_table" {
   description = "Name of the DynamoDB table used for state file locking. This is named to match the key in the S3 type backend"
   type        = string
   nullable    = false
+  default     = "tmp"
 }
 
 variable "environment_name" {

infra/deployments/forms/inputs.tf

@@ -58,6 +58,7 @@ variable "dynamodb_table" {
   description = "Name of the DynamoDB table used for state file locking. This is named to match the key in the S3 type backend"
   type        = string
   nullable    = false
+  default     = "tmp"
 }
 
 variable "dlq_arn" {