Test e2e-image against staging environment

Previously the Docker image to run end to end tests and smoke tests was
being tested against both the dev and production environments before
pushing (dev environment for the end to end tests, production
environment for the smoke tests).

This seems a bit more convoluted than necessary, and was a cause for
surprise and failures with the e2e-image pipeline recently when I was
making changes to how forms-e2e-tests gets its configuration (see
PR #1940 for more details). In future we'd like to have the e2e-image
pipeline test the end to end tests and smoke tests against the same
environment, to simplify the configuration logic of forms-e2e-tests and
make it more consistent with the configuration of our apps.

Why weren't we using the same environment for testing both end to end
tests and smoke tests already? The reasons aren't documented, but we can
make some guesses... there is some sense to it; the smoke tests run
using the latest e2e-image, so we probably want to make sure the smoke
tests pass against production before promoting the image, and dev might
be different enough that a pass there doesn't mean a pass on production.
On the other hand, we might not want to run an untested version of the
end to end tests against production in case they mess up and do
something really bad... but then again the end to end tests are not
gated by the e2e-image pipeline in the same way as the smoke tests are
so this may not be as much of a concern.

Running the smoke tests and end to end tests against the staging
environment seems like a reasonable compromise; staging should be as
close to production as possible, but if the end to end tests do
something bad and break things then it's also less of an issue. This
also matches more closely what our app and terraform release pipelines
do; testing against staging before releasing to production.

Author: lfdebrux

infra/deployments/deploy/e2e-tests-image-builder/main.tf

@@ -4,7 +4,7 @@
 #
 # However, the end-to-end tests container building CodeBuild job has an extra
 # step within the buildspec which runs the tests in the container against the
-# dev environment, for which it needs credentials from the
+# staging environment, for which it needs credentials from the
 # 'automated-test-parameters' module.
 #
 # https://github.com/alphagov/forms-e2e-tests/blob/main/bin/dockerfile_test.sh

infra/modules/e2e-image-pipeline/codepipeline.tf

@@ -76,42 +76,42 @@ module "docker_build" {
   extra_env_vars = [
     {
       name  = "SETTINGS__FORMS_ENV"
-      value = "dev"
+      value = "staging"
       type  = "PLAINTEXT"
     },
     {
       name  = "SETTINGS__FORM_IDS__SMOKE_TEST"
-      value = "2570"
+      value = "12148"
       type  = "PLAINTEXT"
     },
     {
       name  = "SETTINGS__FORM_IDS__S3"
-      value = "12457"
+      value = "13657"
       type  = "PLAINTEXT"
     },
     {
       name  = "SETTINGS__FORMS_ADMIN__URL"
-      value = "https://admin.dev.forms.service.gov.uk"
+      value = "https://admin.staging.forms.service.gov.uk"
       type  = "PLAINTEXT"
     },
     {
       name  = "SETTINGS__FORMS_ADMIN__AUTH__USERNAME"
-      value = "/dev/automated-tests/e2e/auth0/email-username"
+      value = "/staging/automated-tests/e2e/auth0/email-username"
       type  = "PARAMETER_STORE"
     },
     {
       name  = "SETTINGS__FORMS_ADMIN__AUTH__PASSWORD"
-      value = "/dev/automated-tests/e2e/auth0/auth0-user-password"
+      value = "/staging/automated-tests/e2e/auth0/auth0-user-password"
       type  = "PARAMETER_STORE"
     },
     {
       name  = "SETTINGS__FORMS_PRODUCT_PAGE__URL"
-      value = "https://dev.forms.service.gov.uk"
+      value = "https://staging.forms.service.gov.uk"
       type  = "PLAINTEXT"
     },
     {
       name  = "SETTINGS__FORMS_RUNNER__URL"
-      value = "https://submit.dev.forms.service.gov.uk"
+      value = "https://submit.staging.forms.service.gov.uk"
       type  = "PLAINTEXT"
     },
     {
@@ -121,17 +121,17 @@ module "docker_build" {
     },
     {
       name  = "SETTINGS__AWS__S3_SUBMISSION_IAM_ROLE_ARN"
-      value = "arn:aws:iam::498160065950:role/govuk-s3-end-to-end-test-dev"
+      value = "arn:aws:iam::972536609845:role/govuk-s3-end-to-end-test-staging"
       type  = "PLAINTEXT"
     },
     {
       name  = "SETTINGS__GOVUK_NOTIFY__API_KEY"
-      value = "/dev/automated-tests/e2e/notify/api-key"
+      value = "/staging/automated-tests/e2e/notify/api-key"
       type  = "PARAMETER_STORE"
     },
     {
       name  = "SETTINGS__SUBMISSION_STATUS_API__SECRET"
-      value = "/dev/automated-tests/e2e/runner/submission_status_api_shared_secret"
+      value = "/staging/automated-tests/e2e/runner/submission_status_api_shared_secret"
       type  = "PARAMETER_STORE"
     },
   ]