Add length validations for name questions

Author: stephencdaly

app/models/question/name.rb

@@ -7,7 +7,7 @@ class Name < Question::QuestionBase
     attribute :last_name
 
     validate :full_name_valid?, if: :is_full_name?
-    validate :first_and_last_name_valid?, unless: :is_full_name?
+    validate :first_middle_and_last_name_valid?, unless: :is_full_name?
 
     def validate_title
       needs_title? && !is_optional?
@@ -34,14 +34,18 @@ def full_name_valid?
       return if skipping_question?
 
       errors.add(:full_name, :blank) if full_name.blank?
+      errors.add(:full_name, :too_long) if full_name.present? && full_name.length > 499
       errors
     end
 
-    def first_and_last_name_valid?
+    def first_middle_and_last_name_valid?
       return if skipping_question?
 
       errors.add(:first_name, :blank) if first_name.blank?
+      errors.add(:first_name, :too_long) if first_name.present? && first_name.length > 499
       errors.add(:last_name, :blank) if last_name.blank?
+      errors.add(:last_name, :too_long) if last_name.present? && last_name.length > 499
+      errors.add(:middle_names, :too_long) if include_middle_name? && middle_names.present? && middle_names.length > 499
       errors
     end
 

config/locales/cy.yml

@@ -139,10 +139,15 @@ cy:
           attributes:
             first_name:
               blank: Rhowch enw cyntaf
+              too_long: The first name must be shorter than 500 characters
             full_name:
               blank: Rhowch enw
+              too_long: The name must be shorter than 500 characters
             last_name:
               blank: Rhowch enw olaf
+              too_long: The last name must be shorter than 500 characters
+            middle_names:
+              too_long: The middle name must be shorter than 500 characters
         question/national_insurance_number:
           attributes:
             national_insurance_number:

config/locales/en.yml

@@ -139,10 +139,15 @@ en:
           attributes:
             first_name:
               blank: Enter a first name
+              too_long: The first name must be shorter than 500 characters
             full_name:
               blank: Enter a name
+              too_long: The name must be shorter than 500 characters
             last_name:
               blank: Enter a last name
+              too_long: The last name must be shorter than 500 characters
+            middle_names:
+              too_long: The middle name must be shorter than 500 characters
         question/national_insurance_number:
           attributes:
             national_insurance_number:

spec/models/question/name_spec.rb

@@ -58,6 +58,20 @@
         expect(question.show_answer_in_csv).to eq({ "#{question_text} - Full name" => name })
       end
     end
+
+    describe "length validation" do
+      it "is valid with length under 500 characters" do
+        question.full_name = "a" * 499
+        expect(question).to be_valid
+        expect(question.errors[:full_name]).to be_empty
+      end
+
+      it "is invalid with length over 499 characters" do
+        question.full_name = "a" * 500
+        expect(question).not_to be_valid
+        expect(question.errors[:full_name]).to include(I18n.t("activemodel.errors.models.question/name.attributes.full_name.too_long"))
+      end
+    end
   end
 
   context "when the name question is in first and last name format" do
@@ -147,6 +161,30 @@
         })
       end
     end
+
+    describe "length validation" do
+      before do
+        question.first_name = "a" * 499
+        question.last_name = "a" * 499
+      end
+
+      it "is valid when all fields have the maximum allowed length" do
+        expect(question).to be_valid
+        expect(question.errors).to be_empty
+      end
+
+      it "is invalid when the first name is over 499 characters" do
+        question.first_name = "a" * 500
+        expect(question).not_to be_valid
+        expect(question.errors[:first_name]).to include(I18n.t("activemodel.errors.models.question/name.attributes.first_name.too_long"))
+      end
+
+      it "is invalid when the last name is over 499 characters" do
+        question.last_name = "a" * 500
+        expect(question).not_to be_valid
+        expect(question.errors[:last_name]).to include(I18n.t("activemodel.errors.models.question/name.attributes.last_name.too_long"))
+      end
+    end
   end
 
   context "when the name question is in first, middle and last name format" do
@@ -215,6 +253,37 @@
         })
       end
     end
+
+    describe "length validation" do
+      before do
+        question.first_name = "a" * 499
+        question.middle_names = "a" * 499
+        question.last_name = "a" * 499
+      end
+
+      it "is valid when all fields have the maximum allowed length" do
+        expect(question).to be_valid
+        expect(question.errors).to be_empty
+      end
+
+      it "is invalid when the first name is over 499 characters" do
+        question.first_name = "a" * 500
+        expect(question).not_to be_valid
+        expect(question.errors[:first_name]).to include(I18n.t("activemodel.errors.models.question/name.attributes.first_name.too_long"))
+      end
+
+      it "is invalid when the middle name is over 499 characters" do
+        question.middle_names = "a" * 500
+        expect(question).not_to be_valid
+        expect(question.errors[:middle_names]).to include(I18n.t("activemodel.errors.models.question/name.attributes.middle_names.too_long"))
+      end
+
+      it "is invalid when the last name is over 499 characters" do
+        question.last_name = "a" * 500
+        expect(question).not_to be_valid
+        expect(question.errors[:last_name]).to include(I18n.t("activemodel.errors.models.question/name.attributes.last_name.too_long"))
+      end
+    end
   end
 
   context "when title_needed is set to true" do