Merge pull request #520 from alphagov/bau-fix-public-pages

sanisc · web-flow · commit 11c1e7c9c3dc · 2022-02-25T11:32:54.000Z
Only add if session exists - fix for public facing pages
diff --git a/src/middleware/cross-domain-tracking-middleware.ts b/src/middleware/cross-domain-tracking-middleware.ts
@@ -6,7 +6,7 @@ export function crossDomainTrackingMiddleware(
   res: Response,
   next: NextFunction
 ): void {
-  if (req.query._ga) {
+  if (req.query._ga && req.session) {
     req.session.client.crossDomainGaTrackingId = xss(req.query._ga as string);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ export function crossDomainTrackingMiddleware(`
`6`	`6`	`res: Response,`
`7`	`7`	`next: NextFunction`
`8`	`8`	`): void {`
`9`		`- if (req.query._ga) {`
	`9`	`+ if (req.query._ga && req.session) {`
`10`	`10`	`req.session.client.crossDomainGaTrackingId = xss(req.query._ga as string);`
`11`	`11`	`}`
`12`	`12`