OLH-755: rebased after int phone number

Author: TaherKapasi

package.json

@@ -16,7 +16,7 @@
     "clean-modules": "rm -rf node_modules",
     "generate-static-hash": "mkdir -p dist/utils && tar cvf - src/assets | sha1sum  | head -c 40 | xargs -I X echo '{\"hash\":\"X\"}' > dist/utils/static-hash.json",
     "copy-assets": "copyfiles -u 1 src/**/*.njk dist/ src/locales/**/** dist/ src/config/*.txt dist/ && npm run copy-scripts",
-    "copy-scripts": "rm -r dist/public/scripts || true && mkdir -p dist/public/scripts && cp node_modules/govuk-frontend/dist/govuk/govuk-frontend.min.js node_modules/@govuk-one-login/frontend-analytics/lib/analytics.js dist/public/scripts && cp -r src/assets/javascript/* dist/public/scripts/",
+    "copy-scripts": "rm -r dist/public/scripts || true && mkdir -p dist/public/scripts && cp node_modules/govuk-frontend/dist/govuk/govuk-frontend.min.js node_modules/@govuk-one-login/frontend-analytics/lib/analytics.js dist/public/scripts",
     "doctor": "NODE_ENV=production clinic doctor --autocannon [ -c 10 -d 10 /healthcheck ] -- node -r dotenv/config dist/server.js && echo '\n\nRemember to clean up files in .clinic and node_trace.*.log\n'",
     "deep-clean": "npm cache clear --force && npm cache clean --force && npm run clean && npm ci && npm run build",
     "dev": "concurrently -k -p \"[{name}]\" -n \"Sass,TypeScript,Node\" -c \"yellow.bold,cyan.bold,green.bold\" \"npm run watch-sass\" \"npm run watch-ts\" \"npm run watch-node\"",

src/components/change-phone-number/tests/change-phone-number-integration.test.ts

@@ -330,16 +330,19 @@ describe("Integration:: change phone number", () => {
       .expect(function (res) {
         const $ = cheerio.load(res.text);
         expect($(testComponent("phoneNumber-error")).text()).toContain(
-          "You’re already using that phone number. Enter a different phone number"
+          "You’re already using that phone number. Enter a different UK mobile phone number"
         );
       })
       .expect(400);
     expect(res.statusCode).toBe(400);
   });
 
 
-  it("should return No UK phone number page", (done) => {
-    request(app).get(PATH_DATA.NO_UK_PHONE_NUMBER.url).expect(302, done);
+  it("should return No UK phone number page", async () => {
+    const res = await request(app)
+      .get(PATH_DATA.NO_UK_PHONE_NUMBER.url)
+      .expect(302);
+    expect(res.statusCode).toBe(302);
   });
 
   it("should return internal server error if send-otp-notification API call fails", async () => {

src/components/no-uk-mobile-phone/no-uk-mobile-phone-controller.ts

@@ -1,10 +1,10 @@
 import { Request, Response } from "express";
-import { PATH_DATA } from "../../app.constants";
+import { PATH_DATA } from "../../app.constants.js";
 import {
   mfaMethodTypes,
   mfaPriorityIdentifiers,
-} from "../../utils/mfaClient/types";
-import { MFA_COMMON_OPL_SETTINGS, setOplSettings } from "../../utils/opl";
+} from "../../utils/mfaClient/types.js";
+import { MFA_COMMON_OPL_SETTINGS, setOplSettings } from "../../utils/opl.js";
 import { MetricUnit } from "@aws-lambda-powertools/metrics";
 
 const NO_UK_PHONE_NUMBER_TEMPLATE = "no-uk-mobile-phone/index.njk";

src/components/no-uk-mobile-phone/no-uk-mobile-phone-routes.ts

@@ -1,10 +1,10 @@
 import * as express from "express";
-import { PATH_DATA } from "../../app.constants";
-import { requiresAuthMiddleware } from "../../middleware/requires-auth-middleware";
-import { noUkPhoneNumberGet } from "./no-uk-mobile-phone-controller";
-import { validateStateMiddleware } from "../../middleware/validate-state-middleware";
-import { SetState } from "../../utils/set-state";
-import { EventType, UserJourney } from "../../utils/state-machine";
+import { PATH_DATA } from "../../app.constants.js";
+import { requiresAuthMiddleware } from "../../middleware/requires-auth-middleware.js";
+import { noUkPhoneNumberGet } from "./no-uk-mobile-phone-controller.js";
+import { validateStateMiddleware } from "../../middleware/validate-state-middleware.js";
+import { SetState } from "../../utils/set-state.js";
+import { EventType, UserJourney } from "../../utils/state-machine.js";
 
 const router = express.Router();
 

src/utils/set-state.ts

@@ -1,5 +1,5 @@
 import { Request, Response, NextFunction, RequestHandler } from "express";
-import { UserJourney, EventType, getNextState } from "./state-machine";
+import { UserJourney, EventType, getNextState } from "./state-machine.js";
 
 export function SetState(
   currentStateTypes: UserJourney[],