From b5029824493627f9144fa291242b2ba2eeeb4463 Mon Sep 17 00:00:00 2001 From: Dominik Tworek Date: Fri, 25 Apr 2025 15:47:15 +0100 Subject: [PATCH 1/2] Updated PR template. --- .github/pull_request_template.md | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index c9c6d4af44..910600e62e 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -20,16 +20,14 @@ ## Checklists -### Environment variables or secrets + +- [ ] No secrets were added - -- [ ] No environment variables or secrets were added or changed + +- [ ] [README](./blob/main/README.md) and documentation updated where necessary - -- [ ] Documented in the [README](./blob/main/README.md) -- [ ] Added to deployment repository -- [ ] Added to local startup repository + +- [ ] No risk of credentials being exposed through logs -### Other considerations - -- [ ] Update [README](./blob/main/README.md) with any new instructions or tasks + +- [ ] API/unit tests have been written/updated From dae000bfd932409f4f2f2d63cf93428a0388e2ee Mon Sep 17 00:00:00 2001 From: Dominik Tworek Date: Fri, 25 Apr 2025 17:13:49 +0100 Subject: [PATCH 2/2] Updated PR template to be more descriptive --- .github/pull_request_template.md | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 910600e62e..2ab8bebc4b 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -20,14 +20,14 @@ ## Checklists - -- [ ] No secrets were added - - -- [ ] [README](./blob/main/README.md) and documentation updated where necessary + +- [ ] All READMEs and documentation updated where necessary -- [ ] No risk of credentials being exposed through logs +- [ ] No risk of PII, credentials or anything else sensitive being exposed through logs + + +- [ ] API/unit/contract tests have been written/updated -- [ ] API/unit tests have been written/updated +- [ ] Production changes appropriately staged out