Skip to content

Commit 23a127f

Browse files
PYIC-8790: add comment for why we include progressSpinnerButtonTimeout in mapping despite not being used in int or prod
1 parent 2b073e0 commit 23a127f

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

deploy/template.yaml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,9 @@ Conditions:
5555
- !Equals [ !Ref AWS::AccountId, "175872367215"]
5656
IsNotDevelopment: !Not [ !Condition IsDevelopment ]
5757
IsProduction: !Equals [ !Ref Environment, production ]
58+
IsIntOrProd: !Or
59+
- !Equals [ !Ref Environment, production ]
60+
- !Equals [ !Ref Environment, integration ]
5861
IsStagingIntProd: !Or
5962
- !Equals [ !Ref Environment, staging ]
6063
- !Equals [ !Ref Environment, integration ]
@@ -236,7 +239,7 @@ Mappings:
236239
spinnerRequestLongWaitInterval: 60000
237240
mamSpinnerRequestTimeout: 600000
238241
dadSpinnerRequestTimeout: 1800000
239-
progressSpinnerButtonTimeout: 5000
242+
progressSpinnerButtonTimeout: 10000 # This value isn't used in int or prod but CF requires these keys to be present in the mapping
240243
enableProgressSpinnerButton: false
241244
frontendAutoScalingMinCount: 4
242245
publishedKeysAccountId: "298945768017"
@@ -269,7 +272,7 @@ Mappings:
269272
spinnerRequestLongWaitInterval: 60000
270273
mamSpinnerRequestTimeout: 600000
271274
dadSpinnerRequestTimeout: 1800000
272-
progressSpinnerButtonTimeout: 5000
275+
progressSpinnerButtonTimeout: 10000 # This value isn't used in int or prod but CF requires these keys to be present in the mapping
273276
enableProgressSpinnerButton: false
274277
frontendAutoScalingMinCount: 6
275278
publishedKeysAccountId: "101836073728"
@@ -926,7 +929,7 @@ Resources:
926929
- dadSpinnerRequestTimeout
927930
- Name: PROGRESS_SPINNER_BUTTON_TIMEOUT
928931
Value: !If
929-
- IsProduction
932+
- IsIntOrProd
930933
- !Ref AWS::NoValue
931934
- !FindInMap
932935
- EnvironmentConfiguration

0 commit comments

Comments
 (0)