PYIC-8592: Add tests for pollVcReceiptStatus middleware.

Author: undermad

src/app/ipv/tests/checkVcReceiptStatus.test.ts

@@ -64,7 +64,7 @@ describe("checkVcReceiptStatus middleware", () => {
     expect(next).to.have.not.been.calledOnce;
   });
 
-  it("should throw error if status is ERROR", async () => {
+  it("should throw error if status is SERVER_ERROR", async () => {
     // Arrange
     const req = createRequest();
     const res = createResponse();

src/app/vc-receipt-status/middleware.test.ts

@@ -66,24 +66,34 @@ describe("vc receipt status middleware tests", () => {
     expect((req.session as any).journey).to.equal("journey/next");
   });
 
+  it("pollVcReceiptStatus should return CLIENT_ERROR status if appVcReceived returns 400", async () => {
+    const error = { response: { status: 400 } };
+    appVcReceivedStub.rejects(error);
+
+    await middleware.pollVcReceiptStatus(req as Request, res as Response, next);
+
+    expect(res.status).to.have.been.calledWith(400);
+    expect(res.json).to.have.been.calledWith({ status: "CLIENT_ERROR" });
+  });
+
   it("pollVcReceiptStatus should return an error when appVcReceived does not return journey response", async () => {
     appVcReceivedStub.resolves({ data: {} });
     isJourneyResponse.returns(false);
 
     await middleware.pollVcReceiptStatus(req as Request, res as Response, next);
 
     expect(res.status).to.have.been.calledWith(500);
-    expect(res.json).to.have.been.calledWith({ status: "ERROR" });
+    expect(res.json).to.have.been.calledWith({ status: "SERVER_ERROR" });
   });
 
-  it("pollVcReceiptStatus should return ERROR status if appVcReceived throws non 404 error", async () => {
+  it("pollVcReceiptStatus should return SERVER_ERROR status if appVcReceived throws non 400-499 error", async () => {
     const error = new Error("Test error");
     appVcReceivedStub.rejects(error);
 
     await middleware.pollVcReceiptStatus(req as Request, res as Response, next);
 
     expect(res.status).to.have.been.calledWith(500);
-    expect(res.json).to.have.been.calledWith({ status: "ERROR" });
+    expect(res.json).to.have.been.calledWith({ status: "SERVER_ERROR" });
   });
 
   it("pollVcReceiptStatus should return COMPLETED status when query param snapshotTest is true", async () => {