Merge pull request #629 from govuk-one-login/OJ-3197

OJ-3197 - Create NINo check handler

Author: barnabycollins

.github/workflows/check-pr.yml

@@ -81,10 +81,21 @@ jobs:
       stack-name: ${{ needs.deploy.outputs.stack-name }}
       aws-region: ${{ needs.deploy.outputs.aws-region }}
 
-  eventbridge-nino-check-tests:
+  eventbridge-nino-check-tests-sfn:
     name: Run tests
-    needs: [deploy, eventbridge-abandon-tests ]
-    uses: ./.github/workflows/run-evn-nino-tests.yml
+    needs: [deploy, eventbridge-abandon-tests]
+    uses: ./.github/workflows/run-evn-nino-tests-sfn.yml
+    permissions:
+      id-token: write
+      contents: read
+    with:
+      stack-name: ${{ needs.deploy.outputs.stack-name }}
+      aws-region: ${{ needs.deploy.outputs.aws-region }}
+
+  eventbridge-nino-check-tests-lambda:
+    name: Run tests
+    needs: [deploy, eventbridge-nino-check-tests-sfn]
+    uses: ./.github/workflows/run-evn-nino-tests-lambda.yml
     permissions:
       id-token: write
       contents: read
@@ -94,7 +105,7 @@ jobs:
 
   eventbridge-issue-credential-check-tests:
     name: Run tests
-    needs: [deploy, eventbridge-nino-check-tests ]
+    needs: [deploy, eventbridge-nino-check-tests-lambda]
     uses: ./.github/workflows/run-evn-cred-tests.yml
     permissions:
       id-token: write

.github/workflows/run-evn-nino-tests-lambda.yml

@@ -0,0 +1,38 @@
+name: Lambda AWS tests
+
+on:
+  workflow_call:
+    inputs:
+      stack-name: { required: true, type: string }
+      aws-region: { required: true, type: string }
+
+permissions:
+  id-token: write
+  contents: read
+
+concurrency:
+  group: evn-nino-tests-lambda-${{ github.workflow }}-${{ github.head_ref || github.ref_name }}
+  cancel-in-progress: true
+
+jobs:
+  run-tests:
+    # "Run tests / EVN - NINO" is configured as a required test job on the repo, so the name must remain the same
+    name: EVN - NINO
+    timeout-minutes: 15
+    runs-on: ubuntu-latest
+    environment: development
+    steps:
+      - name: Assume AWS Role
+        uses: aws-actions/configure-aws-credentials@v4
+        with:
+          role-to-assume: ${{ vars.DEPLOYMENT_ROLE_ARN }}
+          aws-region: ${{ inputs.aws-region }}
+
+      - name: Run tests
+        uses: govuk-one-login/github-actions/node/run-script@e6b6ed890b35904e1be79f7f35ffec983fa4d9db
+        env:
+          STACK_NAME: ${{ inputs.stack-name }}
+          AWS_REGION: ${{ inputs.aws-region }}
+        with:
+          working-directory: integration-tests
+          script: npm run test:evn:nino:lambda -- --config jest.config.ci.ts

.github/workflows/run-evn-nino-tests.yml …hub/workflows/run-evn-nino-tests-sfn.yml.github/workflows/run-evn-nino-tests.yml renamed to .github/workflows/run-evn-nino-tests-sfn.yml .github/workflows/run-evn-nino-tests.yml renamed to .github/workflows/run-evn-nino-tests-sfn.yml

@@ -11,27 +11,16 @@ permissions:
   contents: read
 
 concurrency:
-  group: evn-nino-tests-${{ github.workflow }}-${{ github.head_ref || github.ref_name }}
+  group: evn-nino-tests-sfn-${{ github.workflow }}-${{ github.head_ref || github.ref_name }}
   cancel-in-progress: true
 
 jobs:
   run-tests:
-    name: EVN - NINO
+    name: EVN - NINO SFN
     timeout-minutes: 15
     runs-on: ubuntu-latest
     environment: development
     steps:
-      - name: Pull repository
-        uses: actions/checkout@v4
-
-      - name: Install Node
-        uses: actions/setup-node@v4
-        with:
-          cache: npm
-
-      - name: Install dependencies
-        run: npm ci --include-workspace-root
-
       - name: Assume AWS Role
         uses: aws-actions/configure-aws-credentials@v4
         with:
@@ -45,4 +34,4 @@ jobs:
           AWS_REGION: ${{ inputs.aws-region }}
         with:
           working-directory: integration-tests
-          script: npm run test:evn:nino -- --config jest.config.ci.ts
+          script: npm run test:evn:nino:sfn -- --config jest.config.ci.ts

infrastructure/private-api.yaml

@@ -166,6 +166,36 @@ paths:
                 #set($context.responseOverride.status = 200)
                 #end
                 $output.body
+  /check-test:
+    post:
+      summary: "IP address of the client."
+      parameters:
+        - $ref: "#/components/parameters/SessionHeader"
+        - $ref: "#/components/parameters/AuditHeader"
+      requestBody:
+        content:
+          application/json:
+            schema:
+              $ref: "#/components/schemas/Nino"
+        required: true
+      x-amazon-apigateway-request-validator: "Validate both"
+      responses:
+        "200":
+          description: OK
+        "400":
+          description: Bad Request
+        "500":
+          description: Internal Server Error
+      x-amazon-apigateway-integration:
+        httpMethod: "POST"
+        uri:
+          Fn::Sub: arn:aws:apigateway:${AWS::Region}:lambda:path/2015-03-31/functions/${NinoCheckFunction.Arn}:live/invocations
+        responses:
+          default:
+            statusCode: "200"
+        passthroughBehavior: "when_no_match"
+        contentHandling: "CONVERT_TO_TEXT"
+        type: "aws_proxy"
   /abandon:
     post:
       summary: "IP address of the client."