Follow common JavaScript style (#4395)

This is probably my OCD but, JavaScript style is almost
universally, constructors are Capitalized and everything
else is not.

Personally I wish we'd turn on the "new-cap" rule for eslint
but unfortunately there are some slightly more difficult
usages in the shader tests.

So, instead, thought I'd just try to refactor most code using
C++ style to use JavaScript style so there are less examples
to copy from.

Author: greggman

src/webgpu/api/operation/command_buffer/copyTextureToTexture.spec.ts

@@ -37,7 +37,7 @@ import { findFailedPixels } from '../../../util/texture/texture_ok.js';
 const dataGenerator = new DataArrayGenerator();
 
 class F extends AllFeaturesMaxLimitsGPUTest {
-  GetInitialDataPerMipLevel(
+  getInitialDataPerMipLevel(
     dimension: GPUTextureDimension,
     textureSize: Required<GPUExtent3DDict>,
     format: ColorTextureFormat,
@@ -52,7 +52,7 @@ class F extends AllFeaturesMaxLimitsGPUTest {
     return dataGenerator.generateView(byteSize);
   }
 
-  GetInitialStencilDataPerMipLevel(
+  getInitialStencilDataPerMipLevel(
     textureSize: Required<GPUExtent3DDict>,
     format: DepthStencilFormat,
     mipLevel: number
@@ -67,7 +67,7 @@ class F extends AllFeaturesMaxLimitsGPUTest {
     return dataGenerator.generateView(byteSize);
   }
 
-  DoCopyTextureToTextureTest(
+  doCopyTextureToTextureTest(
     dimension: GPUTextureDimension,
     srcTextureSize: Required<GPUExtent3DDict>,
     dstTextureSize: Required<GPUExtent3DDict>,
@@ -113,7 +113,7 @@ class F extends AllFeaturesMaxLimitsGPUTest {
     const dstTexture = this.createTextureTracked(dstTextureDesc);
 
     // Fill the whole subresource of srcTexture at srcCopyLevel with initialSrcData.
-    const initialSrcData = this.GetInitialDataPerMipLevel(
+    const initialSrcData = this.getInitialDataPerMipLevel(
       dimension,
       srcTextureSize,
       srcFormat,
@@ -397,7 +397,7 @@ class F extends AllFeaturesMaxLimitsGPUTest {
     });
   }
 
-  InitializeStencilAspect(
+  initializeStencilAspect(
     sourceTexture: GPUTexture,
     initialStencilData: Uint8Array,
     srcCopyLevel: number,
@@ -417,7 +417,7 @@ class F extends AllFeaturesMaxLimitsGPUTest {
     );
   }
 
-  VerifyStencilAspect(
+  verifyStencilAspect(
     destinationTexture: GPUTexture,
     initialStencilData: Uint8Array,
     dstCopyLevel: number,
@@ -468,7 +468,7 @@ class F extends AllFeaturesMaxLimitsGPUTest {
     this.expectGPUBufferValuesEqual(outputBuffer, expectedStencilData);
   }
 
-  GetRenderPipelineForT2TCopyWithDepthTests(
+  getRenderPipelineForT2TCopyWithDepthTests(
     bindGroupLayout: GPUBindGroupLayout,
     hasColorAttachment: boolean,
     depthStencil: GPUDepthStencilState
@@ -515,7 +515,7 @@ class F extends AllFeaturesMaxLimitsGPUTest {
     return this.device.createRenderPipeline(renderPipelineDescriptor);
   }
 
-  GetBindGroupLayoutForT2TCopyWithDepthTests(): GPUBindGroupLayout {
+  getBindGroupLayoutForT2TCopyWithDepthTests(): GPUBindGroupLayout {
     return this.device.createBindGroupLayout({
       entries: [
         {
@@ -531,7 +531,7 @@ class F extends AllFeaturesMaxLimitsGPUTest {
     });
   }
 
-  GetBindGroupForT2TCopyWithDepthTests(
+  getBindGroupForT2TCopyWithDepthTests(
     bindGroupLayout: GPUBindGroupLayout,
     totalCopyArrayLayers: number
   ): GPUBindGroup {
@@ -562,7 +562,7 @@ class F extends AllFeaturesMaxLimitsGPUTest {
   }
 
   /** Initialize the depth aspect of sourceTexture with draw calls */
-  InitializeDepthAspect(
+  initializeDepthAspect(
     sourceTexture: GPUTexture,
     depthFormat: GPUTextureFormat,
     srcCopyLevel: number,
@@ -571,13 +571,13 @@ class F extends AllFeaturesMaxLimitsGPUTest {
   ): void {
     // Prepare a renderPipeline with depthCompareFunction == 'always' and depthWriteEnabled == true
     // for the initializations of the depth attachment.
-    const bindGroupLayout = this.GetBindGroupLayoutForT2TCopyWithDepthTests();
-    const renderPipeline = this.GetRenderPipelineForT2TCopyWithDepthTests(bindGroupLayout, false, {
+    const bindGroupLayout = this.getBindGroupLayoutForT2TCopyWithDepthTests();
+    const renderPipeline = this.getRenderPipelineForT2TCopyWithDepthTests(bindGroupLayout, false, {
       format: depthFormat,
       depthWriteEnabled: true,
       depthCompare: 'always',
     });
-    const bindGroup = this.GetBindGroupForT2TCopyWithDepthTests(bindGroupLayout, copySize[2]);
+    const bindGroup = this.getBindGroupForT2TCopyWithDepthTests(bindGroupLayout, copySize[2]);
 
     const hasStencil = isStencilTextureFormat(sourceTexture.format);
     const encoder = this.device.createCommandEncoder();
@@ -606,7 +606,7 @@ class F extends AllFeaturesMaxLimitsGPUTest {
     this.queue.submit([encoder.finish()]);
   }
 
-  VerifyDepthAspect(
+  verifyDepthAspect(
     destinationTexture: GPUTexture,
     depthFormat: GPUTextureFormat,
     dstCopyLevel: number,
@@ -615,13 +615,13 @@ class F extends AllFeaturesMaxLimitsGPUTest {
   ): void {
     // Prepare a renderPipeline with depthCompareFunction == 'equal' and depthWriteEnabled == false
     // for the comparison of the depth attachment.
-    const bindGroupLayout = this.GetBindGroupLayoutForT2TCopyWithDepthTests();
-    const renderPipeline = this.GetRenderPipelineForT2TCopyWithDepthTests(bindGroupLayout, true, {
+    const bindGroupLayout = this.getBindGroupLayoutForT2TCopyWithDepthTests();
+    const renderPipeline = this.getRenderPipelineForT2TCopyWithDepthTests(bindGroupLayout, true, {
       format: depthFormat,
       depthWriteEnabled: false,
       depthCompare: 'equal',
     });
-    const bindGroup = this.GetBindGroupForT2TCopyWithDepthTests(bindGroupLayout, copySize[2]);
+    const bindGroup = this.getBindGroupForT2TCopyWithDepthTests(bindGroupLayout, copySize[2]);
 
     const outputColorTexture = this.createTextureTracked({
       format: 'rgba8unorm',
@@ -861,7 +861,7 @@ g.test('color_textures,non_compressed,non_array')
       dstCopyLevel,
     } = t.params;
 
-    t.DoCopyTextureToTextureTest(
+    t.doCopyTextureToTextureTest(
       dimension,
       srcTextureSize,
       dstTextureSize,
@@ -937,7 +937,7 @@ g.test('color_textures,compressed,non_array')
     const { blockWidth: dstBlockWidth, blockHeight: dstBlockHeight } =
       getBlockInfoForColorTextureFormat(dstFormat);
 
-    t.DoCopyTextureToTextureTest(
+    t.doCopyTextureToTextureTest(
       dimension,
       {
         width: textureSizeInBlocks.src.width * srcBlockWidth,
@@ -1016,7 +1016,7 @@ g.test('color_textures,non_compressed,array')
       dstCopyLevel,
     } = t.params;
 
-    t.DoCopyTextureToTextureTest(
+    t.doCopyTextureToTextureTest(
       dimension,
       textureSize.srcTextureSize,
       textureSize.dstTextureSize,
@@ -1079,7 +1079,7 @@ g.test('color_textures,compressed,array')
     const { blockWidth: dstBlockWidth, blockHeight: dstBlockHeight } =
       getBlockInfoForColorTextureFormat(dstFormat);
 
-    t.DoCopyTextureToTextureTest(
+    t.doCopyTextureToTextureTest(
       dimension,
       {
         width: textureSizeInBlocks.src.width * srcBlockWidth,
@@ -1189,7 +1189,7 @@ g.test('zero_sized')
     const srcFormat = 'rgba8unorm';
     const dstFormat = 'rgba8unorm';
 
-    t.DoCopyTextureToTextureTest(
+    t.doCopyTextureToTextureTest(
       dimension,
       textureSize,
       textureSize,
@@ -1277,8 +1277,8 @@ g.test('copy_depth_stencil')
 
     let initialStencilData: undefined | Uint8Array = undefined;
     if (isStencilTextureFormat(format)) {
-      initialStencilData = t.GetInitialStencilDataPerMipLevel(srcTextureSize, format, srcCopyLevel);
-      t.InitializeStencilAspect(
+      initialStencilData = t.getInitialStencilDataPerMipLevel(srcTextureSize, format, srcCopyLevel);
+      t.initializeStencilAspect(
         sourceTexture,
         initialStencilData,
         srcCopyLevel,
@@ -1287,7 +1287,7 @@ g.test('copy_depth_stencil')
       );
     }
     if (isDepthTextureFormat(format)) {
-      t.InitializeDepthAspect(sourceTexture, format, srcCopyLevel, srcCopyBaseArrayLayer, copySize);
+      t.initializeDepthAspect(sourceTexture, format, srcCopyLevel, srcCopyBaseArrayLayer, copySize);
     }
 
     const encoder = t.device.createCommandEncoder();
@@ -1308,7 +1308,7 @@ g.test('copy_depth_stencil')
 
     if (isStencilTextureFormat(format)) {
       assert(initialStencilData !== undefined);
-      t.VerifyStencilAspect(
+      t.verifyStencilAspect(
         destinationTexture,
         initialStencilData,
         dstCopyLevel,
@@ -1317,7 +1317,7 @@ g.test('copy_depth_stencil')
       );
     }
     if (isDepthTextureFormat(format)) {
-      t.VerifyDepthAspect(
+      t.verifyDepthAspect(
         destinationTexture,
         format,
         dstCopyLevel,

src/webgpu/api/operation/command_buffer/image_copy.spec.ts

@@ -737,7 +737,7 @@ class ImageCopyTest extends AllFeaturesMaxLimitsGPUTest {
     }
   }
 
-  DoUploadToStencilTest(
+  doUploadToStencilTest(
     format: DepthStencilFormat,
     textureSize: readonly [number, number, number],
     uploadMethod: 'WriteTexture' | 'CopyB2T',
@@ -832,7 +832,7 @@ class ImageCopyTest extends AllFeaturesMaxLimitsGPUTest {
     this.expectGPUBufferValuesEqual(outputBuffer, expectedData);
   }
 
-  DoCopyFromStencilTest(
+  doCopyFromStencilTest(
     format: DepthStencilFormat,
     textureSize: readonly [number, number, number],
     bytesPerRow: number,
@@ -1046,7 +1046,7 @@ class ImageCopyTest extends AllFeaturesMaxLimitsGPUTest {
     };
   }
 
-  DoCopyTextureToBufferWithDepthAspectTest(
+  doCopyTextureToBufferWithDepthAspectTest(
     format: DepthStencilFormat,
     copySize: readonly [number, number, number],
     bytesPerRowPadding: number,
@@ -1765,7 +1765,7 @@ g.test('undefined_params')
     });
   });
 
-function CopyMethodSupportedWithDepthStencilFormat(
+function copyMethodSupportedWithDepthStencilFormat(
   aspect: 'depth-only' | 'stencil-only',
   format: DepthStencilFormat,
   copyMethod: 'WriteTexture' | 'CopyB2T' | 'CopyT2B'
@@ -1800,7 +1800,7 @@ aspect and copyTextureToBuffer() with depth aspect.
       .combine('format', kDepthStencilFormats)
       .combine('copyMethod', ['WriteTexture', 'CopyB2T', 'CopyT2B'] as const)
       .combine('aspect', ['depth-only', 'stencil-only'] as const)
-      .filter(t => CopyMethodSupportedWithDepthStencilFormat(t.aspect, t.format, t.copyMethod))
+      .filter(t => copyMethodSupportedWithDepthStencilFormat(t.aspect, t.format, t.copyMethod))
       .beginSubcases()
       .combineWithParams(kRowsPerImageAndBytesPerRowParams.paddings)
       .combineWithParams(kRowsPerImageAndBytesPerRowParams.copySizes)
@@ -1838,7 +1838,7 @@ aspect and copyTextureToBuffer() with depth aspect.
     ] as const;
     if (copyMethod === 'CopyT2B') {
       if (aspect === 'depth-only') {
-        t.DoCopyTextureToBufferWithDepthAspectTest(
+        t.doCopyTextureToBufferWithDepthAspectTest(
           format,
           copySize,
           bytesPerRowPadding,
@@ -1848,7 +1848,7 @@ aspect and copyTextureToBuffer() with depth aspect.
           mipLevel
         );
       } else {
-        t.DoCopyFromStencilTest(format, textureSize, bytesPerRow, rowsPerImage, 0, mipLevel);
+        t.doCopyFromStencilTest(format, textureSize, bytesPerRow, rowsPerImage, 0, mipLevel);
       }
     } else {
       assert(
@@ -1861,7 +1861,7 @@ aspect and copyTextureToBuffer() with depth aspect.
         method: copyMethod,
       });
 
-      t.DoUploadToStencilTest(
+      t.doUploadToStencilTest(
         format,
         textureSize,
         copyMethod,
@@ -1890,7 +1890,7 @@ copyTextureToBuffer() with depth aspect.
       .combine('format', kDepthStencilFormats)
       .combine('copyMethod', ['WriteTexture', 'CopyB2T', 'CopyT2B'] as const)
       .combine('aspect', ['depth-only', 'stencil-only'] as const)
-      .filter(t => CopyMethodSupportedWithDepthStencilFormat(t.aspect, t.format, t.copyMethod))
+      .filter(t => copyMethodSupportedWithDepthStencilFormat(t.aspect, t.format, t.copyMethod))
       .beginSubcases()
       .combineWithParams(kOffsetsAndSizesParams.offsetsAndPaddings)
       .filter(t => t.offsetInBlocks % 4 === 0)
@@ -1910,9 +1910,9 @@ copyTextureToBuffer() with depth aspect.
     const textureSize = [copySize[0] << mipLevel, copySize[1] << mipLevel, copyDepth] as const;
     if (copyMethod === 'CopyT2B') {
       if (aspect === 'depth-only') {
-        t.DoCopyTextureToBufferWithDepthAspectTest(format, copySize, 0, 0, 0, 0, mipLevel);
+        t.doCopyTextureToBufferWithDepthAspectTest(format, copySize, 0, 0, 0, 0, mipLevel);
       } else {
-        t.DoCopyFromStencilTest(
+        t.doCopyFromStencilTest(
           format,
           textureSize,
           bytesPerRow,
@@ -1932,7 +1932,7 @@ copyTextureToBuffer() with depth aspect.
         method: copyMethod,
       });
       const initialDataSize = minDataSize + dataPaddingInBytes;
-      t.DoUploadToStencilTest(
+      t.doUploadToStencilTest(
         format,
         textureSize,
         copyMethod,

src/webgpu/api/operation/command_buffer/render/state_tracking.spec.ts

@@ -11,7 +11,7 @@ import * as ttu from '../../../../texture_test_utils.js';
 import { TexelView } from '../../../../util/texture/texel_view.js';
 
 class VertexAndIndexStateTrackingTest extends AllFeaturesMaxLimitsGPUTest {
-  GetRenderPipelineForTest(arrayStride: number): GPURenderPipeline {
+  getRenderPipelineForTest(arrayStride: number): GPURenderPipeline {
     return this.device.createRenderPipeline({
       layout: 'auto',
       vertex: {
@@ -128,7 +128,7 @@ g.test('set_index_buffer_without_changing_buffer')
 
     vertexBuffer.unmap();
 
-    const renderPipeline = t.GetRenderPipelineForTest(t.kVertexAttributeSize);
+    const renderPipeline = t.getRenderPipelineForTest(t.kVertexAttributeSize);
 
     const outputTextureSize = [kPositions.length - 1, 1, 1];
     const outputTexture = t.createTextureTracked({
@@ -222,7 +222,7 @@ g.test('set_vertex_buffer_without_changing_buffer')
 
     vertexBuffer.unmap();
 
-    const renderPipeline = t.GetRenderPipelineForTest(t.kVertexAttributeSize);
+    const renderPipeline = t.getRenderPipelineForTest(t.kVertexAttributeSize);
 
     const outputTextureSize = [kPositions.length, 1, 1];
     const outputTexture = t.createTextureTracked({
@@ -321,8 +321,8 @@ g.test('change_pipeline_before_and_after_vertex_buffer')
     vertexBuffer.unmap();
 
     // Create two render pipelines with different vertex attribute strides
-    const renderPipeline1 = t.GetRenderPipelineForTest(t.kVertexAttributeSize);
-    const renderPipeline2 = t.GetRenderPipelineForTest(t.kVertexAttributeSize * 2);
+    const renderPipeline1 = t.getRenderPipelineForTest(t.kVertexAttributeSize);
+    const renderPipeline2 = t.getRenderPipelineForTest(t.kVertexAttributeSize * 2);
 
     const kPointsCount = kPositions.length - 1;
     const outputTextureSize = [kPointsCount, 1, 1];
@@ -582,7 +582,7 @@ g.test('set_index_buffer_before_non_indexed_draw')
     // Initialize the index buffer with 2 uint16 indices (2, 3).
     const indexBuffer = t.makeBufferWithContents(new Uint16Array([2, 3]), GPUBufferUsage.INDEX);
 
-    const renderPipeline = t.GetRenderPipelineForTest(t.kVertexAttributeSize);
+    const renderPipeline = t.getRenderPipelineForTest(t.kVertexAttributeSize);
 
     const kPointsCount = 4;
     const outputTextureSize = [kPointsCount, 1, 1];