Fetch matching git tags instead of GitHub releases.

(to resolve GraalVM release tag)

Author: fniephaus

dist/main.js

@@ -56,8 +56,6 @@ export const ERROR_HINT =
 export type LatestReleaseResponseData =
   otypes.Endpoints['GET /repos/{owner}/{repo}/releases/latest']['response']['data']
 
-export type ListReleasesResponseData = otypes.Endpoints['GET /repos/{owner}/{repo}/releases']['response']['data']
-
 export type MatchingRefsResponseData =
   otypes.Endpoints['GET /repos/{owner}/{repo}/git/matching-refs/{ref}']['response']['data']
 

src/constants.ts

@@ -8,8 +8,7 @@ import {
   getContents,
   getLatestRelease,
   getMatchingTags,
-  getTaggedRelease,
-  getLastReleases
+  getTaggedRelease
 } from './utils.js'
 import {
   downloadGraalVMViaGDS,
@@ -60,29 +59,45 @@ export async function setUpGraalVMJDKCE(graalVMVersionOrDev: string, javaVersion
   const jdkVersion = javaVersionOrEmpty.length > 0 ? javaVersionOrEmpty : '' + semver.coerce(graalVMVersionOrDev)?.major
   const graalVMVersion = normalizeInnovationReleaseVersions(graalVMVersionOrDev)
 
-  const githubRelease = await getGraalVMCEGitHubRelease(graalVMVersion, jdkVersion)
+  const githubRelease = await getGraalVMCEGitHubRelease(graalVMVersion)
+  if (githubRelease.name?.includes(jdkVersion)) {
+    core.warning(
+      `JDK version does not match GraalVM CE release. Are you sure java-version: '${jdkVersion}' is correct?`
+    )
+  }
   const downloadUrl = findAssetDownloadUrl(githubRelease)
   const toolName = determineLegacyToolName(false, graalVMVersion, jdkVersion)
   const downloader = async () => downloadGraalVMByJavaVersionJDK(downloadUrl, graalVMVersion)
   return downloadExtractAndCacheJDK(downloader, toolName, graalVMVersion)
 }
 
-async function getGraalVMCEGitHubRelease(
-  graalVMVersion: string,
-  jdkVersion: string
-): Promise<c.LatestReleaseResponseData> {
+async function getGraalVMCEGitHubRelease(graalVMVersion: string): Promise<c.LatestReleaseResponseData> {
+  let tagName
   if (semver.valid(graalVMVersion)) {
-    return await getTaggedRelease(c.GRAALVM_GH_USER, c.GRAALVM_RELEASES_REPO, GRAALVM_GRAAL_TAG_PREFIX + graalVMVersion)
+    tagName = GRAALVM_GRAAL_TAG_PREFIX + graalVMVersion
+  } else {
+    tagName = await findReleaseTagUrl(graalVMVersion)
   }
-  const latestReleases = await getLastReleases(c.GRAALVM_GH_USER, c.GRAALVM_RELEASES_REPO)
-  for (const release of latestReleases) {
-    if (release.tag_name.includes(graalVMVersion)) {
-      return release
+  return await getTaggedRelease(c.GRAALVM_GH_USER, c.GRAALVM_RELEASES_REPO, tagName)
+}
+
+async function findReleaseTagUrl(graalVMVersion: string) {
+  const matchingRefs = await getMatchingTags(
+    c.GRAALVM_GH_USER,
+    c.GRAALVM_RELEASES_REPO,
+    GRAALVM_GRAAL_TAG_PREFIX + graalVMVersion
+  )
+  for (const matchingRef of matchingRefs) {
+    const version = matchingRef.ref.substring(`refs/tags/${GRAALVM_GRAAL_TAG_PREFIX}`.length)
+    if (semver.valid(version)) {
+      return version
+    } else {
+      core.warning(
+        `Unexpected release tag version ${version} for GraalVM version: ${graalVMVersion}. ${c.ERROR_REQUEST}`
+      )
     }
   }
-  throw new Error(
-    `Unable to find GitHub release. Are you sure version: '${graalVMVersion}' and java-version: '${jdkVersion}' correct?`
-  )
+  throw new Error(`Could not find GraalVM CE release tag. Are you sure version: '${graalVMVersion}' is correct?`)
 }
 
 function findAssetDownloadUrl(release: c.LatestReleaseResponseData) {

src/graalvm.ts

@@ -61,15 +61,13 @@ export async function getContents(repo: string, path: string): Promise<c.Content
   ).data
 }
 
-export async function getLastReleases(owner: string, repo: string): Promise<c.ListReleasesResponseData> {
+export async function getLastTags(owner: string, repo: string) {
   const octokit = getOctokit()
-  return (
-    await octokit.request('GET /repos/{owner}/{repo}/releases', {
-      owner,
-      repo,
-      per_page: 100
-    })
-  ).data
+  return octokit.paginate('GET /repos/{owner}/{repo}/tags', {
+    owner,
+    repo,
+    per_page: 100
+  })
 }
 
 export async function getTaggedRelease(owner: string, repo: string, tag: string): Promise<c.LatestReleaseResponseData> {