Skip to content

Commit 5f2aa52

Browse files
authored
Merge pull request #17 from gradio-app/disable-changeset-approval-message
generate-changeset: disable the "Changeset not approved" message and approval checkbox
2 parents e48bb32 + 205b946 commit 5f2aa52

2 files changed

Lines changed: 19 additions & 12 deletions

File tree

actions/generate-changeset/dist/index.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119483,6 +119483,8 @@ function create_changeset_comment({
119483119483
approved_by,
119484119484
changelog_entry_type
119485119485
}) {
119486+
const approval_status = "";
119487+
const approval_checkbox = "";
119486119488
const new_comment = `<!-- tag=changesets_gradio -->
119487119489

119488119490
### 🦄 ${get_title(packages)}
@@ -119497,9 +119499,9 @@ ${format_changelog_preview(changelog, packages, changelog_entry_type)}
119497119499

119498119500
---
119499119501

119500-
${approved ? `✅ Changeset approved${approved_by ? ` by @${approved_by}` : ""}` : "‼️ Changeset not approved. Ensure the version bump is appropriate for all packages before approving."}
119502+
${approval_status}
119501119503

119502-
${approved ? "- [x] Maintainers can remove approval by unchecking this checkbox." : "- [ ] Maintainers can approve the changeset by checking this checkbox."}
119504+
${approval_checkbox}
119503119505

119504119506
<!-- approval_state:${JSON.stringify({ approved, approved_by: approved_by || null })} -->
119505119507

packages/generate-changeset/utils.ts

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,19 @@ export function create_changeset_comment({
196196
approved_by?: string;
197197
changelog_entry_type: string;
198198
}) {
199+
// Changeset approval messaging temporarily disabled (see gradio-app/gradio#13433).
200+
// The "Changeset not approved" notice and the approval checkbox were more hassle
201+
// than value, and the "Changeset Results" check no longer enforces approval. To
202+
// restore the gate, swap these back to the commented-out expressions below.
203+
const approval_status = "";
204+
// const approval_status = approved
205+
// ? `✅ Changeset approved${approved_by ? ` by @${approved_by}` : ""}`
206+
// : "‼️ Changeset not approved. Ensure the version bump is appropriate for all packages before approving.";
207+
const approval_checkbox = "";
208+
// const approval_checkbox = approved
209+
// ? "- [x] Maintainers can remove approval by unchecking this checkbox."
210+
// : "- [ ] Maintainers can approve the changeset by checking this checkbox.";
211+
199212
const new_comment = `<!-- tag=changesets_gradio -->
200213
201214
### 🦄 ${get_title(packages)}
@@ -214,17 +227,9 @@ ${format_changelog_preview(changelog, packages, changelog_entry_type)}
214227
215228
---
216229
217-
${
218-
approved
219-
? `✅ Changeset approved${approved_by ? ` by @${approved_by}` : ''}`
220-
: "‼️ Changeset not approved. Ensure the version bump is appropriate for all packages before approving."
221-
}
230+
${approval_status}
222231
223-
${
224-
approved
225-
? "- [x] Maintainers can remove approval by unchecking this checkbox."
226-
: "- [ ] Maintainers can approve the changeset by checking this checkbox."
227-
}
232+
${approval_checkbox}
228233
229234
<!-- approval_state:${JSON.stringify({ approved, approved_by: approved_by || null })} -->
230235

0 commit comments

Comments
 (0)