Commit e8f120e
BillionClaw
fix(dataframe): prevent freeze when selecting cell with Ctrl key
When selecting a cell in gr.DataFrame by clicking (mousedown), then
pressing Ctrl, then releasing the mouse (mouseup), the interface would
freeze. This happened because:
1. On mousedown without Ctrl: handle_cell_click was called, selecting the cell
2. On mouseup with Ctrl pressed: handle_cell_click was called again due to
the drag_state tracking, but with ctrlKey=true in the event
3. This caused toggle behavior (deselect) and inconsistent state
The fix adds a handled_cell_click flag to track when handle_cell_click
has already been invoked during start_drag, preventing duplicate calls
in end_drag that could lead to the freeze.
Fixes #130201 parent 356db5c commit e8f120e
2 files changed
Lines changed: 8 additions & 2 deletions
File tree
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
768 | 768 | | |
769 | 769 | | |
770 | 770 | | |
| 771 | + | |
771 | 772 | | |
772 | 773 | | |
773 | 774 | | |
774 | 775 | | |
775 | | - | |
| 776 | + | |
| 777 | + | |
776 | 778 | | |
777 | 779 | | |
778 | 780 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| |||
41 | 42 | | |
42 | 43 | | |
43 | 44 | | |
| 45 | + | |
44 | 46 | | |
45 | 47 | | |
46 | 48 | | |
47 | 49 | | |
48 | 50 | | |
| 51 | + | |
49 | 52 | | |
50 | 53 | | |
51 | 54 | | |
| |||
64 | 67 | | |
65 | 68 | | |
66 | 69 | | |
67 | | - | |
| 70 | + | |
68 | 71 | | |
69 | 72 | | |
70 | 73 | | |
| |||
74 | 77 | | |
75 | 78 | | |
76 | 79 | | |
| 80 | + | |
77 | 81 | | |
78 | 82 | | |
79 | 83 | | |
| |||
0 commit comments