Skip to content

Commit e0dec1c

Browse files
authored
Merge pull request #157 from gradle/jb/convert-file-properties
Convert some file name string properties to RegularFileProperty
2 parents 09eea23 + add1ba1 commit e0dec1c

4 files changed

Lines changed: 6 additions & 4 deletions

File tree

unified-prototype/gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions-snapshots/gradle-8.12-20241105002153+0000-bin.zip
3+
distributionUrl=https\://services.gradle.org/distributions-snapshots/gradle-8.13-20250127102731+0000-bin.zip
44
networkTimeout=10000
55
validateDistributionUrl=true
66
zipStoreBase=GRADLE_USER_HOME

unified-prototype/unified-plugin/plugin-android/src/main/java/org/gradle/api/experimental/android/AbstractAndroidSoftwarePlugin.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ protected void configureSecrets(Project project, AndroidSoftware dslModel) {
149149
project.getPlugins().apply("com.google.android.libraries.mapsplatform.secrets-gradle-plugin");
150150

151151
SecretsPluginExtension secrets = project.getExtensions().getByType(SecretsPluginExtension.class);
152-
ifPresent(dslModel.getSecrets().getDefaultPropertiesFileName(), secrets::setDefaultPropertiesFileName);
152+
ifPresent(dslModel.getSecrets().getDefaultPropertiesFile(), file -> secrets.setDefaultPropertiesFileName(file.getAsFile().getName()));
153153
}
154154
}
155155

unified-prototype/unified-plugin/plugin-android/src/main/java/org/gradle/api/experimental/android/extensions/Secrets.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package org.gradle.api.experimental.android.extensions;
22

3+
import org.gradle.api.file.RegularFileProperty;
34
import org.gradle.api.provider.Property;
45
import org.gradle.declarative.dsl.model.annotations.Restricted;
56

@@ -9,5 +10,5 @@ public interface Secrets {
910
Property<Boolean> getEnabled();
1011

1112
@Restricted
12-
Property<String> getDefaultPropertiesFileName();
13+
RegularFileProperty getDefaultPropertiesFile();
1314
}

unified-prototype/unified-plugin/plugin-android/src/main/java/org/gradle/api/experimental/android/library/AndroidLibrary.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818

1919
import org.gradle.api.Action;
2020
import org.gradle.api.experimental.android.AndroidSoftware;
21+
import org.gradle.api.file.RegularFileProperty;
2122
import org.gradle.api.provider.Property;
2223
import org.gradle.api.experimental.android.extensions.Protobuf;
2324
import org.gradle.api.tasks.Nested;
@@ -46,7 +47,7 @@ default void buildTypes(Action<? super AndroidLibraryBuildTypes> action) {
4647

4748
// TODO:DG We really want to model a list of consumer proguard files here, but can't yet
4849
@Restricted
49-
Property<String> getConsumerProguardFile();
50+
RegularFileProperty getConsumerProguardFile();
5051

5152
@Nested
5253
Protobuf getProtobuf();

0 commit comments

Comments
 (0)