Skip to content

Commit 2be0ef3

Browse files
[CI] small tidy changes (#73)
* [CI] small tidy/nit Signed-off-by: TheRealNoob <[email protected]> * fix missed renames Signed-off-by: TheRealNoob <[email protected]> * fix natural language Signed-off-by: TheRealNoob <[email protected]> --------- Signed-off-by: TheRealNoob <[email protected]> Co-authored-by: Jan-Otto Kröpke <[email protected]>
1 parent 0548273 commit 2be0ef3

File tree

5 files changed

+13
-9
lines changed

5 files changed

+13
-9
lines changed

.github/CODEOWNERS

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
# This file is auto-generated by scripts/generate-codeowners.sh. Do not edit manually.
2+
13
# See https://github.com/prometheus-community/helm-charts/issues/12
24
# https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners
35
# https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners#codeowners-syntax

.github/workflows/ci.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,8 @@ jobs:
7070
- name: Run chart-testing (install)
7171
run: ct install --config .github/linters/ct.yaml
7272

73-
check-codeowners-maintainers:
74-
name: Check CODEOWNERS & MAINTAINERS.md
73+
check-generated-files:
74+
name: Check generated files
7575
runs-on: ubuntu-24.04
7676
permissions:
7777
contents: read
@@ -83,15 +83,15 @@ jobs:
8383

8484
- name: generate CODEOWNERS
8585
run: |
86-
./scripts/check-codeowners.sh | tee .github/CODEOWNERS
86+
./scripts/generate-codeowners.sh | tee .github/CODEOWNERS
8787
8888
- name: check CODEOWNERS for modifications
8989
run: |
9090
git diff --exit-code
9191
9292
- name: generate MAINTAINERS.md
9393
run: |
94-
./scripts/check-maintainers.sh | tee MAINTAINERS.md
94+
./scripts/generate-maintainers.sh | tee MAINTAINERS.md
9595
9696
- name: check MAINTAINERS.md for modifications
9797
run: |
@@ -213,7 +213,7 @@ jobs:
213213
runs-on: ubuntu-24.04
214214
needs:
215215
- lint-test
216-
- check-codeowners-maintainers
216+
- check-generated-files
217217
- super-linter
218218
if: >-
219219
github.event.pull_request.head.repo.full_name == github.repository

AGENTS.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,15 +34,15 @@ make helm-docs
3434

3535
- **One chart per PR**: CI enforces that PRs only change a single chart.
3636
- **PR title format**: Must start with `[chart-name] ` (e.g., `[grafana] Add new feature`).
37-
- **Version bumps**: Every chart change (excluding files listed in `.helmignore`) requires a semver version bump in `Chart.yaml`. Major bumps for breaking changes.
37+
- **Version bumps**: Every chart change (excluding files listed in `.helmignore`) requires a SemVer version bump in `Chart.yaml`. Major bumps for breaking changes.
3838
- **DCO sign-off**: Commits must include `Signed-off-by` line (`git commit -s`).
39-
- **Squash merge only**: The repo only allows squash merges.
40-
- **CODEOWNERS/MAINTAINERS**: Auto-generated from `Chart.yaml` maintainer entries by `scripts/check-codeowners.sh` and `scripts/check-maintainers.sh`. Do not edit `.github/CODEOWNERS` or `MAINTAINERS.md` directly.
39+
- **Squash merge only**: The repository only allows squash merges.
40+
- **CODEOWNERS/MAINTAINERS**: Auto-generated from `Chart.yaml` maintainer entries by `scripts/generate-codeowners.sh` and `scripts/generate-maintainers.sh`. Do not edit `.github/CODEOWNERS` or `MAINTAINERS.md` directly.
4141
- **Minimum Kubernetes version**: Charts target `^1.25.0-0` (`kubeVersion` in `Chart.yaml`).
4242

4343
## Dependency Management
4444

45-
Renovate manages automated dependency updates. Charts with subchart dependencies (e.g., `tempo-distributed` depends on `minio`, `grafana-agent-operator`, `rollout-operator`) declare them in `Chart.yaml`. Dependency repos used in CI/release:
45+
Renovate manages automated dependency updates. Charts with subchart dependencies (e.g., `tempo-distributed` depends on `minio`, `grafana-agent-operator`, `rollout-operator`) declare them in `Chart.yaml`. Dependency repositories used in CI/release:
4646

4747
```
4848
bitnami, grafana, grafana-community, prometheus-community, minio
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
export LC_ALL=C
55

66
cat <<EOF
7+
# This file is auto-generated by scripts/generate-codeowners.sh. Do not edit manually.
8+
79
# See https://github.com/prometheus-community/helm-charts/issues/12
810
# https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners
911
# https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners#codeowners-syntax

0 commit comments

Comments
 (0)