Skip to content

Commit 3952bf3

Browse files
authored
[CI] re-enable linter (#30)
1 parent 0d2ab2d commit 3952bf3

9 files changed

Lines changed: 60 additions & 17 deletions

File tree

.github/linters/.markdown-lint.yml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,14 @@
11
MD013:
22
line_length: 600
3+
MD060:
4+
enabled: false
5+
MD022:
6+
enabled: false
7+
MD031:
8+
enabled: false
9+
MD032:
10+
enabled: false
11+
MD033:
12+
enabled: false
13+
MD034:
14+
enabled: false

.github/linters/.textlintrc

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
{
2+
"filters": {
3+
"comments": true,
4+
"allowlist": {
5+
"allow": [
6+
"e-mail"
7+
]
8+
}
9+
},
10+
"rules": {
11+
"terminology": true
12+
}
13+
}

.github/workflows/ci.yaml

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ jobs:
1717
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
1818
with:
1919
fetch-depth: 0
20+
persist-credentials: false
2021

2122
- name: Set up Helm
2223
uses: azure/setup-helm@1a275c3b69536ee54be43f2070a358922e12c8d4 # v4.3.1
@@ -77,6 +78,8 @@ jobs:
7778
steps:
7879
- name: Checkout Code
7980
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
81+
with:
82+
persist-credentials: false
8083

8184
- name: generate CODEOWNERS
8285
run: |
@@ -103,29 +106,34 @@ jobs:
103106
- name: Checkout Code
104107
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
105108
with:
109+
persist-credentials: false
106110
fetch-depth: 0
107111

108112
- name: Lint Code Base
109113
uses: super-linter/super-linter/slim@61abc07d755095a68f4987d1c2c3d1d64408f1f9 # v8.5.0
110114
env:
111115
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
112-
LINTER_RULES_PATH: .github/linters
113116
MULTI_STATUS: false
117+
LINTER_RULES_PATH: .github/linters
118+
ENABLE_GITHUB_ACTIONS_STEP_SUMMARY: true
119+
ENABLE_GITHUB_PULL_REQUEST_SUMMARY_COMMENT: false
120+
SAVE_SUPER_LINTER_SUMMARY: true
114121
VALIDATE_ALL_CODEBASE: false
115122
VALIDATE_BASH: true
116123
VALIDATE_BASH_EXEC: true
117-
# VALIDATE_CHECKOV: true - always scans everything and all charts have too much errors
118124
VALIDATE_EDITORCONFIG: true
119125
VALIDATE_ENV: true
120126
VALIDATE_GITHUB_ACTIONS: true
127+
VALIDATE_GITHUB_ACTIONS_ZIZMOR: true
121128
VALIDATE_GITLEAKS: true
129+
VALIDATE_HTML: true
122130
VALIDATE_JSON: true
123-
# VALIDATE_MARKDOWN: true #TODO: fix lint issues
124-
# VALIDATE_NATURAL_LANGUAGE: true #TODO: fix lint issues
125-
VALIDATE_PYTHON: true
126-
VALIDATE_RENOVATE: true # does not support newest renovate config
131+
VALIDATE_NATURAL_LANGUAGE: true
132+
# VALIDATE_MARKDOWN: true - disable to for now.
133+
VALIDATE_RENOVATE: true
127134
VALIDATE_SHELL_SHFMT: true
128-
VALIDATE_XML: true
135+
# VALIDATE_XML: true
136+
# VALIDATE_YAML: true
129137
validate-pr:
130138
name: Validate PR Metadata
131139
runs-on: ubuntu-24.04
@@ -210,7 +218,7 @@ jobs:
210218
if: >-
211219
github.event.pull_request.head.repo.full_name == github.repository
212220
&& contains(github.event.pull_request.labels.*.name, 'dependencies/auto-merge')
213-
&& (github.actor == 'renovate[bot]' || github.actor == 'mend[bot]' || github.actor == 'helm-charts-renovate-helper[bot]')
221+
&& (github.event.pull_request.user.login == 'renovate[bot]' || github.event.pull_request.user.login == 'helm-charts-renovate-helper-app[bot]')
214222
steps:
215223
# Using a GitHub App token, because GitHub Actions doesn't run on commits from github-actions bot
216224
# Used App:

.github/workflows/release.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ jobs:
1818
steps:
1919
- name: Checkout Code
2020
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
21+
with:
22+
persist-credentials: false
2123

2224
- name: Fetch history
2325
run: git fetch --prune --unshallow

.github/workflows/renovate-custom-hooks.yaml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
name: renovate hooks
22

3+
permissions: {}
4+
35
on:
46
pull_request:
57
branches:
@@ -10,11 +12,14 @@ on:
1012
jobs:
1113
renovate-post-run:
1214
name: Renovate Post Run
13-
runs-on: ubuntu-latest
14-
if: github.actor == 'renovate[bot]' || github.actor == 'mend[bot]'
15+
runs-on: ubuntu-24.04
16+
permissions:
17+
contents: read
18+
if: github.event.pull_request.user.login == 'renovate[bot]'
1519
steps:
1620
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
1721
with:
22+
persist-credentials: false
1823
fetch-depth: 0
1924

2025
# Using a GitHub App token, because GitHub Actions doesn't run on commits from github-actions bot

.github/workflows/sync-readme.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,13 @@ jobs:
1515
runs-on: ubuntu-24.04
1616
steps:
1717
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
18+
with:
19+
persist-credentials: false
1820
- run: |
1921
cp -f README.md ${{ runner.temp }}/README.md
2022
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
2123
with:
24+
persist-credentials: true
2225
ref: gh-pages
2326
- run: |
2427
cp -f ${{ runner.temp }}/README.md .

CONTRIBUTING.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ See `git help commit`:
3636
* Must pass [DCO check](#sign-off-your-work)
3737
* Must follow [Charts best practices](https://helm.sh/docs/topics/chart_best_practices/)
3838
* Must pass CI jobs for linting and installing changed charts with the [chart-testing](https://github.com/helm/chart-testing) tool
39-
* Any change to a chart requires a version bump following [semver](https://semver.org/) principles. See [Immutability](#immutability) and [Versioning](#versioning) below
39+
* Any change to a chart requires a version bump following [SemVer](https://semver.org/) principles. See [Immutability](#immutability) and [Versioning](#versioning) below
4040

4141
Once changes have been merged, the release job will automatically run to package and release changed charts.
4242

@@ -46,14 +46,14 @@ Chart releases must be immutable. Any change to a chart warrants a chart version
4646

4747
### Versioning
4848

49-
The chart `version` should follow [semver](https://semver.org/).
49+
The chart `version` should follow [SemVer](https://semver.org/).
5050

5151
Charts should start at `1.0.0`. Any breaking (backwards incompatible) changes to a chart should:
5252

5353
1. Bump the MAJOR version
54-
2. In the README, under a section called "Upgrading", describe the manual steps necessary to upgrade to the new (specified) MAJOR version
54+
2. In the readme, under a section called "Upgrading", describe the manual steps necessary to upgrade to the new (specified) MAJOR version
5555

56-
### Generate README
56+
### Generate readme
5757

5858
The readme of each chart can be re-generated with the following command (run inside the chart directory):
5959

PROCESSES.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ maintainers:
2323
url: # The URL of the GitHub profile, using the format https://github.com/<username>. Required.
2424
```
2525
26-
### Community admins (including repo admins)
26+
### Community admins (including repository admins)
2727
2828
Chart admins are responsible for managing the repository (for example: housekeeping and adding new chart maintainers).
2929
They are also the point of contact for existing chart maintainers.

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,15 @@ The code is provided as-is with no warranties.
1111
[Helm](https://helm.sh) must be installed to use the charts.
1212
Please refer to Helm's [documentation](https://helm.sh/docs/) to get started.
1313

14-
Once Helm is set up properly, add the repo as follows:
14+
Once Helm is set up properly, add the repository as follows:
1515

1616
```console
1717
helm repo add grafana-community https://grafana-community.github.io/helm-charts
1818
```
1919

2020
You can then run `helm search repo grafana-community` to see the charts.
2121

22-
<!-- Keep full URL links to repo files because this README syncs from main to gh-pages. -->
22+
<!-- Keep full URL links to repository files because this README syncs from main to gh-pages. -->
2323
Chart documentation is available in [grafana directory](https://github.com/grafana-community/helm-charts/blob/main/charts/grafana/README.md).
2424

2525
**OCI artifacts of all Grafana Community Helm charts are available in [ghcr.io](https://github.com/orgs/grafana-community/packages?repo_name=helm-charts).**

0 commit comments

Comments
 (0)