[loki] fix nil pointer in rolebinding.yaml (#315)

Author: KyriosGN0

charts/loki/Chart.yaml

@@ -4,7 +4,7 @@ description: Helm chart for Grafana Loki supporting monolithic, simple scalable,
 type: application
 # renovate: docker=docker.io/grafana/loki
 appVersion: 3.7.1
-version: 11.4.3
+version: 11.4.4
 kubeVersion: ">=1.25.0-0"
 home: https://grafana-community.github.io/helm-charts
 sources:

charts/loki/templates/rolebinding.yaml

@@ -12,6 +12,6 @@ roleRef:
   name: {{ include "loki.name" . }}
 subjects:
   - kind: ServiceAccount
-    name: {{ include "loki.serviceAccountName" . }}
+    name: {{ include "loki.serviceAccountName" (dict "ctx" . "component" .Values "target" "") }}
     namespace: {{ include "loki.namespace" $ }}
 {{- end }}

charts/loki/tests/rolebinding_test.yaml

@@ -0,0 +1,79 @@
+# $schema: https://raw.githubusercontent.com/helm-unittest/helm-unittest/refs/heads/main/schema/helm-testsuite.json
+suite: rolebinding
+templates:
+  - rolebinding.yaml
+
+tests:
+  - it: is not rendered by default
+    asserts:
+      - hasDocuments:
+          count: 0
+
+  - it: is not rendered when namespaced=true but sidecar.rules.enabled=false
+    set:
+      rbac.namespaced: true
+      sidecar.rules.enabled: false
+    asserts:
+      - hasDocuments:
+          count: 0
+
+  - it: is rendered when rbac.namespaced=true and sidecar.rules.enabled=true
+    set:
+      rbac.namespaced: true
+      sidecar.rules.enabled: true
+    asserts:
+      - hasDocuments:
+          count: 1
+      - equal:
+          path: kind
+          value: RoleBinding
+
+  - it: is rendered when rbac.sccEnabled=true
+    set:
+      rbac.sccEnabled: true
+    asserts:
+      - hasDocuments:
+          count: 1
+      - equal:
+          path: kind
+          value: RoleBinding
+
+  - it: subject uses global service account name by default (namespaced)
+    set:
+      rbac.namespaced: true
+      sidecar.rules.enabled: true
+    asserts:
+      - equal:
+          path: subjects[0].name
+          value: RELEASE-NAME-loki
+
+  - it: subject uses custom serviceAccount.name when set (namespaced)
+    set:
+      rbac.namespaced: true
+      sidecar.rules.enabled: true
+      serviceAccount.name: my-custom-sa
+    asserts:
+      - equal:
+          path: subjects[0].name
+          value: my-custom-sa
+
+  - it: subject uses custom serviceAccount.name when set (sccEnabled)
+    set:
+      rbac.sccEnabled: true
+      serviceAccount.name: my-custom-sa
+    asserts:
+      - equal:
+          path: subjects[0].name
+          value: my-custom-sa
+
+  - it: roleRef references the loki role by name
+    set:
+      rbac.namespaced: true
+      sidecar.rules.enabled: true
+    asserts:
+      - equal:
+          path: roleRef.name
+          value: loki
+      - equal:
+          path: roleRef.kind
+          value: Role