Skip to content

Commit 6619130

Browse files
committed
Don't use defer statement to set running to false in error cases
1 parent 1eb4bff commit 6619130

1 file changed

Lines changed: 2 additions & 11 deletions

File tree

extension/alloyengine/extension.go

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -90,27 +90,18 @@ func newAlloyEngineExtension(config *Config, settings component.TelemetrySetting
9090
}
9191

9292
func (e *alloyEngineExtension) Start(_ context.Context, host component.Host) error {
93-
var startErr error
94-
defer func() {
95-
if startErr != nil {
96-
running.Store(false)
97-
}
98-
}()
99-
10093
currentState := e.getState()
10194
switch currentState {
10295
case stateNotStarted:
10396
break
10497
default:
105-
startErr = fmt.Errorf("cannot start alloyengine extension in current state: %s", currentState)
106-
return startErr
98+
return fmt.Errorf("cannot start alloyengine extension in current state: %s", currentState)
10799
}
108100

109101
runCommand := e.runCommandFactory()
110102
runCommand.SetArgs([]string{e.config.AlloyConfig.File})
111103
if err := runCommand.ParseFlags(e.config.flagsAsSlice()); err != nil {
112-
startErr = fmt.Errorf("failed to parse flags: %w", err)
113-
return startErr
104+
return fmt.Errorf("failed to parse flags: %w", err)
114105
}
115106

116107
// Here we check if another extension instance is already running, if so we return an error

0 commit comments

Comments
 (0)