Apply suggestions from code review

Co-authored-by: Kyle Eckhart <[email protected]>

Author: ptodev

internal/static/metrics/wal/wal.go

@@ -91,8 +91,8 @@ func newStorageMetrics(r prometheus.Registerer) *storageMetrics {
 	})
 
 	m.totalAppendedMetadata = prometheus.NewCounter(prometheus.CounterOpts{
-		Name: "prometheus_remote_write_wal_metadata_appended_total",
-		Help: "Total number of metadata entries appended to the WAL",
+		Name: "prometheus_remote_write_wal_metadata_updates_total",
+		Help: "Total number of metadata updates sent through the WAL",
 	})
 
 	if r != nil {

internal/static/metrics/wal/wal_test.go

@@ -231,7 +231,7 @@ prometheus_remote_write_wal_samples_appended_total 40
 		"prometheus_remote_write_wal_metadata_appended_total",
 		"prometheus_remote_write_wal_samples_appended_total",
 	)
-	require.NoError(t, err, "expected prometheus registry to be empty")
+	require.NoError(t, err)
 }
 
 func TestStorage_Rollback(t *testing.T) {