Unused `path_prefix` config argument for `pyroscope.scrape`

[ptodev]

What's wrong?

The docs for pyroscope.scrape include a path_prefix argument, but the code for pyroscope.scrape doesn't seem to do anything with it.

We need to get a confirmation from the Pyroscope team that this config attribute is actually useful and that we should make it work. Otherwise we could just delete it.

Steps to reproduce

No need to reproduce.

System information

No response

Software version

No response

Configuration

No response

Logs

No response

[cyriltovena]

I can confirm this can be useful when running a custom path prefix. Pretty much likes Prometheus scraping path.

[hainenber]

CMIIW but the pyroscope.scrape component seems to allow defining custom paths for each pprofendpoint

For example, profile.goroutine block

Me thinks we can remove it :D

[ptodev]

@hainenber that's true, but it might be inconvenient to override for all types of profiles.

[hainenber]

While it's tedious to do the override but I think that gives a more granular control to the users. In addition, they don't need to check other options that would override theirs. Just simple path for each profile :D

Overall, I think it's a good DX and bless to folks designing this initially 😄

[github-actions]

This issue has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If the opened issue is a bug, check to see if a newer release fixed your issue. If it is no longer relevant, please feel free to close this issue.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your issue will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

[rfratto]

Hi there 👋

On April 9, 2024, Grafana Labs announced Grafana Alloy, the spirital successor to Grafana Agent and the final form of Grafana Agent flow mode. As a result, Grafana Agent has been deprecated and will only be receiving bug and security fixes until its end-of-life around November 1, 2025.

To make things easier for maintainers, we're in the process of migrating all issues tagged variant/flow to the Grafana Alloy repository to have a single home for tracking issues. This issue is likely something we'll want to address in both Grafana Alloy and Grafana Agent, so just because it's being moved doesn't mean we won't address the issue in Grafana Agent :)