Add tests

Author: leonorfmartins

pkg/aws/aws.go

@@ -384,14 +384,15 @@ func filterExcludedRegions(regions []types.Region, excludeList []string) []types
 
 func newRegionClientMap(ctx context.Context, globalConfig aws.Config, pricingConfig aws.Config, regions []types.Region, profile string, roleARN string) (map[string]client.Client, error) {
 	awsClientPerRegion := make(map[string]client.Client)
+	pricingAPI := awsPricing.NewFromConfig(pricingConfig)
 	for _, region := range regions {
 		ac, err := createAWSConfig(ctx, *region.RegionName, profile, roleARN)
 		if err != nil {
 			return nil, err
 		}
 		awsClientPerRegion[*region.RegionName] = client.NewAWSClient(
 			client.Config{
-				PricingService: awsPricing.NewFromConfig(pricingConfig),
+				PricingService: pricingAPI,
 				EC2Service:     ec2.NewFromConfig(ac),
 				BillingService: costexplorer.NewFromConfig(globalConfig),
 				RDSService:     rds.NewFromConfig(ac),

pkg/aws/elb/elb_test.go

@@ -152,6 +152,52 @@ func TestFetchRegionPricing(t *testing.T) {
 	assert.Equal(t, 0.006, pricing.NLBHourlyRate[LCUUsage])
 }
 
+func TestCollect_EmitsMetrics(t *testing.T) {
+	ctrl := gomock.NewController(t)
+	mockPricingClient := mock_client.NewMockClient(ctrl)
+	mockRegionClient := mock_client.NewMockClient(ctrl)
+
+	albLBUsage := `{"Product":{"Attributes":{"usageType":"USE1-LoadBalancerUsage","operation":"LoadBalancing:Application"}},"Terms":{"OnDemand":{"t1":{"PriceDimensions":{"d1":{"pricePerUnit":{"USD":"0.0225"}}}}}}}`
+	albLCUUsage := `{"Product":{"Attributes":{"usageType":"USE1-LCUUsage","operation":"LoadBalancing:Application"}},"Terms":{"OnDemand":{"t1":{"PriceDimensions":{"d1":{"pricePerUnit":{"USD":"0.008"}}}}}}}`
+	mockPricingClient.EXPECT().ListELBPrices(gomock.Any(), "us-east-1").Return([]string{albLBUsage, albLCUUsage}, nil)
+	mockRegionClient.EXPECT().DescribeLoadBalancers(gomock.Any()).Return([]elbTypes.LoadBalancer{
+		{
+			LoadBalancerName: utils.StringPtr("test-alb"),
+			Type:             elbTypes.LoadBalancerTypeEnumApplication,
+		},
+	}, nil)
+
+	config := &Config{
+		ScrapeInterval: time.Minute,
+		Regions:        []ec2Types.Region{{RegionName: utils.StringPtr("us-east-1")}},
+		PricingClient:  mockPricingClient,
+		RegionMap:      map[string]client.Client{"us-east-1": mockRegionClient},
+		AccountID:      "123456789012",
+	}
+
+	collector, err := New(context.Background(), config, slog.Default())
+	require.NoError(t, err)
+
+	ch := make(chan prometheus.Metric, 10)
+	err = collector.Collect(t.Context(), ch)
+	close(ch)
+
+	require.NoError(t, err)
+
+	var metrics []prometheus.Metric
+	for m := range ch {
+		metrics = append(metrics, m)
+	}
+	require.Len(t, metrics, 2)
+
+	descStrings := make(map[string]struct{}, 2)
+	for _, m := range metrics {
+		descStrings[m.Desc().String()] = struct{}{}
+	}
+	assert.Contains(t, descStrings, LoadBalancerUsageHourlyCostDesc.String())
+	assert.Contains(t, descStrings, LoadBalancerCapacityUnitsUsageHourlyCostDesc.String())
+}
+
 func TestFetchRegionPricingError(t *testing.T) {
 	ctrl := gomock.NewController(t)
 	mockClient := mock_client.NewMockClient(ctrl)

pkg/aws/vpc/vpc_test.go

@@ -17,6 +17,7 @@ import (
 	"github.com/prometheus/client_golang/prometheus"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/mock"
+	"github.com/stretchr/testify/require"
 
 	awsclient "github.com/grafana/cloudcost-exporter/pkg/aws/client"
 	"github.com/grafana/cloudcost-exporter/pkg/utils"
@@ -155,6 +156,41 @@ func TestDescribe(t *testing.T) {
 	assert.NoError(t, err)
 }
 
+func TestCollect_EmitsMetrics(t *testing.T) {
+	logger := slog.New(slog.NewTextHandler(os.Stdout, nil))
+	mockClient := &MockClient{}
+
+	products := []string{
+		`{"product":{"attributes":{"usageType":"USE1-VpcEndpoint-Hours","regionCode":"us-east-1"}},"terms":{"OnDemand":{"t1":{"priceDimensions":{"d1":{"pricePerUnit":{"USD":"0.01"}}}}}}}`,
+		`{"product":{"attributes":{"usageType":"USE1-VpcEndpoint-Service-Hours","regionCode":"us-east-1"}},"terms":{"OnDemand":{"t1":{"priceDimensions":{"d1":{"pricePerUnit":{"USD":"0.01"}}}}}}}`,
+		`{"product":{"attributes":{"usageType":"USE1-TransitGateway-Hours","regionCode":"us-east-1"}},"terms":{"OnDemand":{"t1":{"priceDimensions":{"d1":{"pricePerUnit":{"USD":"0.05"}}}}}}}`,
+		`{"product":{"attributes":{"usageType":"USE1-PublicIPv4:InUseAddress","regionCode":"us-east-1"}},"terms":{"OnDemand":{"t1":{"priceDimensions":{"d1":{"pricePerUnit":{"USD":"0.005"}}}}}}}`,
+		`{"product":{"attributes":{"usageType":"USE1-PublicIPv4:IdleAddress","regionCode":"us-east-1"}},"terms":{"OnDemand":{"t1":{"priceDimensions":{"d1":{"pricePerUnit":{"USD":"0.003"}}}}}}}`,
+	}
+	mockClient.On("ListVPCServicePrices", mock.Anything, mock.AnythingOfType("string"), mock.Anything).Return(products, nil)
+
+	collector, err := New(t.Context(), &Config{
+		ScrapeInterval: time.Hour,
+		Regions:        []ec2Types.Region{{RegionName: utils.StringPtr("us-east-1")}},
+		Client:         mockClient,
+		AccountID:      "123456789012",
+	}, logger)
+	require.NoError(t, err)
+
+	ch := make(chan prometheus.Metric, 10)
+	err = collector.Collect(t.Context(), ch)
+	close(ch)
+
+	require.NoError(t, err)
+
+	var metrics []prometheus.Metric
+	for m := range ch {
+		metrics = append(metrics, m)
+	}
+	// One metric per rate type: VPC endpoint, VPC service endpoint, Transit Gateway, EIP in-use, EIP idle
+	assert.Len(t, metrics, 5)
+}
+
 // Test that VPC pricing map methods return errors when no data is available
 func TestVPCPricingMapErrors(t *testing.T) {
 	// Use a logger that discards output to reduce test noise