fix(context): thread ctx through call chains missing context parameter (#825)

Author: stephan-rayner

pkg/aws/aws.go

@@ -299,7 +299,7 @@ func createAWSConfig(ctx context.Context, region, profile, roleARN string) (aws.
 	}
 
 	if roleARN != "" {
-		role, err := assumeRole(roleARN, optionsFunc)
+		role, err := assumeRole(ctx, roleARN, optionsFunc)
 		if err != nil {
 			return aws.Config{}, err
 		}
@@ -309,9 +309,9 @@ func createAWSConfig(ctx context.Context, region, profile, roleARN string) (aws.
 	return awsconfig.LoadDefaultConfig(ctx, optionsFunc...)
 }
 
-func assumeRole(roleARN string, options []func(*awsconfig.LoadOptions) error) (awsconfig.LoadOptionsFunc, error) {
+func assumeRole(ctx context.Context, roleARN string, options []func(*awsconfig.LoadOptions) error) (awsconfig.LoadOptionsFunc, error) {
 	// Add the credentials to assume the role specified in config.RoleARN
-	ac, err := awsconfig.LoadDefaultConfig(context.Background(), options...)
+	ac, err := awsconfig.LoadDefaultConfig(ctx, options...)
 	if err != nil {
 		return nil, err
 	}

pkg/aws/elb/elb.go

@@ -104,7 +104,7 @@ func (c *Collector) Collect(ctx context.Context, ch chan<- prometheus.Metric) er
 	c.logger.Info("Starting ELB collection")
 
 	if c.shouldScrape() {
-		if err := c.pricingMap.refresh(c.awsRegionClientMap, c.Regions); err != nil {
+		if err := c.pricingMap.refresh(ctx, c.awsRegionClientMap, c.Regions); err != nil {
 			c.logger.Error("Failed to refresh pricing", "error", err)
 			return err
 		}

pkg/aws/elb/pricing_map.go

@@ -64,7 +64,7 @@ func (pm *ELBPricingMap) GetRegionPricing(region string) (*RegionPricing, error)
 	return pricing, nil
 }
 
-func (pm *ELBPricingMap) refresh(client map[string]client.Client, regions []ec2Types.Region) error {
+func (pm *ELBPricingMap) refresh(ctx context.Context, client map[string]client.Client, regions []ec2Types.Region) error {
 	pm.logger.Info("Refreshing ELB pricing data")
 
 	eg := errgroup.Group{}
@@ -73,7 +73,7 @@ func (pm *ELBPricingMap) refresh(client map[string]client.Client, regions []ec2T
 	for _, region := range regions {
 		regionName := *region.RegionName
 		eg.Go(func() error {
-			pricing, err := pm.FetchRegionPricing(client[regionName], context.Background(), regionName)
+			pricing, err := pm.FetchRegionPricing(client[regionName], ctx, regionName)
 			if err != nil {
 				return fmt.Errorf("failed to fetch pricing for region %s: %w", regionName, err)
 			}

pkg/azure/aks/region_mapping_generated.go

@@ -82,7 +82,7 @@ func (c *Collector) Describe(ch chan<- *prometheus.Desc) error {
 func New(ctx context.Context, config *Config, gcpClient client.Client) (*Collector, error) {
 	logger := config.Logger.With("collector", "forwarding_rule")
 
-	pm, err := newPricingMap(logger, gcpClient)
+	pm, err := newPricingMap(ctx, logger, gcpClient)
 	if err != nil {
 		return nil, err
 	}

pkg/google/networking/forwarding_rule.go

@@ -62,14 +62,14 @@ type pricingMap struct {
 	mu        sync.RWMutex
 }
 
-func newPricingMap(logger *slog.Logger, gcpClient client.Client) (*pricingMap, error) {
+func newPricingMap(ctx context.Context, logger *slog.Logger, gcpClient client.Client) (*pricingMap, error) {
 	pm := &pricingMap{
 		pricing:   make(map[string]*pricing),
 		logger:    logger,
 		gcpClient: gcpClient,
 	}
 
-	if err := pm.populate(context.Background()); err != nil {
+	if err := pm.populate(ctx); err != nil {
 		return nil, err
 	}
 	return pm, nil

pkg/google/networking/pricing_map.go

@@ -132,7 +132,7 @@ func TestNewPricingMap_PopulateSuccess(t *testing.T) {
 
 	gcpClient := &stubClient{skus: []*billingpb.Sku{frSku, inSku, outSku}}
 
-	pm, err := newPricingMap(testLogger, gcpClient)
+	pm, err := newPricingMap(context.Background(), testLogger, gcpClient)
 	require.NoError(t, err)
 
 	price, err := pm.GetCostOfForwardingRule("us-west1")
@@ -150,7 +150,7 @@ func TestNewPricingMap_PopulateSuccess(t *testing.T) {
 func TestNewPricingMap_ErrorNoSKUs(t *testing.T) {
 	gcpClient := &stubClient{skus: []*billingpb.Sku{}}
 
-	pm, err := newPricingMap(testLogger, gcpClient)
+	pm, err := newPricingMap(context.Background(), testLogger, gcpClient)
 	require.Nil(t, pm)
 	require.Error(t, err)
 	require.ErrorIs(t, err, ErrNoSKUsFoundForNetworkingService)