mvnw has CRLF instead of LF

[TXC]

Currently docker build examples/java/ will fail due that examples/java/mvnw has CRLF line-endings.

$ docker build ./examples/java/
[+] Building 1.6s (17/18)                                                                                docker:default
 => [internal] load build definition from Dockerfile                                                               0.0s
 => => transferring dockerfile: 644B                                                                               0.0s
 => [internal] load metadata for docker.io/library/eclipse-temurin:21.0.8_9-jre                                    1.1s
 => [internal] load metadata for docker.io/library/eclipse-temurin:21.0.8_9-jdk                                    1.1s
 => [internal] load metadata for ghcr.io/open-telemetry/opentelemetry-operator/autoinstrumentation-java:2.18.1     0.5s
 => [auth] library/eclipse-temurin:pull token for registry-1.docker.io                                             0.0s
 => [internal] load .dockerignore                                                                                  0.0s
 => => transferring context: 2B                                                                                    0.0s
 => [builder 1/6] FROM docker.io/library/eclipse-temurin:21.0.8_9-jdk@sha256:1f3171966c0ca6b7151c56059bc70c40d3b8  0.0s
 => [internal] load build context                                                                                  0.1s
 => => transferring context: 79.50kB                                                                               0.1s
 => [stage-2 1/4] FROM docker.io/library/eclipse-temurin:21.0.8_9-jre@sha256:1297ef4131440ba9d8c17335fa27969e7655  0.0s
 => [agent 1/1] FROM ghcr.io/open-telemetry/opentelemetry-operator/autoinstrumentation-java:2.18.1@sha256:dfccf34  0.0s
 => CACHED [stage-2 2/4] WORKDIR /usr/src/app/                                                                     0.0s
 => CACHED [stage-2 3/4] COPY --from=agent --chown=cnb /javaagent.jar /app/javaagent.jar                           0.0s
 => CACHED [builder 2/6] WORKDIR /usr/src/app/                                                                     0.0s
 => CACHED [builder 3/6] COPY ./mvnw ./pom.xml ./                                                                  0.0s
 => CACHED [builder 4/6] COPY ./.mvn ./.mvn                                                                        0.0s
 => CACHED [builder 5/6] COPY ./src ./src                                                                          0.0s
 => ERROR [builder 6/6] RUN --mount=type=cache,target=/root/.m2 ./mvnw install -DskipTests                         0.3s
------
 > [builder 6/6] RUN --mount=type=cache,target=/root/.m2 ./mvnw install -DskipTests:
0.241 /bin/sh: 1: ./mvnw: not found
------
Dockerfile:10
--------------------
   8 |     COPY ./.mvn ./.mvn
   9 |     COPY ./src ./src
  10 | >>> RUN --mount=type=cache,target=/root/.m2 ./mvnw install -DskipTests
  11 |
  12 |     FROM eclipse-temurin:21.0.8_9-jre
--------------------
ERROR: failed to build: failed to solve: process "/bin/sh -c ./mvnw install -DskipTests" did not complete successfully: exit code: 127

Running dos2unix examples/java/mvnw (not supplied in the image) solves the issue.

[martincostello]

From what I can tell, this isn't the case in the repository. But it may be the case in your local clone.

If I fresh clone the repository in WSL and run docker build examples/java/, it builds successfully.

Similarly, from Windows VS Code shows me the line endings are LF.

Sorry, it's early, I just saw it wasn't the Dockerfile that was the source of the trouble 😅

[martincostello]

I just downloaded the raw file from GitHub and inspected it locally, and it also uses LF not CRLF.

I've pushed a change to add a .gitattributes file that makes some line endings explicit, but I think this is an issue with your local Git configuration changing the line endings.