Panel query changes when switching from a Prometheus core data source type to AMP data source type

[VermaPriyanka]

What happened:
When migrating dashboards from Prometheus core data source to AMP datasource, the query changes, which impacts the data being visualized.

What you expected to happen:
No change in the query

How to reproduce it (as minimally and precisely as possible):

1. Configure a connection to an Amazon Managed Service for Prometheus workspace using 2 datasource types - Prometheus core, and AMP.
2. Create a panel with the query (in the snapshot) with Prometheus data source type selected.
3. Duplicate the panel and change the data source type to AMP data source.

Screenshots

Prometheus data source type:

AMP data source type:

Anything else we need to know?:

Environment:

• Grafana version: 12.0.1
• Plugin version:
• OS Grafana is installed on:
• User OS & Browser:
• Others:

[idastambuk]

I've managed to reproduce, adding it to Next to be looked at soon. Seems like there's something happening with the aggregation (avg)

[itsmylife]

The problem is the importFromAbstractQueries and exportToAbstractQueries in prometheus datasource.. When we change the datasource onChangeDataSource method is triggered in PanelDataQueriesTab component in grafana/grafana. That calls updateQueries and there if the datasource supports import/export abstract queries we ended up running those methods.

When we change the datasource between same type (prometheus to prometheus) it doesn't go to import/export flow. Since we are changing prometheus to amazon-prometheus or vice versa it goes to import/export flow. And import export doesn't really care functions, or labels etc. because it only exports to abstract query

https://github.com/grafana/grafana/blob/fb79be4a4330ae765ce9a4d386ce0c0ccdd160aa/packages/grafana-data/src/types/query.ts#L24-L63

// @grafana/data/types/query.ts

export interface DataSourceWithQueryExportSupport<TQuery extends SchemaDataQuery> {
  exportToAbstractQueries(query: TQuery[]): Promise<AbstractQuery[]>;
}

In abstract query we only have label matchers and nothing else. No functions. So in prometheus we only export label matchers. But for this case it's not enough at all.

I wonder where else we use this interface and for what other purposes. My immediate solution is just to remove import/export abstract queries. But then since the datasource id's are different the expression will be removed. I think we don't want that. As the datasources lookalike we want the expression preserved. But currently there is no clear solution for this.

[fkazem]

When can we expect this bug to be fixed. It's a big blocker for many AMP customers.

[kevinwcyu]

Hi @VermaPriyanka, v12.2.0 of Grafana has migration service for Prometheus data sources configured with SigV4 authentication (PR for that here). When it's enabled with the prometheusTypeMigration feature toggle, it will automatically migrate the Core Prometheus data sources with SigV4 authentication to use the AMP data source. The dashboards won't need any manual migration as described above. It also handles the migration described in #478.