add constants file when grouping by kind

Author: amalavet

codegen/cuekind/generators_test.go

@@ -60,8 +60,8 @@ func TestResourceGenerator(t *testing.T) {
 		files, err := ResourceGenerator("codegen-tests", "pkg/generated", false).Generate(kinds...)
 		require.NoError(t, err)
 		// Check number of files generated
-		// 12 (7 -> object, spec, status, schema, codec, constants) * 2 versions
-		assert.Len(t, files, 12, "should be 12 files generated, got %d", len(files))
+		// 14 = 12 resource files across 2 versions plus 2 app package constants files for the gv client packages
+		assert.Len(t, files, 14, "should be 14 files generated, got %d", len(files))
 		// Check content against the golden files
 		compareToGolden(t, files, "go/groupbykind")
 	})

codegen/jennies/constants.go

@@ -39,6 +39,18 @@ func (c *Constants) Generate(appManifest codegen.AppManifest) (codejen.Files, er
 				path:    filepath.Join(path, "constants.go"),
 			}
 		}
+		if !c.GroupByKind {
+			continue
+		}
+		appPath := GetGeneratedGoTypePath(false, appManifest.Properties().Group, v.Name(), k.MachineName)
+		if _, ok := m[appPath]; ok {
+			continue
+		}
+		m[appPath] = constantsFileParams{
+			group:   appManifest.Properties().FullGroup,
+			version: v.Name(),
+			path:    filepath.Join(appPath, "constants.go"),
+		}
 	}
 	files := make(codejen.Files, 0)
 	for _, v := range m {

codegen/testing/golden_generated/go/groupbykind/customapp/v0_0/constants.go.txt

@@ -0,0 +1,18 @@
+package v0_0
+
+import "k8s.io/apimachinery/pkg/runtime/schema"
+
+const (
+	// APIGroup is the API group used by all kinds in this package
+	APIGroup = "customapp.ext.grafana.com"
+	// APIVersion is the API version used by all kinds in this package
+	APIVersion = "v0-0"
+)
+
+var (
+	// GroupVersion is a schema.GroupVersion consisting of the Group and Version constants for this package
+	GroupVersion = schema.GroupVersion{
+		Group:   APIGroup,
+		Version: APIVersion,
+	}
+)

codegen/testing/golden_generated/go/groupbykind/customapp/v1_0/constants.go.txt

@@ -0,0 +1,18 @@
+package v1_0
+
+import "k8s.io/apimachinery/pkg/runtime/schema"
+
+const (
+	// APIGroup is the API group used by all kinds in this package
+	APIGroup = "customapp.ext.grafana.com"
+	// APIVersion is the API version used by all kinds in this package
+	APIVersion = "v1-0"
+)
+
+var (
+	// GroupVersion is a schema.GroupVersion consisting of the Group and Version constants for this package
+	GroupVersion = schema.GroupVersion{
+		Group:   APIGroup,
+		Version: APIVersion,
+	}
+)