lints

Author: amalavet

cmd/grafana-app-sdk/generate.go

@@ -75,7 +75,7 @@ Allowed values are 'group' and 'kind'. Dictates the packaging of go kinds, where
 	generateCmd.SilenceUsage = true
 }
 
-//nolint:funlen,revive,gocyclo
+//nolint:funlen,revive,gocyclo,gocognit
 func generateCmdFunc(cmd *cobra.Command, _ []string) error {
 	// Global flags
 	sourcePath, err := cmd.Flags().GetString(sourceFlag)

codegen/jennies/manifest.go

@@ -390,13 +390,13 @@ func buildDefaultManifestRolesAndBindings(m codegen.AppManifest) (map[string]cod
 	for i, k := range kindList {
 		if i > 0 {
 			if len(kindList) > 2 {
-				allKindsDesc.WriteString(", ")
+				_, _ = allKindsDesc.WriteString(", ")
 			}
 			if i == len(kindList)-1 {
-				allKindsDesc.WriteString("and ")
+				_, _ = allKindsDesc.WriteString("and ")
 			}
 		}
-		allKindsDesc.WriteString(k)
+		_, _ = allKindsDesc.WriteString(k)
 	}
 	roles := map[string]codegen.AppManifestPropertiesRole{
 		readerKey: {

codegen/preflight/common.go

@@ -11,6 +11,7 @@ import (
 )
 
 const preflightTempDirPattern = "grafana-app-sdk-generate-preflight-*"
+const goSourceFileExtension = ".go"
 
 var errUseOverlayStrategy = errors.New("use overlay strategy")
 

codegen/preflight/tempmod_strategy.go

@@ -74,7 +74,7 @@ func collectGeneratedFiles(files codejen.Files, cwd, goGenRoot, moduleGenRoot st
 	generatedFiles := make([]generatedGoFile, 0, len(files))
 
 	for _, f := range files {
-		if filepath.Ext(f.RelativePath) != ".go" {
+		if filepath.Ext(f.RelativePath) != goSourceFileExtension {
 			continue
 		}
 
@@ -171,12 +171,12 @@ func compileGeneratedGoCodeWithTempModule(ctx tempModuleContext) error {
 	return nil
 }
 
-func createTempModuleRoot() (string, string, error) {
-	tempDir, err := os.MkdirTemp("", preflightTempDirPattern)
+func createTempModuleRoot() (tempDir string, moduleRoot string, err error) {
+	tempDir, err = os.MkdirTemp("", preflightTempDirPattern)
 	if err != nil {
 		return "", "", err
 	}
-	moduleRoot := filepath.Join(tempDir, "module")
+	moduleRoot = filepath.Join(tempDir, "module")
 	if err := os.MkdirAll(moduleRoot, 0o755); err != nil {
 		_ = os.RemoveAll(tempDir)
 		return "", "", err
@@ -206,7 +206,7 @@ func copyGoFilesInDirectory(srcDir, dstDir string) error {
 		return err
 	}
 	for _, entry := range entries {
-		if entry.IsDir() || filepath.Ext(entry.Name()) != ".go" {
+		if entry.IsDir() || filepath.Ext(entry.Name()) != goSourceFileExtension {
 			continue
 		}
 		data, err := os.ReadFile(filepath.Join(srcDir, entry.Name()))