Add SchedulerName to starter, runner and initializer pod

[sharathjag]

Feature Description

Add SchedulerName to starter, runner and initializer pod.
Currently SchedulerName is not an attribute in Pod spec:

k6-operator/api/v1alpha1/testrun_types.go

Line 34 in 13d5108

type Pod struct {

Suggested Solution (optional)

No response

Already existing or connected issues / PRs (optional)

No response

[sharathjag]

Happy to contribute.

[sharathjag]

https://github.com/grafana/k6-operator/compare/main...sharathjag:k6-operator:issue-627?expand=1
Happy to make necessary changes. Please let me know how to proceed.
🙏

[sharathjag]

@yorugac
Thank you.

[yorugac]

Hi @sharathjag, could you please describe your use case in greater details? Does your cluster actually have multiple schedulers or do you expect something different from this value? The branch you linked doesn't do anything with scheduler name so I started to wonder if I understand correctly 🤔

[sharathjag]

Thanks @yorugac

Does your cluster actually have multiple schedulers or do you expect something different from this value?

Yes, we will have multiple schedulers supported on the cluster. For our use-case, we will be using Volcano scheduler benefitting from its queues and quota management.

The branch you linked doesn't do anything with scheduler name

Likely my lack of understanding of the code. I was intending to add schedulerName to the TestRun spec and update Runner Spec in

k6-operator/pkg/resources/jobs/runner.go

Line 177 in ad6c084

Spec: corev1.PodSpec{

If that is not what is needed, happy to coordinate on whatever is necessary

[yorugac]

Hi @sharathjag, thanks for the details.

I'm not sure how often people hit this problem (your issue is literally the first time a scheduler came up), so I'm curious about community feedback.
For example, it is likely possible to assign a custom scheduler to all pods in the given group with the mutating webhook. There could be solutions that allow one to do that quickly, i.e. an already implemented webhook. The quick search points me to the Gatekeeper, but maybe there are others.

I was intending to add schedulerName to the TestRun spec and update Runner Spec in

Yes, that's correct; the branch you linked was doing something different, that's why I was confused.

I guess it's fine to add this to the already extremely large TestRun 🙂 But I'd like to know more on the points above too.

[sharathjag]

Thanks for the response @yorugac

For example, it is likely possible to assign a custom scheduler to all pods in the given group with the mutating webhook. There could be solutions that allow one to do that quickly, i.e. an already implemented webhook. The quick search points me to the Gatekeeper, but maybe there are others.

Thats definitely an option. Definitely considering webhooks as well.
Reason for my inclination towards keeping them in testrun spec is that it is self contained/controlled. Provides option the change the scheduler depending on use-cases.