Trim service names to be under 63 chars

[vinzee]

Brief summary

The controller-manager service defined here has a really long name which along with the fullname goes beyond 63 chars and fails with Invalid value: "...": must be no more than 63 characters.

Although there is a way to proceed by specifying a really small fullnameOverride, the chart should handle such issues by trimming the name automatically.

k6-operator version or image

1.0.0

Helm chart version (if applicable)

1.0.0

TestRun / PrivateLoadZone YAML

n/a

Other environment details (if applicable)

No response

Steps to reproduce the problem

Install k6 operator using helm with fullnameOverride set to synthetics-dev-usw2-01 (22 chars).

Expected behaviour

k6 operator should be installed successfully!

Actual behaviour

fails with Invalid value: "synthetics-dev-usw2-01-k6-operator-controller-manager-metrics-service": must be no more than 63 characters.

(final service name has 69 chars)

[yorugac]

Hi @vinzee, thanks for the issue.

synthetics-dev-usw2-01 works fine AFAIS: resulting name synthetics-dev-usw2-01-controller-manager-metrics-service is less than 63. But I've managed to get a repeat with a slightly longer value like this:

# synthetics-dev-usw2-012345678

$ helm install k6-operator grafana/k6-operator --set fullnameOverride=synthetics-dev-usw2-012345678 --set service.enabled=true
Error: INSTALLATION FAILED: 1 error occurred:
	* Service "synthetics-dev-usw2-012345678-controller-manager-metrics-service" is invalid: metadata.name: Invalid value: "synthetics-dev-usw2-012345678-controller-manager-metrics-service": must be no more than 63 characters

Regarding the solution.

We have truncation by 63 on fullnameOverride itself, but not on the service name which adds hard-coded suffix. There are several such hard-coded suffixes that are added to the fullname, with Service having the largest name. It makes sense to re-check those suffixes and possibly change the one for Service (e.g. to -controller-metrics-service or even -controller-service), or indeed add truncation everywhere.