Skip to content

Commit 6996c30

Browse files
fix: Columns in Rule Editor don't have clear separation (#546)
1 parent d808ce8 commit 6996c30

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

src/views/Generator/RuleEditor/CorrelationEditor.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import {
44
Flex,
55
Grid,
66
Heading,
7+
Separator,
78
Switch,
89
Text,
910
Tooltip,
@@ -59,7 +60,7 @@ export function CorrelationEditor() {
5960
}
6061

6162
return (
62-
<Grid columns="1fr 1fr" gap="3">
63+
<Grid columns="1fr auto 1fr" gap="4">
6364
<Box>
6465
<Heading size="2" weight="medium" mb="2">
6566
Extractor
@@ -99,6 +100,7 @@ export function CorrelationEditor() {
99100
</Text>
100101
)}
101102
</Box>
103+
<Separator orientation="vertical" size="4" decorative />
102104
<Box>
103105
<Flex justify="between" align="center">
104106
<Heading size="2" weight="medium" mb="2">

src/views/Generator/RuleEditor/ParameterizationEditor/ParameterizationEditor.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Box, Grid, Text } from '@radix-ui/themes'
1+
import { Box, Grid, Separator, Text } from '@radix-ui/themes'
22
import { ValueEditor } from './ValueEditor'
33
import { FilterField } from '../FilterField'
44
import { SelectorField } from '../SelectorField'
@@ -9,11 +9,12 @@ export function ParameterizationEditor() {
99
<Text size="2" as="p" mb="2" color="gray">
1010
Replace request data with variables or custom values.
1111
</Text>
12-
<Grid columns="2" gap="3">
12+
<Grid columns="1fr auto 1fr" gap="4">
1313
<Box>
1414
<FilterField field="filter" />
1515
<SelectorField field="selector" />
1616
</Box>
17+
<Separator orientation="vertical" size="4" decorative />
1718
<Box>
1819
<ValueEditor />
1920
</Box>

src/views/Generator/RuleEditor/RuleEditor.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ export function RuleEditor({ rule }: RuleEditorProps) {
123123
</Flex>
124124
</StickyPanelHeader>
125125
<form onSubmit={handleSubmit(onSubmit)}>
126-
<Box p="2" pr="4">
126+
<Box p="2">
127127
{!rule.enabled && <RuleDisabledWarning />}
128128
<RuleEditorSwitch />
129129
</Box>

0 commit comments

Comments
 (0)