internal: Don't track script_validated event when validation is triggered automatically (#930)

Author: going-confetti

src/handlers/script/index.ts

@@ -92,7 +92,7 @@ export function initialize() {
 
   ipcMain.handle(
     ScriptHandler.RunFromGenerator,
-    async (event, script: string) => {
+    async (event, script: string, shouldTrack = true) => {
       console.info(`${ScriptHandler.RunFromGenerator} event received`)
       await writeFile(TEMP_GENERATOR_SCRIPT_PATH, script)
 
@@ -105,12 +105,14 @@ export function initialize() {
         usageReport: k6StudioState.appSettings.telemetry.usageReport,
       })
 
-      trackEvent({
-        event: UsageEventName.ScriptValidated,
-        payload: {
-          isExternal: false,
-        },
-      })
+      if (shouldTrack) {
+        trackEvent({
+          event: UsageEventName.ScriptValidated,
+          payload: {
+            isExternal: false,
+          },
+        })
+      }
 
       await unlink(TEMP_GENERATOR_SCRIPT_PATH)
     }

src/handlers/script/preload.ts

@@ -17,10 +17,11 @@ export function openScript(scriptPath: string) {
   ) as Promise<OpenScriptResult>
 }
 
-export function runScriptFromGenerator(script: string) {
+export function runScriptFromGenerator(script: string, shouldTrack = true) {
   return ipcRenderer.invoke(
     ScriptHandler.RunFromGenerator,
-    script
+    script,
+    shouldTrack
   ) as Promise<void>
 }
 

src/utils/validateScript.ts

@@ -7,7 +7,8 @@ import { processProxyData } from './proxyData'
  */
 export async function validateScript(
   script: string,
-  signal?: AbortSignal
+  signal?: AbortSignal,
+  shouldTrack = true
 ): Promise<ProxyData[]> {
   let collectedData: ProxyData[] = []
 
@@ -51,9 +52,11 @@ export async function validateScript(
     })
 
     // Run the script
-    window.studio.script.runScriptFromGenerator(script).catch((error) => {
-      cleanup()
-      reject(error)
-    })
+    window.studio.script
+      .runScriptFromGenerator(script, shouldTrack)
+      .catch((error) => {
+        cleanup()
+        reject(error)
+      })
   })
 }

src/views/Generator/AutoCorrelation/useGenerateRules.ts

@@ -165,7 +165,8 @@ export const useGenerateRules = ({
 
     const validationResult = await validateScript(
       script,
-      abortControllerRef.current?.signal
+      abortControllerRef.current?.signal,
+      false
     )
 
     const result = validationMatchesRecording(