-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Open
Description
What
group() has two things it does:
- it measures how long the provided callback takes to execute and amits as
group_durationwith agrouptag with the same name as the first argument. - it sets the
grouptag so all things metrics emitted within the callback are tagged with it.
Neither of these currently work with async code due to its implementation. Both are important for users.
The first point is a lot easier to implement as in this gist
The second point is blocked on https://github.com/tc39/proposal-async-context or similar functionality - potentially
#3392 as implementation.
Reading list
groupdoesn't work with async calls well #2728- Try to use
sobek#AsyncContextTrackerto make group for async code #3392 - https://github.com/tc39/proposal-async-context
Next steps
Summarise the proposals in a design doc so that we can align on a single proposal to overcome these two limitations.
Metadata
Metadata
Labels
No labels