From 23d637efcbe3f899d907b2752815cd94fea97d74 Mon Sep 17 00:00:00 2001 From: Periklis Tsirakidis Date: Wed, 9 Apr 2025 15:11:17 +0200 Subject: [PATCH] chore(ingest-limits): Remove sticky-balancer --- pkg/limits/ingest_limits.go | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/pkg/limits/ingest_limits.go b/pkg/limits/ingest_limits.go index 608207be57474..c4e21999d65b9 100644 --- a/pkg/limits/ingest_limits.go +++ b/pkg/limits/ingest_limits.go @@ -173,15 +173,7 @@ func NewIngestLimits(cfg Config, logger log.Logger, reg prometheus.Registerer) ( s.client, err = client.NewReaderClient(kCfg, metrics, logger, kgo.ConsumerGroup(consumerGroup), kgo.ConsumeTopics(kCfg.Topic), - // TODO(periklis): Remove the sticky balancer once we rolled out - // the cooperative sticky balancer. According to KIP-429, once a - // group is using cooperative sticky balancing, it is unsafe to have - // a member join the group that does not support cooperative balancing. - // See group_balancer.go:CooperativeStickyBalancer() for more details. - kgo.Balancers( - kgo.StickyBalancer(), - kgo.CooperativeStickyBalancer(), - ), + kgo.Balancers(kgo.CooperativeStickyBalancer()), kgo.ConsumeResetOffset(kgo.NewOffset().AfterMilli(time.Now().Add(-s.cfg.WindowSize).UnixMilli())), kgo.OnPartitionsAssigned(s.onPartitionsAssigned), kgo.OnPartitionsRevoked(s.onPartitionsRevoked),